Patch Detail
Show a patch.
GET /api/patches/13690/?format=api
{ "id": 13690, "url": "https://patchwork.libcamera.org/api/patches/13690/?format=api", "web_url": "https://patchwork.libcamera.org/patch/13690/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210906225636.14683-24-laurent.pinchart@ideasonboard.com>", "date": "2021-09-06T22:56:30", "name": "[libcamera-devel,v3,24/30] cam: drm: Set per-plane offsets when creating DRM frame buffer", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "243d2e59144b3cecf801296cebe00acd35fc8f6b", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/13690/mbox/", "series": [ { "id": 2482, "url": "https://patchwork.libcamera.org/api/series/2482/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2482", "date": "2021-09-06T22:54:20", "name": "libcamera: Handle fallout of FrameBuffer offset support", "version": 3, "mbox": "https://patchwork.libcamera.org/series/2482/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/13690/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/13690/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id EB6E0BE175\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 6 Sep 2021 22:57:48 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A54B169174;\n\tTue, 7 Sep 2021 00:57:48 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9713B69170\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 7 Sep 2021 00:57:08 +0200 (CEST)", "from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2092FB75;\n\tTue, 7 Sep 2021 00:57:08 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"NWpTdV8/\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1630969028;\n\tbh=BXti2I2EJ1iwmJVBwUsY40z4tz8z+d/4S8F8jRvmlTo=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=NWpTdV8/CazNQH9hKFtnzbvdTJjTobBC3ydCf6Jhb/RG6D5smYFYsebckvIzyd+Ge\n\t29ENwRDqkG63MYk/iFuWYf7MDFyLdQn4ZDcemmiL31I+JubIuQar9eZlklwCGhgAKg\n\ts+n1Sv65kyTEavEOigtp8usPe9DTaJT0Qkcsojig=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 7 Sep 2021 01:56:30 +0300", "Message-Id": "<20210906225636.14683-24-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.32.0", "In-Reply-To": "<20210906225420.13275-1-laurent.pinchart@ideasonboard.com>", "References": "<20210906225420.13275-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v3 24/30] cam: drm: Set per-plane offsets\n\twhen creating DRM frame buffer", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Now that libcamera supports per-plane offsets, pass the values to\ndrmModeAddFB2().\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nReviewed-by: Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>\n---\n src/cam/drm.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/src/cam/drm.cpp b/src/cam/drm.cpp\nindex ac47b8bd3287..d5a75d039fd8 100644\n--- a/src/cam/drm.cpp\n+++ b/src/cam/drm.cpp\n@@ -623,7 +623,7 @@ std::unique_ptr<FrameBuffer> Device::createFrameBuffer(\n \t\tfb->planes_.push_back({ handle });\n \n \t\thandles[i] = handle;\n-\t\toffsets[i] = 0; /* TODO */\n+\t\toffsets[i] = plane.offset;\n \t\t++i;\n \t}\n \n", "prefixes": [ "libcamera-devel", "v3", "24/30" ] }