Patch Detail
Show a patch.
GET /api/patches/13680/?format=api
{ "id": 13680, "url": "https://patchwork.libcamera.org/api/patches/13680/?format=api", "web_url": "https://patchwork.libcamera.org/patch/13680/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210906225636.14683-15-laurent.pinchart@ideasonboard.com>", "date": "2021-09-06T22:56:21", "name": "[libcamera-devel,v3,15/30] libcamera: v4l2_videodevice: Use utils::enumerate()", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "69ae549013deff69ff89050c9ff3576ddb91de6d", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/13680/mbox/", "series": [ { "id": 2482, "url": "https://patchwork.libcamera.org/api/series/2482/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2482", "date": "2021-09-06T22:54:20", "name": "libcamera: Handle fallout of FrameBuffer offset support", "version": 3, "mbox": "https://patchwork.libcamera.org/series/2482/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/13680/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/13680/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9B2FDBE175\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 6 Sep 2021 22:57:28 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5278F6916D;\n\tTue, 7 Sep 2021 00:57:28 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 08E596917E\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 7 Sep 2021 00:57:05 +0200 (CEST)", "from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 96A64993;\n\tTue, 7 Sep 2021 00:57:04 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ENcI9wVQ\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1630969024;\n\tbh=QZnxsi0f7lzKbL9ewSoqOoSOZ2Ze5awXmXVvtbDofVs=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=ENcI9wVQO1+6wHJbYsk+nQGSG5Jm4cG1iT/jI20lObMJAVq0+QMguSlxzQS968vua\n\t+4vnsH44KxNlH38CVdQ6hRW83feyU5BDMRmKApbc2w4SyxZrtlqkp18xVE3i1N+R35\n\tCeT4NGZXTxM2DryjXoQ2FobpfOEGt+ew+RmEz/oo=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 7 Sep 2021 01:56:21 +0300", "Message-Id": "<20210906225636.14683-15-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.32.0", "In-Reply-To": "<20210906225420.13275-1-laurent.pinchart@ideasonboard.com>", "References": "<20210906225420.13275-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v3 15/30] libcamera: v4l2_videodevice: Use\n\tutils::enumerate()", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Replace a manual counter with the utils::enumerate() utility function.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nReviewed-by: Hirokazu Honda <hiroh@chromium.org>\n---\n src/libcamera/v4l2_videodevice.cpp | 12 ++++++------\n 1 file changed, 6 insertions(+), 6 deletions(-)", "diff": "diff --git a/src/libcamera/v4l2_videodevice.cpp b/src/libcamera/v4l2_videodevice.cpp\nindex 2e458fcc22e0..281f3f13fc9c 100644\n--- a/src/libcamera/v4l2_videodevice.cpp\n+++ b/src/libcamera/v4l2_videodevice.cpp\n@@ -1356,7 +1356,7 @@ std::unique_ptr<FrameBuffer> V4L2VideoDevice::createBuffer(unsigned int index)\n \t\tconst FileDescriptor &fd = planes[0].fd;\n \t\tsize_t offset = 0;\n \n-\t\tfor (size_t i = 0; i < planes.size(); ++i) {\n+\t\tfor (auto [i, plane] : utils::enumerate(planes)) {\n \t\t\t/*\n \t\t\t * The stride is reported by V4L2 for the first plane\n \t\t\t * only. Compute the stride of the other planes by\n@@ -1368,11 +1368,11 @@ std::unique_ptr<FrameBuffer> V4L2VideoDevice::createBuffer(unsigned int index)\n \t\t\t\t\t * formatInfo_->planes[i].bytesPerGroup\n \t\t\t\t\t / formatInfo_->planes[0].bytesPerGroup;\n \n-\t\t\tplanes[i].fd = fd;\n-\t\t\tplanes[i].offset = offset;\n-\t\t\tplanes[i].length = formatInfo_->planeSize(format_.size.height,\n-\t\t\t\t\t\t\t\t i, stride);\n-\t\t\toffset += planes[i].length;\n+\t\t\tplane.fd = fd;\n+\t\t\tplane.offset = offset;\n+\t\t\tplane.length = formatInfo_->planeSize(format_.size.height,\n+\t\t\t\t\t\t\t i, stride);\n+\t\t\toffset += plane.length;\n \t\t}\n \t}\n \n", "prefixes": [ "libcamera-devel", "v3", "15/30" ] }