Patch Detail
Show a patch.
GET /api/patches/13606/?format=api
{ "id": 13606, "url": "https://patchwork.libcamera.org/api/patches/13606/?format=api", "web_url": "https://patchwork.libcamera.org/patch/13606/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210902100732.52065-2-jeanmichel.hautbois@ideasonboard.com>", "date": "2021-09-02T10:07:31", "name": "[libcamera-devel,1/2] include: linux: Add an AWB layout structure", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "2a16c5e75292a8862af43d3483e93e0bd97c667c", "submitter": { "id": 75, "url": "https://patchwork.libcamera.org/api/people/75/?format=api", "name": "Jean-Michel Hautbois", "email": "jeanmichel.hautbois@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/13606/mbox/", "series": [ { "id": 2438, "url": "https://patchwork.libcamera.org/api/series/2438/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2438", "date": "2021-09-02T10:07:30", "name": "Replace the Ipu3AwbCell", "version": 1, "mbox": "https://patchwork.libcamera.org/series/2438/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/13606/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/13606/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4ED8FC3241\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 2 Sep 2021 10:07:39 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 612706916F;\n\tThu, 2 Sep 2021 12:07:38 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8825569166\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 2 Sep 2021 12:07:36 +0200 (CEST)", "from tatooine.ideasonboard.com (unknown\n\t[IPv6:2a01:e0a:169:7140:43b0:6633:e0bd:5dc6])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 27BEB1544;\n\tThu, 2 Sep 2021 12:07:36 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"pCiUF/iK\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1630577256;\n\tbh=mZXahkvJizyJq/DH5HS2NhHznTBQIG5nZxAYDFkjvsc=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=pCiUF/iKb9is+qRVCot/hL3ucmPAxX6d65XwDuBKvOW62hTtzyBMSHxGZz5xstRUd\n\tT/0HeFgb5bfyKdLR6VsaUJTt+cnTRxsS0ROQOe5HJr6kmM0j31N3pi2+lGz+9HVeua\n\tpZSR65dhb0Td0uic8eC5uIC3mVHN15eUVBCfdvxg=", "From": "Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 2 Sep 2021 12:07:31 +0200", "Message-Id": "<20210902100732.52065-2-jeanmichel.hautbois@ideasonboard.com>", "X-Mailer": "git-send-email 2.30.2", "In-Reply-To": "<20210902100732.52065-1-jeanmichel.hautbois@ideasonboard.com>", "References": "<20210902100732.52065-1-jeanmichel.hautbois@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 1/2] include: linux: Add an AWB layout\n\tstructure", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "This patch was proposed in:\nhttps://lore.kernel.org/linux-media/20210831185140.77400-1-jeanmichel.hautbois@ideasonboard.com/\n\nIt introduces the AWB metadata layout as a structure in the kernel\nheader, to make it clear for userspace applications.\n\nSigned-off-by: Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>\n---\n include/linux/intel-ipu3.h | 36 ++++++++++++++++++++++++++++--------\n 1 file changed, 28 insertions(+), 8 deletions(-)", "diff": "diff --git a/include/linux/intel-ipu3.h b/include/linux/intel-ipu3.h\nindex ee0e6d0e..cb37d448 100644\n--- a/include/linux/intel-ipu3.h\n+++ b/include/linux/intel-ipu3.h\n@@ -59,20 +59,40 @@ struct ipu3_uapi_grid_config {\n \t__u16 y_end;\n } __attribute__((packed));\n \n+/**\n+ * struct ipu3_uapi_awb_set_item - Memory layout for each cell in AWB\n+ *\n+ * @Gr_avg:\tGreen average for red lines in the cell.\n+ * @R_avg:\tRed average in the cell.\n+ * @B_avg:\tBlue average in the cell.\n+ * @Gb_avg:\tGreen average for blue lines in the cell.\n+ * @sat_ratio: Saturation ratio in the cell.\n+ * @padding0: Unused byte for padding.\n+ * @padding1: Unused byte for padding.\n+ * @padding2: Unused byte for padding.\n+ */\n+struct ipu3_uapi_awb_set_item {\n+\tunsigned char Gr_avg;\n+\tunsigned char R_avg;\n+\tunsigned char B_avg;\n+\tunsigned char Gb_avg;\n+\tunsigned char sat_ratio;\n+\tunsigned char padding0;\n+\tunsigned char padding1;\n+\tunsigned char padding2;\n+} __attribute__((packed));\n+\n /*\n * The grid based data is divided into \"slices\" called set, each slice of setX\n * refers to ipu3_uapi_grid_config width * height_per_slice.\n */\n #define IPU3_UAPI_AWB_MAX_SETS\t\t\t\t60\n-/* Based on grid size 80 * 60 and cell size 16 x 16 */\n-#define IPU3_UAPI_AWB_SET_SIZE\t\t\t\t1280\n-#define IPU3_UAPI_AWB_MD_ITEM_SIZE\t\t\t8\n-#define IPU3_UAPI_AWB_SPARE_FOR_BUBBLES \\\n-\t(IPU3_UAPI_MAX_BUBBLE_SIZE * IPU3_UAPI_MAX_STRIPES * \\\n-\t IPU3_UAPI_AWB_MD_ITEM_SIZE)\n+#define AWB_PUBLIC_NUM_OF_ITEMS_IN_SET\t\t\t160\n+/* Based on max grid height + Spare for bubbles */\n+#define AWB_PUBLIC_NUM_OF_SETS_IN_BUFFER IPU3_UAPI_AWB_MAX_SETS + \\\n+\t(IPU3_UAPI_MAX_BUBBLE_SIZE * IPU3_UAPI_MAX_STRIPES)\n #define IPU3_UAPI_AWB_MAX_BUFFER_SIZE \\\n-\t(IPU3_UAPI_AWB_MAX_SETS * \\\n-\t (IPU3_UAPI_AWB_SET_SIZE + IPU3_UAPI_AWB_SPARE_FOR_BUBBLES))\n+ AWB_PUBLIC_NUM_OF_SETS_IN_BUFFER * AWB_PUBLIC_NUM_OF_ITEMS_IN_SET\n \n \n /**\n", "prefixes": [ "libcamera-devel", "1/2" ] }