Patch Detail
Show a patch.
GET /api/patches/1356/?format=api
{ "id": 1356, "url": "https://patchwork.libcamera.org/api/patches/1356/?format=api", "web_url": "https://patchwork.libcamera.org/patch/1356/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20190605005316.4835-9-paul.elder@ideasonboard.com>", "date": "2019-06-05T00:53:14", "name": "[libcamera-devel,v3,08/10] libcamera: ipa: add dummy IPA implementation", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "1feddc178c97b8ad01c2a5cdee4b9dc8436b7012", "submitter": { "id": 17, "url": "https://patchwork.libcamera.org/api/people/17/?format=api", "name": "Paul Elder", "email": "paul.elder@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/1356/mbox/", "series": [ { "id": 336, "url": "https://patchwork.libcamera.org/api/series/336/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=336", "date": "2019-06-05T00:53:06", "name": "Add IPAManager and IPAInterface", "version": 3, "mbox": "https://patchwork.libcamera.org/series/336/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/1356/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/1356/checks/", "tags": {}, "headers": { "Return-Path": "<paul.elder@ideasonboard.com>", "Received": [ "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B28D864730\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 5 Jun 2019 02:53:33 +0200 (CEST)", "from localhost.localdomain (unknown [96.44.9.117])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id EF314321;\n\tWed, 5 Jun 2019 02:53:32 +0200 (CEST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1559696013;\n\tbh=41C6r/N4G+gjwFb2VC/0pi7nHn96f6VJNjYj9cR/5xU=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=A/OA+W66KZ89bUvW5L3kzaBdw5aSKR1QAw4ygA+YVK+vu857LqUZAEPLuIcVOb3jQ\n\tuHtWyV/BsR8NB/hd+Ew6DNvAILZ/7YuWk+DTpYPe65lPfeZfOfAdnOYQ8gcIyMTD/D\n\tQF4DrENXfTMLcRNihIpcr1m4vvhX7VnnzTdQwHQg=", "From": "Paul Elder <paul.elder@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 4 Jun 2019 20:53:14 -0400", "Message-Id": "<20190605005316.4835-9-paul.elder@ideasonboard.com>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20190605005316.4835-1-paul.elder@ideasonboard.com>", "References": "<20190605005316.4835-1-paul.elder@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v3 08/10] libcamera: ipa: add dummy IPA\n\timplementation", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.23", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Wed, 05 Jun 2019 00:53:34 -0000" }, "content": "Add a dummy IPA module.\n\nSigned-off-by: Paul Elder <paul.elder@ideasonboard.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\nChanges in v3:\n- make meson a bit more DRY\n\nChanges in v2:\n- use macros for defining the version fields in ipaModuleInfo\n\n src/ipa/ipa_dummy.cpp | 45 +++++++++++++++++++++++++++++++++++++++++++\n src/ipa/meson.build | 15 ++++++++++++++-\n 2 files changed, 59 insertions(+), 1 deletion(-)\n create mode 100644 src/ipa/ipa_dummy.cpp", "diff": "diff --git a/src/ipa/ipa_dummy.cpp b/src/ipa/ipa_dummy.cpp\nnew file mode 100644\nindex 0000000..ee7a3a8\n--- /dev/null\n+++ b/src/ipa/ipa_dummy.cpp\n@@ -0,0 +1,45 @@\n+/* SPDX-License-Identifier: LGPL-2.1-or-later */\n+/*\n+ * Copyright (C) 2019, Google Inc.\n+ *\n+ * ipa_dummy.cpp - Dummy Image Processing Algorithm module\n+ */\n+\n+#include <iostream>\n+\n+#include <libcamera/ipa/ipa_interface.h>\n+#include <libcamera/ipa/ipa_module_info.h>\n+\n+namespace libcamera {\n+\n+class IPADummy : public IPAInterface\n+{\n+public:\n+\tint init();\n+};\n+\n+int IPADummy::init()\n+{\n+\tstd::cout << \"initializing dummy IPA!\" << std::endl;\n+\treturn 0;\n+}\n+\n+/*\n+ * External IPA module interface\n+ */\n+\n+extern \"C\" {\n+const struct IPAModuleInfo ipaModuleInfo = {\n+\tIPA_MODULE_API_VERSION,\n+\t0,\n+\t\"PipelineHandlerVimc\",\n+\t\"Dummy IPA for Vimc\",\n+};\n+\n+IPAInterface *ipaCreate()\n+{\n+\treturn new IPADummy();\n+}\n+};\n+\n+}; /* namespace libcamera */\ndiff --git a/src/ipa/meson.build b/src/ipa/meson.build\nindex be4f954..3c33a37 100644\n--- a/src/ipa/meson.build\n+++ b/src/ipa/meson.build\n@@ -1,2 +1,15 @@\n+ipa_dummy_sources = files([\n+ 'ipa_dummy.cpp',\n+])\n+\n+ipa_install_dir = join_paths(get_option('libdir'), 'libcamera')\n+\n+ipa_dummy = shared_library('ipa_dummy',\n+ ipa_dummy_sources,\n+ name_prefix : '',\n+ include_directories : libcamera_includes,\n+ install : true,\n+ install_dir : ipa_install_dir)\n+\n config_h.set('IPA_MODULE_DIR',\n- '\"' + join_paths(get_option('prefix'), get_option('libdir'), 'libcamera') + '\"')\n+ '\"' + join_paths(get_option('prefix'), ipa_install_dir) + '\"')\n", "prefixes": [ "libcamera-devel", "v3", "08/10" ] }