Patch Detail
Show a patch.
GET /api/patches/13529/?format=api
{ "id": 13529, "url": "https://patchwork.libcamera.org/api/patches/13529/?format=api", "web_url": "https://patchwork.libcamera.org/patch/13529/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210827062521.2541170-2-paul.elder@ideasonboard.com>", "date": "2021-08-27T06:25:21", "name": "[libcamera-devel,2/2] test: v4l2_compat_test: Fix v4l2-compliance version parsing", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "99a7132a6da19f8542f867cbc56549ba96ff8884", "submitter": { "id": 17, "url": "https://patchwork.libcamera.org/api/people/17/?format=api", "name": "Paul Elder", "email": "paul.elder@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/13529/mbox/", "series": [ { "id": 2403, "url": "https://patchwork.libcamera.org/api/series/2403/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2403", "date": "2021-08-27T06:25:20", "name": "[libcamera-devel,1/2] v4l2: v4l2_compat_manager: Don't print \"camera not found\" on openat()", "version": 1, "mbox": "https://patchwork.libcamera.org/series/2403/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/13529/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/13529/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9CDE8BD87D\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 27 Aug 2021 06:25:41 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 53B9268932;\n\tFri, 27 Aug 2021 08:25:41 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3187961534\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 27 Aug 2021 08:25:36 +0200 (CEST)", "from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B81B2739;\n\tFri, 27 Aug 2021 08:25:34 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ejowlOMY\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1630045535;\n\tbh=tjS2Z4BqXpaz9zd82bBDJdKUz2PNcdjDJWeG9Pz95QA=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=ejowlOMYAQpRGzX+SxbJNw4r5sdEKV1cQ9IIV/yP1wu5BwKD6xqUt/1v79ac78U5u\n\tWEv9EkT87gGZY3SEMWokWH2IYd3HdYvB1JnqYJ2W37nL9NcqcNsB4ifIvVA7opS1ED\n\tgek+wpBBK9IdOjxlBC8uNECYmYO2ls7qoeCutGOg=", "From": "Paul Elder <paul.elder@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 27 Aug 2021 15:25:21 +0900", "Message-Id": "<20210827062521.2541170-2-paul.elder@ideasonboard.com>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20210827062521.2541170-1-paul.elder@ideasonboard.com>", "References": "<20210827062521.2541170-1-paul.elder@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 2/2] test: v4l2_compat_test: Fix\n\tv4l2-compliance version parsing", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "v4l2-compliance changed their version string:\n\nv4l2-compliance 1.21.0-4618\nv4l2-compliance SHA: cc211b76476aca2c072ffa83a9b003957d5f3909, 64 bits, 64-bit time_t\n\nv4l2-compliance 1.21.0-4838, 64 bits, 64-bit time_t\n\nThe current parsing takes the last result of split, which works for the\nformer, but not the latter. Take the second result of split instead, and\nstrip away any commas.\n\nSigned-off-by: Paul Elder <paul.elder@ideasonboard.com>\n\n---\nKieran, can you please check if this works?\n---\n test/v4l2_compat/v4l2_compat_test.py | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/test/v4l2_compat/v4l2_compat_test.py b/test/v4l2_compat/v4l2_compat_test.py\nindex 51bfa952..ae892ced 100755\n--- a/test/v4l2_compat/v4l2_compat_test.py\n+++ b/test/v4l2_compat/v4l2_compat_test.py\n@@ -94,7 +94,7 @@ def main(argv):\n return TestSkip\n \n ret, out = run_with_stdout(v4l2_compliance, '--version')\n- if ret != 0 or version.parse(out[0].split()[-1]) < MIN_V4L_UTILS_VERSION:\n+ if ret != 0 or version.parse(out[0].split()[1].replace(',', '')) < MIN_V4L_UTILS_VERSION:\n print('v4l2-compliance version >= 1.21.0 required')\n return TestSkip\n \n", "prefixes": [ "libcamera-devel", "2/2" ] }