Patch Detail
Show a patch.
GET /api/patches/13462/?format=api
{ "id": 13462, "url": "https://patchwork.libcamera.org/api/patches/13462/?format=api", "web_url": "https://patchwork.libcamera.org/patch/13462/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210824142450.3157833-5-kieran.bingham@ideasonboard.com>", "date": "2021-08-24T14:24:50", "name": "[libcamera-devel,SimpleCam,4/4] simple-cam: Correct the capitalisation of 'libcamera'", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "8671ffcd1fa5b7eeef9f762f024f33153ddfd5bd", "submitter": { "id": 4, "url": "https://patchwork.libcamera.org/api/people/4/?format=api", "name": "Kieran Bingham", "email": "kieran.bingham@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/13462/mbox/", "series": [ { "id": 2388, "url": "https://patchwork.libcamera.org/api/series/2388/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2388", "date": "2021-08-24T14:24:46", "name": "Improve CameraManager usage and Doc", "version": 1, "mbox": "https://patchwork.libcamera.org/series/2388/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/13462/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/13462/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 246D6BD87D\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 24 Aug 2021 14:25:00 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8371868918;\n\tTue, 24 Aug 2021 16:24:59 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4D914688A3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 24 Aug 2021 16:24:56 +0200 (CEST)", "from Monstersaurus.local\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C3710BB0;\n\tTue, 24 Aug 2021 16:24:55 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"NZQ1HKpV\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1629815095;\n\tbh=uLtkGzOI08JxEDGOv0PwhjLADxuBplDdrHWLOBDq2MI=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=NZQ1HKpVgBCLWsrrl+XEBJ7h82jY5X90bFq1hkWGZlwrWlloY+VF84g5MyQsCaT26\n\tQaBuVcDi/HJm6XdR2peXibZVRACY/hPl9ECYCmkeAoRt0XleDRMBGUDRMzeqYAd5dE\n\tJmttfY3UPRfXFRD6C2m1yySGVVsqGp79X8djEjb0=", "From": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "To": "libcamera devel <libcamera-devel@lists.libcamera.org>", "Date": "Tue, 24 Aug 2021 15:24:50 +0100", "Message-Id": "<20210824142450.3157833-5-kieran.bingham@ideasonboard.com>", "X-Mailer": "git-send-email 2.30.2", "In-Reply-To": "<20210824142450.3157833-1-kieran.bingham@ideasonboard.com>", "References": "<20210824142450.3157833-1-kieran.bingham@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [SimpleCam PATCH 4/4] simple-cam: Correct the\n\tcapitalisation of 'libcamera'", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Even when used at the beginning of a sentence, the 'libcamera' name\nalways starts with a lower case 'l'. Fix the incorrect usages of the\nname.\n\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n simple-cam.cpp | 7 ++++---\n 1 file changed, 4 insertions(+), 3 deletions(-)", "diff": "diff --git a/simple-cam.cpp b/simple-cam.cpp\nindex 47c5dc9987bc..7ba423df9089 100644\n--- a/simple-cam.cpp\n+++ b/simple-cam.cpp\n@@ -301,7 +301,7 @@ int main()\n \t * --------------------------------------------------------------------\n \t * Frame Capture\n \t *\n-\t * Libcamera frames capture model is based on the 'Request' concept.\n+\t * libcamera frames capture model is based on the 'Request' concept.\n \t * For each frame a Request has to be queued to the Camera.\n \t *\n \t * A Request refers to (at least one) Stream for which a Buffer that\n@@ -348,7 +348,7 @@ int main()\n \t * --------------------------------------------------------------------\n \t * Signal&Slots\n \t *\n-\t * Libcamera uses a Signal&Slot based system to connect events to\n+\t * libcamera uses a Signal&Slot based system to connect events to\n \t * callback operations meant to handle them, inspired by the QT graphic\n \t * toolkit.\n \t *\n@@ -398,12 +398,13 @@ int main()\n \tint ret = loop.exec();\n \tstd::cout << \"Capture ran for \" << TIMEOUT_SEC << \" seconds and \"\n \t\t << \"stopped with exit status: \" << ret << std::endl;\n+\n \t/*\n \t * --------------------------------------------------------------------\n \t * Clean Up\n \t *\n \t * Stop the Camera, release resources and stop the CameraManager.\n-\t * Libcamera has now released all resources it owned.\n+\t * libcamera has now released all resources it owned.\n \t */\n \tcamera->stop();\n \tallocator->free(stream);\n", "prefixes": [ "libcamera-devel", "SimpleCam", "4/4" ] }