Patch Detail
Show a patch.
GET /api/patches/13437/?format=api
{ "id": 13437, "url": "https://patchwork.libcamera.org/api/patches/13437/?format=api", "web_url": "https://patchwork.libcamera.org/patch/13437/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210823124937.253539-3-jeanmichel.hautbois@ideasonboard.com>", "date": "2021-08-23T12:49:32", "name": "[libcamera-devel,v1,2/7] ipa: ipu3: awb: Correct the relevant zones proportion", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "f2e9daef506471c197168c56cac0e061610f0840", "submitter": { "id": 75, "url": "https://patchwork.libcamera.org/api/people/75/?format=api", "name": "Jean-Michel Hautbois", "email": "jeanmichel.hautbois@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/13437/mbox/", "series": [ { "id": 2385, "url": "https://patchwork.libcamera.org/api/series/2385/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2385", "date": "2021-08-23T12:49:30", "name": "IPU3: AWB and AGC improvements", "version": 1, "mbox": "https://patchwork.libcamera.org/series/2385/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/13437/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/13437/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 43D64BD87D\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 23 Aug 2021 12:49:47 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3FB646891B;\n\tMon, 23 Aug 2021 14:49:45 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 19E27688A2\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 23 Aug 2021 14:49:43 +0200 (CEST)", "from tatooine.ideasonboard.com (unknown\n\t[IPv6:2a01:e0a:169:7140:b920:776:a08c:1d1f])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B3015DEF;\n\tMon, 23 Aug 2021 14:49:42 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"SFcXRnCn\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1629722982;\n\tbh=VWhok++3B0jlwziB2rCBoWl/dG/OOAP3G17I8TEEInM=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=SFcXRnCnwE9T8inqwD6zuEoSYnY21zkJA2zKER4k3TR7gVTmkF896sbkPo1z8VD1N\n\tl0GHzPqqGy/lWzp7pfVaeJZm7YYMyuECLB9mkxgGLij809xsXRbdlcB5k4BAYPJqu7\n\tbblyXaJl/KUZ10p0Kh2WhoCGak5QfCwUAJ6gZyR4=", "From": "Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Mon, 23 Aug 2021 14:49:32 +0200", "Message-Id": "<20210823124937.253539-3-jeanmichel.hautbois@ideasonboard.com>", "X-Mailer": "git-send-email 2.30.2", "In-Reply-To": "<20210823124937.253539-1-jeanmichel.hautbois@ideasonboard.com>", "References": "<20210823124937.253539-1-jeanmichel.hautbois@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v1 2/7] ipa: ipu3: awb: Correct the\n\trelevant zones proportion", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The algorithm uses the statistics of a cell only if there is not too\nmuch saturated pixels in it. The grey world algorithm works fine when\nthere are a limited number of outliers.\nConsider a valid zone to be at least 80% of unsaturated cells in it.\nThis value could very well be configurable, and make the algorithm more\nor less tolerant.\n\nSigned-off-by: Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>\n---\n src/ipa/ipu3/algorithms/awb.cpp | 15 ++++++++++++---\n src/ipa/ipu3/algorithms/awb.h | 1 +\n 2 files changed, 13 insertions(+), 3 deletions(-)", "diff": "diff --git a/src/ipa/ipu3/algorithms/awb.cpp b/src/ipa/ipu3/algorithms/awb.cpp\nindex e05647c9..9497a21b 100644\n--- a/src/ipa/ipu3/algorithms/awb.cpp\n+++ b/src/ipa/ipu3/algorithms/awb.cpp\n@@ -17,8 +17,6 @@ namespace ipa::ipu3::algorithms {\n \n LOG_DEFINE_CATEGORY(IPU3Awb)\n \n-static constexpr uint32_t kMinZonesCounted = 16;\n-static constexpr uint32_t kMinGreenLevelInZone = 32;\n \n /**\n * \\struct IspStatsRegion\n@@ -114,6 +112,9 @@ static const struct ipu3_uapi_ccm_mat_config imguCssCcmDefault = {\n \t0, 0, 8191, 0\n };\n \n+/* Minimum level of green in a given zone */\n+static constexpr uint32_t kMinGreenLevelInZone = 16;\n+\n Awb::Awb()\n \t: Algorithm()\n {\n@@ -123,6 +124,7 @@ Awb::Awb()\n \tasyncResults_.temperatureK = 4500;\n \n \tzones_.reserve(kAwbStatsSizeX * kAwbStatsSizeY);\n+\tminZonesCounted_ = 0;\n }\n \n Awb::~Awb() = default;\n@@ -163,7 +165,7 @@ void Awb::generateZones(std::vector<RGB> &zones)\n \tfor (unsigned int i = 0; i < kAwbStatsSizeX * kAwbStatsSizeY; i++) {\n \t\tRGB zone;\n \t\tdouble counted = awbStats_[i].counted;\n-\t\tif (counted >= kMinZonesCounted) {\n+\t\tif (counted >= minZonesCounted_) {\n \t\t\tzone.G = awbStats_[i].gSum / counted;\n \t\t\tif (zone.G >= kMinGreenLevelInZone) {\n \t\t\t\tzone.R = awbStats_[i].rSum / counted;\n@@ -181,6 +183,13 @@ void Awb::generateAwbStats(const ipu3_uapi_stats_3a *stats,\n \tuint32_t regionWidth = round(grid.width / static_cast<double>(kAwbStatsSizeX));\n \tuint32_t regionHeight = round(grid.height / static_cast<double>(kAwbStatsSizeY));\n \n+\t/*\n+\t * It is the minimum proportion of pixels counted within AWB region\n+\t * for it to be relevant.\n+\t * \\todo This proportion could be configured.\n+\t */\n+\tminZonesCounted_ = (regionWidth * regionHeight) * 80 / 100;\n+\n \t/*\n \t * Generate a (kAwbStatsSizeX x kAwbStatsSizeY) array from the IPU3 grid which is\n \t * (grid.width x grid.height).\ndiff --git a/src/ipa/ipu3/algorithms/awb.h b/src/ipa/ipu3/algorithms/awb.h\nindex 332652d0..95238b6a 100644\n--- a/src/ipa/ipu3/algorithms/awb.h\n+++ b/src/ipa/ipu3/algorithms/awb.h\n@@ -84,6 +84,7 @@ private:\n \tstd::vector<RGB> zones_;\n \tIspStatsRegion awbStats_[kAwbStatsSizeX * kAwbStatsSizeY];\n \tAwbStatus asyncResults_;\n+\tuint32_t minZonesCounted_;\n };\n \n } /* namespace ipa::ipu3::algorithms */\n", "prefixes": [ "libcamera-devel", "v1", "2/7" ] }