Patch Detail
Show a patch.
GET /api/patches/13386/?format=api
{ "id": 13386, "url": "https://patchwork.libcamera.org/api/patches/13386/?format=api", "web_url": "https://patchwork.libcamera.org/patch/13386/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210818090247.33838-2-umang.jain@ideasonboard.com>", "date": "2021-08-18T09:02:46", "name": "[libcamera-devel,v2,1/2] libtest: camera_test: Plumb constructor to set LIBCAMERA_IPA_FORCE_ISOLATION", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "301f9a340836e0e91e5adc665c394753d76d42f6", "submitter": { "id": 86, "url": "https://patchwork.libcamera.org/api/people/86/?format=api", "name": "Umang Jain", "email": "umang.jain@ideasonboard.com" }, "delegate": { "id": 12, "url": "https://patchwork.libcamera.org/api/users/12/?format=api", "username": "uajain", "first_name": "Umang", "last_name": "Jain", "email": "umang.jain@ideasonboard.com" }, "mbox": "https://patchwork.libcamera.org/patch/13386/mbox/", "series": [ { "id": 2369, "url": "https://patchwork.libcamera.org/api/series/2369/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2369", "date": "2021-08-18T09:02:45", "name": "Fd leak test", "version": 2, "mbox": "https://patchwork.libcamera.org/series/2369/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/13386/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/13386/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3BA7CBD87C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 18 Aug 2021 09:03:05 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 043F568895;\n\tWed, 18 Aug 2021 11:03:05 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 35A476025E\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 18 Aug 2021 11:03:04 +0200 (CEST)", "from perceval.ideasonboard.com (unknown [103.238.109.15])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 92B79466;\n\tWed, 18 Aug 2021 11:03:02 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"rahCF9za\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1629277384;\n\tbh=oWqdDxtU4DI2eibi/7jjv5OTD/WVHyEs3wLemlBI17g=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=rahCF9za5Nqh034WquDdTo/LkwEG/Dro0E8VyFenoMKKCp1dfBbLyh3mVsxIiCzpm\n\tLWaGjeRic189Q9CXPpRZa1nsgzFT21cgQ3LWfUpoFGSfb5IInTvIb/liDjcr+CLtMK\n\tHrSjWaTBNSp36avNAbvWvPP9vCHR7DuJiBJAnxe4=", "From": "Umang Jain <umang.jain@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Wed, 18 Aug 2021 14:32:46 +0530", "Message-Id": "<20210818090247.33838-2-umang.jain@ideasonboard.com>", "X-Mailer": "git-send-email 2.31.1", "In-Reply-To": "<20210818090247.33838-1-umang.jain@ideasonboard.com>", "References": "<20210818090247.33838-1-umang.jain@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v2 1/2] libtest: camera_test: Plumb\n\tconstructor to set LIBCAMERA_IPA_FORCE_ISOLATION", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Some tests might require to have LIBCAMERA_IPA_FORCE_ISOLATION set\nto ensure they can test the IPA running in isolated mode. These tests\nare likely to leverage CameraTest. The environment variable should\nbe set before CameraManager::start() call which happens in CameraTest's\nconstructor. Hence, plumb the constructor with a flag so that the\nLIBCAMERA_IPA_FORCE_ISOLATION can be set before CameraManager::start().\n\nSigned-off-by: Umang Jain <umang.jain@ideasonboard.com>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nReviewed-by: Paul Elder <paul.elder@ideasonboard.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n test/libtest/camera_test.cpp | 5 ++++-\n test/libtest/camera_test.h | 2 +-\n 2 files changed, 5 insertions(+), 2 deletions(-)", "diff": "diff --git a/test/libtest/camera_test.cpp b/test/libtest/camera_test.cpp\nindex 2ae4d677..fe13d6ac 100644\n--- a/test/libtest/camera_test.cpp\n+++ b/test/libtest/camera_test.cpp\n@@ -13,10 +13,13 @@\n using namespace libcamera;\n using namespace std;\n \n-CameraTest::CameraTest(const char *name)\n+CameraTest::CameraTest(const char *name, bool isolate)\n {\n \tcm_ = new CameraManager();\n \n+\tif (isolate)\n+\t\tsetenv(\"LIBCAMERA_IPA_FORCE_ISOLATION\", \"1\", 1);\n+\n \tif (cm_->start()) {\n \t\tcerr << \"Failed to start camera manager\" << endl;\n \t\tstatus_ = TestFail;\ndiff --git a/test/libtest/camera_test.h b/test/libtest/camera_test.h\nindex 7939798f..f56e343e 100644\n--- a/test/libtest/camera_test.h\n+++ b/test/libtest/camera_test.h\n@@ -17,7 +17,7 @@ using namespace libcamera;\n class CameraTest\n {\n public:\n-\tCameraTest(const char *name);\n+\tCameraTest(const char *name, bool isolate = false);\n \t~CameraTest();\n \n protected:\n", "prefixes": [ "libcamera-devel", "v2", "1/2" ] }