Patch Detail
Show a patch.
GET /api/patches/13348/?format=api
{ "id": 13348, "url": "https://patchwork.libcamera.org/api/patches/13348/?format=api", "web_url": "https://patchwork.libcamera.org/patch/13348/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210813144437.138005-2-umang.jain@ideasonboard.com>", "date": "2021-08-13T14:44:34", "name": "[libcamera-devel,v2,1/4] ipa: vimc: Add configure() function", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "50452f7c8009d6d0890f9122ad1fe47c639db42f", "submitter": { "id": 86, "url": "https://patchwork.libcamera.org/api/people/86/?format=api", "name": "Umang Jain", "email": "umang.jain@ideasonboard.com" }, "delegate": { "id": 12, "url": "https://patchwork.libcamera.org/api/users/12/?format=api", "username": "uajain", "first_name": "Umang", "last_name": "Jain", "email": "umang.jain@ideasonboard.com" }, "mbox": "https://patchwork.libcamera.org/patch/13348/mbox/", "series": [ { "id": 2356, "url": "https://patchwork.libcamera.org/api/series/2356/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2356", "date": "2021-08-13T14:44:33", "name": "Pass buffers to VIMC IPA", "version": 2, "mbox": "https://patchwork.libcamera.org/series/2356/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/13348/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/13348/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3935EC3240\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 13 Aug 2021 14:44:53 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E9FE46888D;\n\tFri, 13 Aug 2021 16:44:52 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3A2826888E\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 13 Aug 2021 16:44:51 +0200 (CEST)", "from perceval.ideasonboard.com (unknown [103.251.226.198])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 0EEAA8F;\n\tFri, 13 Aug 2021 16:44:49 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"k3I70VA0\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1628865891;\n\tbh=HLQ7GbNZwUuE9gOFwPCWTUWmAoK0N0HMMjiD9s1i3Po=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=k3I70VA0PtX2eRHUVshvpJNS9cjnNYze4LDzSMuZzwFLB81IdUqAjkZPdS0zi24um\n\tD2o5k1tLtlqVtLq9qElCXgxuJHPs5n91EXrjxN53ampYFVpOb8gUwp40C7viYyJ1mN\n\tkzlsag295XzlSERwZIWmQZHXUdawE8oosaSptCzI=", "From": "Umang Jain <umang.jain@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 13 Aug 2021 20:14:34 +0530", "Message-Id": "<20210813144437.138005-2-umang.jain@ideasonboard.com>", "X-Mailer": "git-send-email 2.31.1", "In-Reply-To": "<20210813144437.138005-1-umang.jain@ideasonboard.com>", "References": "<20210813144437.138005-1-umang.jain@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v2 1/4] ipa: vimc: Add configure() function", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\nAs part of an effort to make the vimc IPA usable for testing, extend it\nwith a configure function. The configuration is currently ignored by the\nIPA.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nReviewed-by: Paul Elder <paul.elder@ideasonboard.com>\nReviewed-by: Umang Jain <umang.jain@ideasonboard.com>\nSigned-off-by: Umang Jain <umang.jain@ideasonboard.com>\n---\n include/libcamera/ipa/vimc.mojom | 5 +++++\n src/ipa/vimc/vimc.cpp | 13 +++++++++++++\n src/libcamera/pipeline/vimc/vimc.cpp | 16 ++++++++++++++++\n 3 files changed, 34 insertions(+)", "diff": "diff --git a/include/libcamera/ipa/vimc.mojom b/include/libcamera/ipa/vimc.mojom\nindex 86bc318a..ee66353d 100644\n--- a/include/libcamera/ipa/vimc.mojom\n+++ b/include/libcamera/ipa/vimc.mojom\n@@ -19,6 +19,11 @@ enum IPAOperationCode {\n \n interface IPAVimcInterface {\n \tinit(libcamera.IPASettings settings) => (int32 ret);\n+\n+\tconfigure(libcamera.IPACameraSensorInfo sensorInfo,\n+\t\t map<uint32, libcamera.IPAStream> streamConfig,\n+\t\t map<uint32, libcamera.ControlInfoMap> entityControls) => (int32 ret);\n+\n \tstart() => (int32 ret);\n \tstop();\n };\ndiff --git a/src/ipa/vimc/vimc.cpp b/src/ipa/vimc/vimc.cpp\nindex 0c0ee006..0535c740 100644\n--- a/src/ipa/vimc/vimc.cpp\n+++ b/src/ipa/vimc/vimc.cpp\n@@ -34,6 +34,10 @@ public:\n \tint start() override;\n \tvoid stop() override;\n \n+\tint configure(const IPACameraSensorInfo &sensorInfo,\n+\t\t const std::map<unsigned int, IPAStream> &streamConfig,\n+\t\t const std::map<unsigned int, ControlInfoMap> &entityControls) override;\n+\n private:\n \tvoid initTrace();\n \tvoid trace(enum ipa::vimc::IPAOperationCode operation);\n@@ -86,6 +90,15 @@ void IPAVimc::stop()\n \tLOG(IPAVimc, Debug) << \"stop vimc IPA!\";\n }\n \n+int IPAVimc::configure([[maybe_unused]] const IPACameraSensorInfo &sensorInfo,\n+\t\t [[maybe_unused]] const std::map<unsigned int, IPAStream> &streamConfig,\n+\t\t [[maybe_unused]] const std::map<unsigned int, ControlInfoMap> &entityControls)\n+{\n+\tLOG(IPAVimc, Debug) << \"configure()\";\n+\n+\treturn 0;\n+}\n+\n void IPAVimc::initTrace()\n {\n \tstruct stat fifoStat;\ndiff --git a/src/libcamera/pipeline/vimc/vimc.cpp b/src/libcamera/pipeline/vimc/vimc.cpp\nindex d4b041d3..4c92729d 100644\n--- a/src/libcamera/pipeline/vimc/vimc.cpp\n+++ b/src/libcamera/pipeline/vimc/vimc.cpp\n@@ -295,6 +295,22 @@ int PipelineHandlerVimc::configure(Camera *camera, CameraConfiguration *config)\n \n \tcfg.setStream(&data->stream_);\n \n+\tif (data->ipa_) {\n+\t\t/* Inform IPA of stream configuration and sensor controls. */\n+\t\tstd::map<unsigned int, IPAStream> streamConfig;\n+\t\tstreamConfig.emplace(std::piecewise_construct,\n+\t\t\t\t std::forward_as_tuple(0),\n+\t\t\t\t std::forward_as_tuple(cfg.pixelFormat, cfg.size));\n+\n+\t\tstd::map<unsigned int, ControlInfoMap> entityControls;\n+\t\tentityControls.emplace(0, data->sensor_->controls());\n+\n+\t\tIPACameraSensorInfo sensorInfo;\n+\t\tdata->sensor_->sensorInfo(&sensorInfo);\n+\n+\t\tdata->ipa_->configure(sensorInfo, streamConfig, entityControls);\n+\t}\n+\n \treturn 0;\n }\n \n", "prefixes": [ "libcamera-devel", "v2", "1/4" ] }