Patch Detail
Show a patch.
GET /api/patches/13344/?format=api
{ "id": 13344, "url": "https://patchwork.libcamera.org/api/patches/13344/?format=api", "web_url": "https://patchwork.libcamera.org/patch/13344/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210813104302.200994-1-vedantparanjape160201@gmail.com>", "date": "2021-08-13T10:43:02", "name": "[libcamera-devel,v10] test: gstreamer: Add test for gstreamer single stream", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "8a3daac459894e650d8e1df86dd4f73e84176533", "submitter": { "id": 85, "url": "https://patchwork.libcamera.org/api/people/85/?format=api", "name": "Vedant Paranjape", "email": "vedantparanjape160201@gmail.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/13344/mbox/", "series": [ { "id": 2353, "url": "https://patchwork.libcamera.org/api/series/2353/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2353", "date": "2021-08-13T10:43:02", "name": "[libcamera-devel,v10] test: gstreamer: Add test for gstreamer single stream", "version": 10, "mbox": "https://patchwork.libcamera.org/series/2353/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/13344/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/13344/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D57D1BD87D\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 13 Aug 2021 10:43:15 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 498CE6888F;\n\tFri, 13 Aug 2021 12:43:15 +0200 (CEST)", "from mail-pl1-x62f.google.com (mail-pl1-x62f.google.com\n\t[IPv6:2607:f8b0:4864:20::62f])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5620F687FA\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 13 Aug 2021 12:43:14 +0200 (CEST)", "by mail-pl1-x62f.google.com with SMTP id a5so11353785plh.5\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 13 Aug 2021 03:43:14 -0700 (PDT)", "from localhost.localdomain ([1.186.167.175])\n\tby smtp.googlemail.com with ESMTPSA id\n\tc15sm1583968pjr.22.2021.08.13.03.43.10\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 13 Aug 2021 03:43:12 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"UEXIpwDQ\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=ua0i4iJrVLQN9J9NTAme2NZKgll2gU466yv0+O6Y9IY=;\n\tb=UEXIpwDQ6pUMJJuJjghydakihtHVoCAlYCdpZLyeI+LJP9Eus5ZyRvF9tGasBTYc04\n\taR8D8DQcCYpHUps5SUTRFwKXamvAWA8/bBxc4vcy5FL+hdaaWoF/t71EU8YAHPmmg2Wt\n\thU+1/t2wZp7suTYOsN7/fgoWT06O/LBzVjNyadUIUE5pbWrlmJaC0un0F57o5xJl/aPO\n\tJQgODY5E2AollKjgcI9HLRr0JtgJKW5MfkezDI8rgqa/W9CXvC+Io4h83PoNrFv9hA7n\n\tJLyLFxZV9tAfzZBnTyuyU5z0HQm2dNfHY/SthrTsS3AxCM4aajG+QNyXrSsa608SXv82\n\tKvPw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=ua0i4iJrVLQN9J9NTAme2NZKgll2gU466yv0+O6Y9IY=;\n\tb=twWwBYlNH4fhOBiyzSiqVj0yUdpl8Qjtt3ogkv+nqBsNzAYVsdxyEHfFCbfEypt06T\n\tee/GLhL+jPIiwGbwxTocw98QK5oXdfSnldUT6eTvyUds7wkkfZH6k4BbFbBSHk3E3pCU\n\tZM+M53sbxnXW2k58LBLbISRARvF+twL7fIREavabE29qtwIvP11BKtvEQDXIkmU2bPvh\n\t+Eb3JuclaLgxf+Qv5B8mKTfAZCEIilgyYD8QnIFYPqsC1963bqZTo1rPXMvIunAxbHU1\n\tEQxKFtrzxu7VmkBGCp1lD36EBeUAAdVMdIguvp41+98oq+SSJTRvXoxeR3Kg8sRWIEOw\n\tfoRg==", "X-Gm-Message-State": "AOAM532AHHKHfcWMPi/qUhm+CQgVc3Q4P8YhOyB+xLP1UijYiEgskI+P\n\tdON6ZZLtPM3yMGZ1t7rgNSpNl2hA/lf0HU+R", "X-Google-Smtp-Source": "ABdhPJzScZLu0CYAL8mKaOYcuHHHYnPLci3nRqnJTu7c+fbG0uyB4aiQxKdqTjevjGtj852Tlua8aw==", "X-Received": "by 2002:a17:902:aa82:b029:12c:6463:4880 with SMTP id\n\td2-20020a170902aa82b029012c64634880mr1628283plr.65.1628851392504; \n\tFri, 13 Aug 2021 03:43:12 -0700 (PDT)", "From": "Vedant Paranjape <vedantparanjape160201@gmail.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 13 Aug 2021 16:13:02 +0530", "Message-Id": "<20210813104302.200994-1-vedantparanjape160201@gmail.com>", "X-Mailer": "git-send-email 2.25.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v10] test: gstreamer: Add test for\n\tgstreamer single stream", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Cc": "Vedant Paranjape <vedantparanjape160201@gmail.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "This patch adds a test to test if single stream using\nlibcamera's gstreamer element works.\n\nSigned-off-by: Vedant Paranjape <vedantparanjape160201@gmail.com>\nReviewed-by: Paul Elder <paul.elder@ideasonboard.com>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n .../gstreamer_single_stream_test.cpp | 153 ++++++++++++++++++\n test/gstreamer/meson.build | 19 +++\n test/meson.build | 1 +\n 3 files changed, 173 insertions(+)\n create mode 100644 test/gstreamer/gstreamer_single_stream_test.cpp\n create mode 100644 test/gstreamer/meson.build", "diff": "diff --git a/test/gstreamer/gstreamer_single_stream_test.cpp b/test/gstreamer/gstreamer_single_stream_test.cpp\nnew file mode 100644\nindex 00000000..eecd3274\n--- /dev/null\n+++ b/test/gstreamer/gstreamer_single_stream_test.cpp\n@@ -0,0 +1,153 @@\n+/* SPDX-License-Identifier: GPL-2.0-or-later */\n+/*\n+ * Copyright (C) 2021, Vedant Paranjape\n+ *\n+ * ipa_interface_test.cpp - Test the IPA interface\n+ */\n+\n+#include <iostream>\n+\n+#include <libcamera/base/utils.h>\n+\n+#include <gst/gst.h>\n+\n+#include \"test.h\"\n+\n+using namespace std;\n+\n+class GstreamerSingleStreamTest : public Test\n+{\n+protected:\n+\tint init() override\n+\t{\n+\t\t/* Initialize GStreamer */\n+\t\tGError *errInit = nullptr;\n+\t\tif (!gst_init_check(nullptr, nullptr, &errInit)) {\n+\t\t\tg_printerr(\"Could not initialize GStreamer: %s\\n\",\n+\t\t\t\t errInit ? errInit->message : \"unknown error\");\n+\t\t\tif (errInit)\n+\t\t\t\tg_error_free(errInit);\n+\n+\t\t\treturn TestFail;\n+\t\t}\n+\n+\t\t/*\n+\t\t* Remove the system libcamera plugin, if any, and add the\n+\t\t* plugin from the build directory.\n+\t\t*/\n+\t\tGstRegistry *registry = gst_registry_get();\n+\t\tGstPlugin *plugin = gst_registry_lookup(registry, \"libgstlibcamera.so\");\n+\t\tif (plugin) {\n+\t\t\tgst_registry_remove_plugin(registry, plugin);\n+\t\t\tgst_object_unref(plugin);\n+\t\t}\n+\t\t\n+\t\tstd::string path = std::string(libcamera::utils::libcameraBuildPath()\n+\t\t\t\t\t+ \"src/gstreamer\");\n+\t\tif (!gst_registry_scan_path(registry, path.c_str())) {\n+\t\t\tg_printerr(\"Failed to add plugin to registry\\n\");\n+\t\t\tgst_deinit();\n+\t\t\treturn TestFail;\n+\t\t}\n+\n+\t\t/* Create the elements */\n+\t\tlibcameraSrc_ = gst_element_factory_make(\"libcamerasrc\", \"libcamera\");\n+\t\tconvert0_ = gst_element_factory_make(\"videoconvert\", \"convert0\");\n+\t\tsink0_ = gst_element_factory_make(\"fakesink\", \"sink0\");\n+\n+\t\t/* Create the empty pipeline_ */\n+\t\tpipeline_ = gst_pipeline_new(\"test-pipeline\");\n+\n+\t\tif (!pipeline_ || !convert0_ || !sink0_ || !libcameraSrc_) {\n+\t\t\tg_printerr(\"Not all elements could be created. %p.%p.%p.%p\\n\",\n+\t\t\t\t pipeline_, convert0_, sink0_, libcameraSrc_);\n+\t\t\tif (pipeline_)\n+\t\t\t\tgst_object_unref(pipeline_);\n+\t\t\tif (convert0_)\n+\t\t\t\tgst_object_unref(convert0_);\n+\t\t\tif (sink0_)\n+\t\t\t\tgst_object_unref(sink0_);\n+\t\t\tif (libcameraSrc_)\n+\t\t\t\tgst_object_unref(libcameraSrc_);\n+\t\t\tgst_deinit();\n+\n+\t\t\treturn TestFail;\n+\t\t}\n+\n+\t\treturn TestPass;\n+\t}\n+\n+\tvoid cleanup() override\n+\t{\n+\t\tgst_object_unref(pipeline_);\n+\t\tgst_deinit();\n+\t}\n+\n+\tint run() override\n+\t{\n+\t\tGstStateChangeReturn ret;\n+\t\tg_autoptr(GstBus) bus;\n+\t\tg_autoptr(GstMessage) msg;\n+\n+\t\t/* Build the pipeline */\n+\t\tgst_bin_add_many(GST_BIN(pipeline_), libcameraSrc_, convert0_, sink0_, NULL);\n+\t\tif (gst_element_link_many(libcameraSrc_, convert0_, sink0_, NULL) != TRUE) {\n+\t\t\tg_printerr(\"Elements could not be linked.\\n\");\n+\t\t\treturn TestFail;\n+\t\t}\n+\n+\t\t/* Start playing */\n+\t\tret = gst_element_set_state(pipeline_, GST_STATE_PLAYING);\n+\t\tif (ret == GST_STATE_CHANGE_FAILURE) {\n+\t\t\tg_printerr(\"Unable to set the pipeline to the playing state.\\n\");\n+\t\t\treturn TestFail;\n+\t\t}\n+\n+\t\t/* Wait until error or EOS or timeout after 2 seconds */\n+\t\tGstClockTime timeout = 2000000000;\n+\t\tbus = gst_element_get_bus(pipeline_);\n+\t\tmsg = gst_bus_timed_pop_filtered(bus, timeout,\n+\t\t\t\t\t\t GstMessageType((uint)GST_MESSAGE_ERROR | (uint)GST_MESSAGE_EOS));\n+\t\tgst_element_set_state(pipeline_, GST_STATE_NULL);\n+\n+\t\t/* Parse error message */\n+\t\tif (msg == NULL)\n+\t\t\treturn TestPass;\n+\n+\t\tswitch (GST_MESSAGE_TYPE(msg)) {\n+\t\tcase GST_MESSAGE_ERROR:\n+\t\t\tgstreamer_print_error(msg);\n+\t\t\tbreak;\n+\t\tcase GST_MESSAGE_EOS:\n+\t\t\tg_print(\"End-Of-Stream reached.\\n\");\n+\t\t\tbreak;\n+\t\tdefault:\n+\t\t\tg_printerr(\"Unexpected message received.\\n\");\n+\t\t\tbreak;\n+\t\t}\n+\n+\t\treturn TestFail;\n+\t}\n+\n+private:\n+\tvoid gstreamer_print_error(GstMessage *msg)\n+\t{\n+\t\tGError *err;\n+\t\tgchar *debug_info;\n+\n+\t\tgst_message_parse_error(msg, &err, &debug_info);\n+\t\tg_printerr(\"Error received from element %s: %s\\n\",\n+\t\t\t GST_OBJECT_NAME(msg->src), err->message);\n+\t\tg_printerr(\"Debugging information: %s\\n\",\n+\t\t\t debug_info ? debug_info : \"none\");\n+\t\tg_clear_error(&err);\n+\t\tg_free(debug_info);\n+\t}\n+\n+\tGstElement *pipeline_;\n+\tGstElement *libcameraSrc_;\n+\tGstElement *convert0_;\n+\tGstElement *sink0_;\n+};\n+\n+TEST_REGISTER(GstreamerSingleStreamTest)\ndiff --git a/test/gstreamer/meson.build b/test/gstreamer/meson.build\nnew file mode 100644\nindex 00000000..b99aa0da\n--- /dev/null\n+++ b/test/gstreamer/meson.build\n@@ -0,0 +1,19 @@\n+# SPDX-License-Identifier: CC0-1.0\n+\n+if not gst_enabled\n+ subdir_done()\n+endif\n+\n+gstreamer_tests = [\n+ ['single_stream_test', 'gstreamer_single_stream_test.cpp'],\n+]\n+gstreamer_dep = dependency('gstreamer-1.0', required: true)\n+\n+foreach t : gstreamer_tests\n+ exe = executable(t[0], t[1],\n+ dependencies : [libcamera_private, gstreamer_dep],\n+ link_with : test_libraries,\n+ include_directories : test_includes_internal)\n+\n+ test(t[0], exe, suite : 'gstreamer', is_parallel : false)\n+endforeach\ndiff --git a/test/meson.build b/test/meson.build\nindex 3bceb5df..d0466f17 100644\n--- a/test/meson.build\n+++ b/test/meson.build\n@@ -11,6 +11,7 @@ subdir('libtest')\n \n subdir('camera')\n subdir('controls')\n+subdir('gstreamer')\n subdir('ipa')\n subdir('ipc')\n subdir('log')\n", "prefixes": [ "libcamera-devel", "v10" ] }