Patch Detail
Show a patch.
GET /api/patches/13269/?format=api
{ "id": 13269, "url": "https://patchwork.libcamera.org/api/patches/13269/?format=api", "web_url": "https://patchwork.libcamera.org/patch/13269/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210809165725.1916137-1-kieran.bingham@ideasonboard.com>", "date": "2021-08-09T16:57:25", "name": "[libcamera-devel] ipa: raspberrypi: Fix bcm2835-isp inclusion type.", "commit_ref": "5b7d16dc1f3d4aaf759a82082b162ab1d25d1f99", "pull_url": null, "state": "accepted", "archived": false, "hash": "d833a9db63ebe8e4cab3235054ff577be63f5203", "submitter": { "id": 4, "url": "https://patchwork.libcamera.org/api/people/4/?format=api", "name": "Kieran Bingham", "email": "kieran.bingham@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/13269/mbox/", "series": [ { "id": 2325, "url": "https://patchwork.libcamera.org/api/series/2325/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2325", "date": "2021-08-09T16:57:25", "name": "[libcamera-devel] ipa: raspberrypi: Fix bcm2835-isp inclusion type.", "version": 1, "mbox": "https://patchwork.libcamera.org/series/2325/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/13269/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/13269/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 196B8BD87D\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 9 Aug 2021 16:57:31 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 87300687EB;\n\tMon, 9 Aug 2021 18:57:30 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3562D60269\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 9 Aug 2021 18:57:29 +0200 (CEST)", "from Monstersaurus.local\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B5505466;\n\tMon, 9 Aug 2021 18:57:28 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"qlQRX/rU\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1628528248;\n\tbh=ImEu3YMsloofZeqrVT53N/Pkwi4IigxBMB1vkV7NV2k=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=qlQRX/rUUWpkL1gx7zVxj7kyJ3H3U+5UXB71gqJMcHuADtJHrBmyOni0FnaVwdgKh\n\tyV+hcD7nil3FQQAWtq62RcfJZXUrlBSyV01IYCKkhB+ckUtE9eCPR6OUeP4B9bHNeG\n\tfB5cJ523HbeloERtC2p3PhZCRFp3kRxGKRI6OVDI=", "From": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "To": "libcamera devel <libcamera-devel@lists.libcamera.org>", "Date": "Mon, 9 Aug 2021 17:57:25 +0100", "Message-Id": "<20210809165725.1916137-1-kieran.bingham@ideasonboard.com>", "X-Mailer": "git-send-email 2.30.2", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH] ipa: raspberrypi: Fix bcm2835-isp\n\tinclusion type.", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The bcm2835-isp.h is included with quotes rather than\nangle brackets.\n\nQuoted includes is reserved for internal includes, while the\nlinux/bcm2835-isp.h header is exported from the Linux kernel.\n\nFix the inclusion type.\n\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n src/ipa/raspberrypi/controller/rpi/agc.cpp | 2 +-\n src/ipa/raspberrypi/controller/rpi/lux.cpp | 2 +-\n 2 files changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/src/ipa/raspberrypi/controller/rpi/agc.cpp b/src/ipa/raspberrypi/controller/rpi/agc.cpp\nindex 1cfdd3bb0f62..289c1fcee289 100644\n--- a/src/ipa/raspberrypi/controller/rpi/agc.cpp\n+++ b/src/ipa/raspberrypi/controller/rpi/agc.cpp\n@@ -7,7 +7,7 @@\n \n #include <map>\n \n-#include \"linux/bcm2835-isp.h\"\n+#include <linux/bcm2835-isp.h>\n \n #include <libcamera/base/log.h>\n \ndiff --git a/src/ipa/raspberrypi/controller/rpi/lux.cpp b/src/ipa/raspberrypi/controller/rpi/lux.cpp\nindex 6367b17dc7f4..f77e9140ac10 100644\n--- a/src/ipa/raspberrypi/controller/rpi/lux.cpp\n+++ b/src/ipa/raspberrypi/controller/rpi/lux.cpp\n@@ -6,7 +6,7 @@\n */\n #include <math.h>\n \n-#include \"linux/bcm2835-isp.h\"\n+#include <linux/bcm2835-isp.h>\n \n #include <libcamera/base/log.h>\n \n", "prefixes": [ "libcamera-devel" ] }