Patch Detail
Show a patch.
GET /api/patches/13267/?format=api
{ "id": 13267, "url": "https://patchwork.libcamera.org/api/patches/13267/?format=api", "web_url": "https://patchwork.libcamera.org/patch/13267/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210809160445.179306-1-umang.jain@ideasonboard.com>", "date": "2021-08-09T16:04:45", "name": "[libcamera-devel] libcamera: frame_buffer: Print errno on mmap() failure", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "a1971ef49bb9d4c9050af880b37d7454d6a67563", "submitter": { "id": 86, "url": "https://patchwork.libcamera.org/api/people/86/?format=api", "name": "Umang Jain", "email": "umang.jain@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/13267/mbox/", "series": [ { "id": 2323, "url": "https://patchwork.libcamera.org/api/series/2323/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2323", "date": "2021-08-09T16:04:45", "name": "[libcamera-devel] libcamera: frame_buffer: Print errno on mmap() failure", "version": 1, "mbox": "https://patchwork.libcamera.org/series/2323/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/13267/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/13267/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 98BE2BD87D\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 9 Aug 2021 16:04:55 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0DF2468826;\n\tMon, 9 Aug 2021 18:04:55 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DA5C960269\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 9 Aug 2021 18:04:53 +0200 (CEST)", "from perceval.ideasonboard.com (unknown [103.251.226.61])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9258B466;\n\tMon, 9 Aug 2021 18:04:52 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"oEsbBTUR\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1628525093;\n\tbh=gNFexdiplVyzqFZooU5y1Kbykiw1K53q7B4YAFo0NlQ=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=oEsbBTURrHoL3QX2wNZ66WlAl7wXrkVGo9xxmZhA1eZJmfLrCBKcFYx1BQW3DCH1t\n\tutC36iJMdikaPyKx3wu92MtUewsiHSRuG8gZaJ+1SWgj1VHFnnoX5a6QTqGiinTPja\n\tn3NtNK7XE70Kkmo+EUREWILXYsnNQNhGZDlterIU=", "From": "Umang Jain <umang.jain@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Mon, 9 Aug 2021 21:34:45 +0530", "Message-Id": "<20210809160445.179306-1-umang.jain@ideasonboard.com>", "X-Mailer": "git-send-email 2.31.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH] libcamera: frame_buffer: Print errno on\n\tmmap() failure", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "In mmap() error handling path, errno is stored but never printed\nin the error log. Print it.\n\nSigned-off-by: Umang Jain <umang.jain@ideasonboard.com>\n---\n src/libcamera/framebuffer.cpp | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)", "diff": "diff --git a/src/libcamera/framebuffer.cpp b/src/libcamera/framebuffer.cpp\nindex 41e6e68f..280f64c6 100644\n--- a/src/libcamera/framebuffer.cpp\n+++ b/src/libcamera/framebuffer.cpp\n@@ -388,7 +388,8 @@ MappedFrameBuffer::MappedFrameBuffer(const FrameBuffer *buffer, int flags)\n \t\t\t\t MAP_SHARED, plane.fd.fd(), 0);\n \t\tif (address == MAP_FAILED) {\n \t\t\terror_ = -errno;\n-\t\t\tLOG(Buffer, Error) << \"Failed to mmap plane\";\n+\t\t\tLOG(Buffer, Error) << \"Failed to mmap plane: \"\n+\t\t\t\t\t << strerror(-error_);\n \t\t\tbreak;\n \t\t}\n \n", "prefixes": [ "libcamera-devel" ] }