Patch Detail
Show a patch.
GET /api/patches/13194/?format=api
{ "id": 13194, "url": "https://patchwork.libcamera.org/api/patches/13194/?format=api", "web_url": "https://patchwork.libcamera.org/patch/13194/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210804113529.418162-1-paul.elder@ideasonboard.com>", "date": "2021-08-04T11:35:29", "name": "[libcamera-devel,RFC] tests: ipa_data_serializer_test: Test serializing fds", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "1674c49c4878caad037bc6d16fa52375702bd640", "submitter": { "id": 17, "url": "https://patchwork.libcamera.org/api/people/17/?format=api", "name": "Paul Elder", "email": "paul.elder@ideasonboard.com" }, "delegate": { "id": 17, "url": "https://patchwork.libcamera.org/api/users/17/?format=api", "username": "epaul", "first_name": "Paul", "last_name": "Elder", "email": "paul.elder@ideasonboard.com" }, "mbox": "https://patchwork.libcamera.org/patch/13194/mbox/", "series": [ { "id": 2302, "url": "https://patchwork.libcamera.org/api/series/2302/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2302", "date": "2021-08-04T11:35:29", "name": "[libcamera-devel,RFC] tests: ipa_data_serializer_test: Test serializing fds", "version": 1, "mbox": "https://patchwork.libcamera.org/series/2302/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/13194/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/13194/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 848ECC3235\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 4 Aug 2021 11:35:42 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id EE7676881B;\n\tWed, 4 Aug 2021 13:35:41 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9DBD66026E\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 4 Aug 2021 13:35:40 +0200 (CEST)", "from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 083DA24F;\n\tWed, 4 Aug 2021 13:35:38 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ZdHqVRk6\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1628076940;\n\tbh=iG0f1hBGfnkDqbPb1ee7MfWAWErBD/J/9JbzJj42HvM=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=ZdHqVRk6uU6lV4l+H14L0GQh6bP8yvWzGbR32kBYwq1gDI5QmIeqT6RdScmx95x/E\n\tnq+NccG31C/TdfTfh7pibEyQ7is78sifTPMA4c7nnpxe1JE+ts4nN35ck/eU3wMYJp\n\tToxhSFX/2/aQ3ZHeC/MJlLtAB/0uo0631rOJTyFk=", "From": "Paul Elder <paul.elder@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Wed, 4 Aug 2021 20:35:29 +0900", "Message-Id": "<20210804113529.418162-1-paul.elder@ideasonboard.com>", "X-Mailer": "git-send-email 2.27.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [RFC PATCH] tests: ipa_data_serializer_test: Test\n\tserializing fds", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Add tests to test IPADataSerializer serializing FileDescriptors.\n\nSigned-off-by: Paul Elder <paul.elder@ideasonboard.com>\n---\n include/libcamera/file_descriptor.h | 1 +\n src/libcamera/file_descriptor.cpp | 9 ++++\n .../ipa_data_serializer_test.cpp | 43 +++++++++++++++++++\n 3 files changed, 53 insertions(+)", "diff": "diff --git a/include/libcamera/file_descriptor.h b/include/libcamera/file_descriptor.h\nindex d514aac7..8f1d6f21 100644\n--- a/include/libcamera/file_descriptor.h\n+++ b/include/libcamera/file_descriptor.h\n@@ -22,6 +22,7 @@ public:\n \n \tFileDescriptor &operator=(const FileDescriptor &other);\n \tFileDescriptor &operator=(FileDescriptor &&other);\n+\tbool operator==(const FileDescriptor &other) const;\n \n \tbool isValid() const { return fd_ != nullptr; }\n \tint fd() const { return fd_ ? fd_->fd() : -1; }\ndiff --git a/src/libcamera/file_descriptor.cpp b/src/libcamera/file_descriptor.cpp\nindex 638b3bbe..f1394153 100644\n--- a/src/libcamera/file_descriptor.cpp\n+++ b/src/libcamera/file_descriptor.cpp\n@@ -191,6 +191,15 @@ FileDescriptor &FileDescriptor::operator=(FileDescriptor &&other)\n \treturn *this;\n }\n \n+/**\n+ * \\brief Compare FileDescriptor instances for equality\n+ * \\return True if the underlying file descriptor is equal, false otherwise\n+ */\n+bool FileDescriptor::operator==(const FileDescriptor &other) const\n+{\n+\treturn this->fd() == other.fd();\n+}\n+\n /**\n * \\fn FileDescriptor::isValid()\n * \\brief Check if the FileDescriptor instance is valid\ndiff --git a/test/serialization/ipa_data_serializer_test.cpp b/test/serialization/ipa_data_serializer_test.cpp\nindex 1e8f7e21..9c8ff69c 100644\n--- a/test/serialization/ipa_data_serializer_test.cpp\n+++ b/test/serialization/ipa_data_serializer_test.cpp\n@@ -11,6 +11,7 @@\n #include <iostream>\n #include <limits>\n #include <stdlib.h>\n+#include <sys/mman.h>\n #include <sys/stat.h>\n #include <sys/types.h>\n #include <tuple>\n@@ -144,6 +145,10 @@ protected:\n \t\tif (ret != TestPass)\n \t\t\treturn ret;\n \n+\t\tret = testFd();\n+\t\tif (ret != TestPass)\n+\t\t\treturn ret;\n+\n \t\treturn TestPass;\n \t}\n \n@@ -435,6 +440,44 @@ private:\n \n \t\treturn TestPass;\n \t}\n+\n+\tint testFd()\n+\t{\n+\t\t/* Test serdes of single fd */\n+\t\tint memfd = memfd_create(\"test\", 0);\n+\t\tif (memfd < 0) {\n+\t\t\tcerr << \"Failed to create memfd\" << endl;\n+\t\t\treturn TestFail;\n+\t\t}\n+\n+\t\tFileDescriptor fd = FileDescriptor(std::move(memfd));\n+\t\tif (memfd != -1) {\n+\t\t\tcerr << \"FileDescriptor move constructor failed\" << endl;\n+\t\t\treturn TestFail;\n+\t\t}\n+\n+\t\tif (testPodSerdes(fd) != TestPass)\n+\t\t\treturn TestFail;\n+\n+\t\t/* Test serdes of vector of fds */\n+\t\tstd::vector<FileDescriptor> vecFds;\n+\n+\t\tfor (unsigned int i = 0; i < 10; i++) {\n+\t\t\tstd::string name = \"test\" + std::to_string(i);\n+\t\t\tint mfd = memfd_create(name.c_str(), 0);\n+\t\t\tif (mfd < 0)\n+\t\t\t\treturn TestFail;\n+\n+\t\t\tvecFds.push_back(FileDescriptor(std::move(mfd)));\n+\t\t\tif (mfd != -1)\n+\t\t\t\treturn TestFail;\n+\t\t}\n+\n+\t\tif (testVectorSerdes(vecFds) != TestPass)\n+\t\t\treturn TestFail;\n+\n+\t\treturn TestPass;\n+\t}\n };\n \n TEST_REGISTER(IPADataSerializerTest)\n", "prefixes": [ "libcamera-devel", "RFC" ] }