Patch Detail
Show a patch.
GET /api/patches/13193/?format=api
{ "id": 13193, "url": "https://patchwork.libcamera.org/api/patches/13193/?format=api", "web_url": "https://patchwork.libcamera.org/patch/13193/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210804112603.152493-1-umang.jain@ideasonboard.com>", "date": "2021-08-04T11:26:03", "name": "[libcamera-devel] ipu3: Disallow raw only camera configuration", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "6767898e8435134f4fe2671eb7ec14ee0ab32b20", "submitter": { "id": 86, "url": "https://patchwork.libcamera.org/api/people/86/?format=api", "name": "Umang Jain", "email": "umang.jain@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/13193/mbox/", "series": [ { "id": 2301, "url": "https://patchwork.libcamera.org/api/series/2301/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2301", "date": "2021-08-04T11:26:03", "name": "[libcamera-devel] ipu3: Disallow raw only camera configuration", "version": 1, "mbox": "https://patchwork.libcamera.org/series/2301/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/13193/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/13193/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 76D07C3235\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 4 Aug 2021 11:26:12 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D7D12687B6;\n\tWed, 4 Aug 2021 13:26:11 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3A02D6026E\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 4 Aug 2021 13:26:10 +0200 (CEST)", "from perceval.ideasonboard.com (unknown [103.251.226.40])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 0FB7724F;\n\tWed, 4 Aug 2021 13:26:08 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"tJTmuV1H\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1628076369;\n\tbh=ggRcDA3XoNm0MRH18417HdtYo6YEUUmJoCWVUEz8RsY=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=tJTmuV1HPobJM4JCTun3YuKKcDkRP3RNlZNQuh8oo5apCWwdtsTec0QmxTzdSpRcU\n\tl7zybtcrnhef3mcE2ORkYbFaQyuYUNN7UwuzoB+41bZcQbGFXnZTouB/m5od0Ts6cR\n\tGZHwzSMkQh+oIYY00jTkZCktJl/hRXIlUjOvf3zQ=", "From": "Umang Jain <umang.jain@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Wed, 4 Aug 2021 16:56:03 +0530", "Message-Id": "<20210804112603.152493-1-umang.jain@ideasonboard.com>", "X-Mailer": "git-send-email 2.31.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH] ipu3: Disallow raw only camera\n\tconfiguration", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Ideally to capture the raw frames, ImgU should not be required.\nHowever, we do need to configure the IPA since, it shall setup\nthe sensor controls (exposure, vblank and so on) for the capture.\nOne cannot simply configure the IPA, without the ImgU as the\nparameters and statistics buffer passed to the IPA are actually\nmanaged by the ImgU.\n\nUntil we prepare and setup the ImgU to run an internal queue for\nraw-only camera configuration, disallow this configuration and\nreport it as invalid.\n\nSigned-off-by: Umang Jain <umang.jain@ideasonboard.com>\n---\n src/libcamera/pipeline/ipu3/ipu3.cpp | 4 ++++\n 1 file changed, 4 insertions(+)", "diff": "diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\nindex 76c3bb3d..3e159279 100644\n--- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n+++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n@@ -248,6 +248,10 @@ CameraConfiguration::Status IPU3CameraConfiguration::validate()\n \tif (rawCount > 1 || yuvCount > 2) {\n \t\tLOG(IPU3, Debug) << \"Camera configuration not supported\";\n \t\treturn Invalid;\n+\t} else if (rawCount && !yuvCount) {\n+\t\tLOG(IPU3, Debug)\n+\t\t\t<< \"Camera configuration cannot support raw-only streams\";\n+\t\treturn Invalid;\n \t}\n \n \t/*\n", "prefixes": [ "libcamera-devel" ] }