Patch Detail
Show a patch.
GET /api/patches/13192/?format=api
{ "id": 13192, "url": "https://patchwork.libcamera.org/api/patches/13192/?format=api", "web_url": "https://patchwork.libcamera.org/patch/13192/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210804102156.4636-1-kieran.bingham@ideasonboard.com>", "date": "2021-08-04T10:21:56", "name": "[libcamera-devel] utils: ipc: Initialise ThreadProxy", "commit_ref": "2c18ebb859f54a5f6e620aebc6f3abf3648b7462", "pull_url": null, "state": "accepted", "archived": false, "hash": "32e613ad6cf52ae875af5a3eaa6f3e064a73a26b", "submitter": { "id": 4, "url": "https://patchwork.libcamera.org/api/people/4/?format=api", "name": "Kieran Bingham", "email": "kieran.bingham@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/13192/mbox/", "series": [ { "id": 2300, "url": "https://patchwork.libcamera.org/api/series/2300/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2300", "date": "2021-08-04T10:21:56", "name": "[libcamera-devel] utils: ipc: Initialise ThreadProxy", "version": 1, "mbox": "https://patchwork.libcamera.org/series/2300/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/13192/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/13192/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DC369C3235\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 4 Aug 2021 10:22:03 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5C4B2687B6;\n\tWed, 4 Aug 2021 12:22:02 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 80FBD6026E\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 4 Aug 2021 12:22:00 +0200 (CEST)", "from Monstersaurus.local\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1223524F;\n\tWed, 4 Aug 2021 12:22:00 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"hzN4Rx/2\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1628072520;\n\tbh=SnG992zSpfeS9Jqz0gbAK3AXC2vIKxG33v6wbZBnxhQ=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=hzN4Rx/2YQSz1hArx96CC9aEmqvihLyB1NP+XkK4LQBE8LGCLrstzTcRmisUIJ97F\n\tt6ESqAWdJwD2+tYxOx2N4MDlJ8lioF+IjmsX9WQ4m2oePPPBHoiOC9bTUTmYpLfIU4\n\t3yHRE+KHDfbtmcb87wV+jtHrDB4eg79ggayXcLHY=", "From": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "To": "libcamera devel <libcamera-devel@lists.libcamera.org>", "Date": "Wed, 4 Aug 2021 11:21:56 +0100", "Message-Id": "<20210804102156.4636-1-kieran.bingham@ideasonboard.com>", "X-Mailer": "git-send-email 2.30.2", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH] utils: ipc: Initialise ThreadProxy", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The ThreadProxy IPA template does not implement a constructor and the\ndefault compiler generated constructor does not initialise the private\nipa_ pointer.\n\nWhilst this should not be expected to be used while uninitialised, it\ndoes get caught by static analysis for every IPA module constructed, so\nlets be clean and fix it.\n\nReported-by: Coverity CID=350116\nReported-by: Coverity CID=350123\nReported-by: Coverity CID=350140\nReported-by: Coverity CID=350147\nFixes: 7832e19a599e (\"utils: ipc: add templates for code generation for IPC mechanism\")\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n .../generators/libcamera_templates/module_ipa_proxy.h.tmpl | 5 +++++\n 1 file changed, 5 insertions(+)", "diff": "diff --git a/utils/ipc/generators/libcamera_templates/module_ipa_proxy.h.tmpl b/utils/ipc/generators/libcamera_templates/module_ipa_proxy.h.tmpl\nindex ae168548492c..c222f5f204df 100644\n--- a/utils/ipc/generators/libcamera_templates/module_ipa_proxy.h.tmpl\n+++ b/utils/ipc/generators/libcamera_templates/module_ipa_proxy.h.tmpl\n@@ -72,6 +72,11 @@ private:\n \tclass ThreadProxy : public Object\n \t{\n \tpublic:\n+\t\tThreadProxy()\n+\t\t\t: ipa_(nullptr)\n+\t\t{\n+\t\t}\n+\n \t\tvoid setIPA({{interface_name}} *ipa)\n \t\t{\n \t\t\tipa_ = ipa;\n", "prefixes": [ "libcamera-devel" ] }