Patch Detail
Show a patch.
GET /api/patches/13187/?format=api
{ "id": 13187, "url": "https://patchwork.libcamera.org/api/patches/13187/?format=api", "web_url": "https://patchwork.libcamera.org/patch/13187/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210804041519.77076-1-umang.jain@ideasonboard.com>", "date": "2021-08-04T04:15:19", "name": "[libcamera-devel,IPU3-IPA] PATCH] binary_data: Use type-safe file flags", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "44248d95f0439468753a6151f592ef3cf133bb50", "submitter": { "id": 86, "url": "https://patchwork.libcamera.org/api/people/86/?format=api", "name": "Umang Jain", "email": "umang.jain@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/13187/mbox/", "series": [ { "id": 2298, "url": "https://patchwork.libcamera.org/api/series/2298/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2298", "date": "2021-08-04T04:15:19", "name": "[libcamera-devel,IPU3-IPA] PATCH] binary_data: Use type-safe file flags", "version": 1, "mbox": "https://patchwork.libcamera.org/series/2298/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/13187/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/13187/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4FA05C3232\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 4 Aug 2021 04:15:29 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id BECD66880F;\n\tWed, 4 Aug 2021 06:15:28 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 26FF160268\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 4 Aug 2021 06:15:27 +0200 (CEST)", "from perceval.ideasonboard.com (unknown [103.251.226.40])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id ABDE824F;\n\tWed, 4 Aug 2021 06:15:25 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"m2oHMWVT\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1628050526;\n\tbh=42w1g29nrx0lX/JaKLkGOkpD9MGzqnPqSZ8GFMpjFiY=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=m2oHMWVT3Z8cWKwMrhUVIDpXgiO+VUi11WvFveiz2YzUBVqK/GTyv7rXgTvTrWnAj\n\tZG3uhk3wFR1HXdnKAE0RRTJd3bUU4cUGt+XOlIrtxl5jN0atcJtZUUbWhmUmyMPyk0\n\tgxS56enb71Blu9U4PbxDmhL/jPwiAB7aI+DpKIzA=", "From": "Umang Jain <umang.jain@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Wed, 4 Aug 2021 09:45:19 +0530", "Message-Id": "<20210804041519.77076-1-umang.jain@ideasonboard.com>", "X-Mailer": "git-send-email 2.31.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [IPU3-IPA]PATCH] binary_data: Use type-safe file\n\tflags", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "In commit 91d06ae2fc61(\"libcamera: file: Use Flags<> class for open\nflags\"), type-safe file mode flags are introduced. Adapt our usage\naccordingly in BinaryData, which uses the File class from libcamera.\n\nSigned-off-by: Umang Jain <umang.jain@ideasonboard.com>\n---\n binary_data.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/binary_data.cpp b/binary_data.cpp\nindex aa65778..27fc9fe 100644\n--- a/binary_data.cpp\n+++ b/binary_data.cpp\n@@ -37,7 +37,7 @@ int BinaryData::load(const char *filename)\n \t\treturn -ENOENT;\n \t}\n \n-\tif (!binary.open(File::ReadOnly)) {\n+\tif (!binary.open(File::OpenModeFlag::ReadOnly)) {\n \t\tLOG(AIBD, Error) << \"Failed to open: \" << filename;\n \t\treturn -EINVAL;\n \t}\n", "prefixes": [ "libcamera-devel", "IPU3-IPA" ] }