Patch Detail
Show a patch.
GET /api/patches/13184/?format=api
{ "id": 13184, "url": "https://patchwork.libcamera.org/api/patches/13184/?format=api", "web_url": "https://patchwork.libcamera.org/patch/13184/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210803140237.19302-3-umang.jain@ideasonboard.com>", "date": "2021-08-03T14:02:35", "name": "[libcamera-devel,v4,2/4] android: Disallow external location in HAL config", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "a8a299a596ef41ae5c63d6a73a2da9e96b128863", "submitter": { "id": 86, "url": "https://patchwork.libcamera.org/api/people/86/?format=api", "name": "Umang Jain", "email": "umang.jain@ideasonboard.com" }, "delegate": { "id": 12, "url": "https://patchwork.libcamera.org/api/users/12/?format=api", "username": "uajain", "first_name": "Umang", "last_name": "Jain", "email": "umang.jain@ideasonboard.com" }, "mbox": "https://patchwork.libcamera.org/patch/13184/mbox/", "series": [ { "id": 2297, "url": "https://patchwork.libcamera.org/api/series/2297/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2297", "date": "2021-08-03T14:02:33", "name": "android: Handle internal UVC cameras", "version": 4, "mbox": "https://patchwork.libcamera.org/series/2297/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/13184/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/13184/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0259CC3232\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 3 Aug 2021 14:02:52 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B27F2687DC;\n\tTue, 3 Aug 2021 16:02:51 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3B58C687BC\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 3 Aug 2021 16:02:50 +0200 (CEST)", "from perceval.ideasonboard.com (unknown [103.238.109.12])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6376C3F0;\n\tTue, 3 Aug 2021 16:02:48 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"EzE+JQR3\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1627999370;\n\tbh=JaHEGyTAkI24k/1Zc4mweJ7RHEON5+/GY352XRhGDBA=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=EzE+JQR3wnkBz1rvwOov9/KDdlEl214sARWN+cRWa7sj6CbDuaBdAfAhvKGF+foZs\n\tyDF2pol9EBBUj53y2QDrVOEF4ufJcUekk7o0dmv/mdnHfmYY9ANvMcHldSsOokg0Cs\n\tDDDEbcFYhG5L8hYIlq6sYaI+CclcalGE+qDtvyK8=", "From": "Umang Jain <umang.jain@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 3 Aug 2021 19:32:35 +0530", "Message-Id": "<20210803140237.19302-3-umang.jain@ideasonboard.com>", "X-Mailer": "git-send-email 2.31.1", "In-Reply-To": "<20210803140237.19302-1-umang.jain@ideasonboard.com>", "References": "<20210803140237.19302-1-umang.jain@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v4 2/4] android: Disallow external\n\tlocation in HAL config", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Error out on any camera's location if set to \"external\", in the HAL\nconfiguration file. The HAL configuration file is meant to override the\nlocation property, and overriding an internal camera location to\nexternal doesn't make sense.\n\nSigned-off-by: Umang Jain <umang.jain@ideasonboard.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nReviewed-by: Paul Elder <paul.elder@ideasonboard.com>\nReviewed-by: Jacopo Mondi <jacopo@jmondi.org>\n---\n src/android/camera_hal_config.cpp | 2 --\n 1 file changed, 2 deletions(-)", "diff": "diff --git a/src/android/camera_hal_config.cpp b/src/android/camera_hal_config.cpp\nindex 833cf4ba..7126aba4 100644\n--- a/src/android/camera_hal_config.cpp\n+++ b/src/android/camera_hal_config.cpp\n@@ -127,8 +127,6 @@ int CameraHalConfig::Private::parseCameraLocation(CameraConfigData *cameraConfig\n \t\tcameraConfigData->facing = CAMERA_FACING_FRONT;\n \telse if (location == \"back\")\n \t\tcameraConfigData->facing = CAMERA_FACING_BACK;\n-\telse if (location == \"external\")\n-\t\tcameraConfigData->facing = CAMERA_FACING_EXTERNAL;\n \telse\n \t\treturn -EINVAL;\n \n", "prefixes": [ "libcamera-devel", "v4", "2/4" ] }