Patch Detail
Show a patch.
GET /api/patches/13160/?format=api
{ "id": 13160, "url": "https://patchwork.libcamera.org/api/patches/13160/?format=api", "web_url": "https://patchwork.libcamera.org/patch/13160/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210730103536.81117-3-paul.elder@ideasonboard.com>", "date": "2021-07-30T10:35:29", "name": "[libcamera-devel,v6,2/9] android: metadata: Add hasEntry and entryContains", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "007cdbdc9fa7e1e42ae256225107a9f766491f11", "submitter": { "id": 17, "url": "https://patchwork.libcamera.org/api/people/17/?format=api", "name": "Paul Elder", "email": "paul.elder@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/13160/mbox/", "series": [ { "id": 2291, "url": "https://patchwork.libcamera.org/api/series/2291/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2291", "date": "2021-07-30T10:35:27", "name": "android: Support capability and hardware level detection", "version": 6, "mbox": "https://patchwork.libcamera.org/series/2291/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/13160/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/13160/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1657AC322E\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 30 Jul 2021 10:35:52 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C216B687C3;\n\tFri, 30 Jul 2021 12:35:51 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 16FDF687C2\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 30 Jul 2021 12:35:50 +0200 (CEST)", "from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 4FF6E89B;\n\tFri, 30 Jul 2021 12:35:47 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ceYWIO27\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1627641349;\n\tbh=prHxa9oWiKdKOpjU0IpXGfgytQ0SN/TlxCVufRAM5Hk=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=ceYWIO27JcATFzpcm3LGV5rzDQEXE/lvZlVUiTiC9K6u9VX4Uy+QDMrM5glsbNUkK\n\t7138ydcMkcErvWE3MYopE/Yed8r/AyT60aLpk/Pz66YZ51yKlMvQDhbgrNoUqU+C/C\n\tgZYAEcH4jNUD8AtNEE6gyeEu/7kctgbU9rNbsgCM=", "From": "Paul Elder <paul.elder@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 30 Jul 2021 19:35:29 +0900", "Message-Id": "<20210730103536.81117-3-paul.elder@ideasonboard.com>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20210730103536.81117-1-paul.elder@ideasonboard.com>", "References": "<20210730103536.81117-1-paul.elder@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v6 2/9] android: metadata: Add hasEntry\n\tand entryContains", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Add convenience functions for checking if an entry is present in a\nCameraMetadata instance, and to check if an array entry includes a\nspecific value.\n\nSigned-off-by: Paul Elder <paul.elder@ideasonboard.com>\nReviewed-by: Jacopo Mondi <jacopo@jmondi.org>\n\n---\nChanges in v6:\n- restore to v4\n\nChanges in v5:\n- refactor template code to reduce the footprint of specialized template\n code\n\nNew in v4\n---\n src/android/camera_metadata.cpp | 20 ++++++++++++++++++++\n src/android/camera_metadata.h | 4 ++++\n 2 files changed, 24 insertions(+)", "diff": "diff --git a/src/android/camera_metadata.cpp b/src/android/camera_metadata.cpp\nindex 3fc7cf27..075b6a22 100644\n--- a/src/android/camera_metadata.cpp\n+++ b/src/android/camera_metadata.cpp\n@@ -121,6 +121,26 @@ bool CameraMetadata::resize(size_t count, size_t size)\n \treturn true;\n }\n \n+template<> bool CameraMetadata::entryContains(uint32_t tag, uint8_t value) const\n+{\n+\tcamera_metadata_ro_entry_t entry;\n+\tif (!getEntry(tag, &entry))\n+\t\treturn false;\n+\n+\tfor (unsigned int i = 0; i < entry.count; i++) {\n+\t\tif (entry.data.u8[i] == value)\n+\t\t\treturn true;\n+\t}\n+\n+\treturn false;\n+}\n+\n+bool CameraMetadata::hasEntry(uint32_t tag) const\n+{\n+\tcamera_metadata_ro_entry_t entry;\n+\treturn getEntry(tag, &entry);\n+}\n+\n bool CameraMetadata::addEntry(uint32_t tag, const void *data, size_t count,\n \t\t\t size_t elementSize)\n {\ndiff --git a/src/android/camera_metadata.h b/src/android/camera_metadata.h\nindex 3b7c9e24..03b3e701 100644\n--- a/src/android/camera_metadata.h\n+++ b/src/android/camera_metadata.h\n@@ -29,6 +29,10 @@ public:\n \tbool isValid() const { return valid_; }\n \tbool getEntry(uint32_t tag, camera_metadata_ro_entry_t *entry) const;\n \n+\ttemplate<typename T> bool entryContains(uint32_t tag, T value) const;\n+\n+\tbool hasEntry(uint32_t tag) const;\n+\n \ttemplate<typename T,\n \t\t std::enable_if_t<std::is_arithmetic_v<T>> * = nullptr>\n \tbool addEntry(uint32_t tag, const T &data)\n", "prefixes": [ "libcamera-devel", "v6", "2/9" ] }