Patch Detail
Show a patch.
GET /api/patches/1316/?format=api
{ "id": 1316, "url": "https://patchwork.libcamera.org/api/patches/1316/?format=api", "web_url": "https://patchwork.libcamera.org/patch/1316/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20190527090559.26549-6-jacopo@jmondi.org>", "date": "2019-05-27T09:05:58", "name": "[libcamera-devel,v2,5/6] include: linux: intel-ipu3: Force alignement to 32 bytes", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "43d48a44b584996e0fe45325ecbac355a6452f1a", "submitter": { "id": 3, "url": "https://patchwork.libcamera.org/api/people/3/?format=api", "name": "Jacopo Mondi", "email": "jacopo@jmondi.org" }, "delegate": { "id": 15, "url": "https://patchwork.libcamera.org/api/users/15/?format=api", "username": "jmondi", "first_name": "Jacopo", "last_name": "Mondi", "email": "jacopo@jmondi.org" }, "mbox": "https://patchwork.libcamera.org/patch/1316/mbox/", "series": [ { "id": 329, "url": "https://patchwork.libcamera.org/api/series/329/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=329", "date": "2019-05-27T09:05:53", "name": "META_OUTPUT support + IPU3 parameters tuning", "version": 2, "mbox": "https://patchwork.libcamera.org/series/329/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/1316/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/1316/checks/", "tags": {}, "headers": { "Return-Path": "<jacopo@jmondi.org>", "Received": [ "from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net\n\t[217.70.183.195])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9D25C618FB\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 27 May 2019 11:05:06 +0200 (CEST)", "from uno.lan (2-224-242-101.ip172.fastwebnet.it [2.224.242.101])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay3-d.mail.gandi.net (Postfix) with ESMTPSA id 17B0B60019;\n\tMon, 27 May 2019 09:05:04 +0000 (UTC)" ], "X-Originating-IP": "2.224.242.101", "From": "Jacopo Mondi <jacopo@jmondi.org>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Mon, 27 May 2019 11:05:58 +0200", "Message-Id": "<20190527090559.26549-6-jacopo@jmondi.org>", "X-Mailer": "git-send-email 2.21.0", "In-Reply-To": "<20190527090559.26549-1-jacopo@jmondi.org>", "References": "<20190527090559.26549-1-jacopo@jmondi.org>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v2 5/6] include: linux: intel-ipu3: Force\n\talignement to 32 bytes", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.23", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Mon, 27 May 2019 09:05:06 -0000" }, "content": "Fix compilation error on GCC 8.3.0\n\ninclude/linux/intel-ipu3.h:2475:35: error: ‘ipu3_uapi_acc_param::awb_fr’\noffset 36756 in ‘ipu3_uapi_acc_param’ isn’t aligned to 32\n[-Werror=packed-not-aligned]\n\nby forcing alignment to 32 bytes for struct ipu3_uapi_awb_fr_config_s.\nThe structure is itself defined as 32 bytes aligned, so adding another\nalignment directive to the field definition should not change the\nstructure memory layout.\n\nThe error is reported by gcc8.3.0 only and not by other gcc compiler\nversions (5.4.0) or clang.\n\nAs the header is exported from Linux v5.1 this is a workaround and\nshould probably be fixed in the kernel headers themselves if the error\nis consistently reported in future compiler versions.\n\nSigned-off-by: Jacopo Mondi <jacopo@jmondi.org>\n---\n include/linux/intel-ipu3.h | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/include/linux/intel-ipu3.h b/include/linux/intel-ipu3.h\nindex f758c9ba230b..fe6e8ed15eb1 100644\n--- a/include/linux/intel-ipu3.h\n+++ b/include/linux/intel-ipu3.h\n@@ -2472,7 +2472,7 @@ struct ipu3_uapi_acc_param {\n \tstruct ipu3_uapi_yuvp1_yds_config yds2 __attribute__((aligned(32)));\n \tstruct ipu3_uapi_yuvp2_tcc_static_config tcc __attribute__((aligned(32)));\n \tstruct ipu3_uapi_anr_config anr;\n-\tstruct ipu3_uapi_awb_fr_config_s awb_fr;\n+\tstruct ipu3_uapi_awb_fr_config_s awb_fr __attribute__((aligned(32)));\n \tstruct ipu3_uapi_ae_config ae;\n \tstruct ipu3_uapi_af_config_s af;\n \tstruct ipu3_uapi_awb_config awb;\n", "prefixes": [ "libcamera-devel", "v2", "5/6" ] }