Patch Detail
Show a patch.
GET /api/patches/13121/?format=api
{ "id": 13121, "url": "https://patchwork.libcamera.org/api/patches/13121/?format=api", "web_url": "https://patchwork.libcamera.org/patch/13121/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210726153100.27856-3-jacopo@jmondi.org>", "date": "2021-07-26T15:30:59", "name": "[libcamera-devel,v2,2/3] android: capabilties: Rationalize get[YUV|Raw]Resolution names", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "916a4fa61017306b9a72083bb4690fcc56b1071c", "submitter": { "id": 3, "url": "https://patchwork.libcamera.org/api/people/3/?format=api", "name": "Jacopo Mondi", "email": "jacopo@jmondi.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/13121/mbox/", "series": [ { "id": 2279, "url": "https://patchwork.libcamera.org/api/series/2279/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2279", "date": "2021-07-26T15:30:57", "name": "android: Drive-by cleanups", "version": 2, "mbox": "https://patchwork.libcamera.org/series/2279/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/13121/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/13121/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 62636C322C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 26 Jul 2021 15:30:22 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DB725687C3;\n\tMon, 26 Jul 2021 17:30:21 +0200 (CEST)", "from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net\n\t[217.70.183.197])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 678A5687AF\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 26 Jul 2021 17:30:19 +0200 (CEST)", "(Authenticated sender: jacopo@jmondi.org)\n\tby relay5-d.mail.gandi.net (Postfix) with ESMTPSA id 42C2A1C000D;\n\tMon, 26 Jul 2021 15:30:18 +0000 (UTC)" ], "From": "Jacopo Mondi <jacopo@jmondi.org>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Mon, 26 Jul 2021 17:30:59 +0200", "Message-Id": "<20210726153100.27856-3-jacopo@jmondi.org>", "X-Mailer": "git-send-email 2.32.0", "In-Reply-To": "<20210726153100.27856-1-jacopo@jmondi.org>", "References": "<20210726153100.27856-1-jacopo@jmondi.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v2 2/3] android: capabilties: Rationalize\n\tget[YUV|Raw]Resolution names", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The getYUVResolutions() and getRawResolutions() functions are called\nfrom the initializeStreamConfigurations() function, which is called by\ninitialize().\n\nRationalize the function naming scheme by renaming the two functions to\ninitializeYUVResolutions() and initializeRawResolution().\n\nCosmetic change only.\n\nSigned-off-by: Jacopo Mondi <jacopo@jmondi.org>\nReviewed-by: Umang Jain <umang.jain@ideasonboard.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/android/camera_capabilities.cpp | 14 ++++++++------\n src/android/camera_capabilities.h | 6 +++---\n 2 files changed, 11 insertions(+), 9 deletions(-)", "diff": "diff --git a/src/android/camera_capabilities.cpp b/src/android/camera_capabilities.cpp\nindex 6543c2bbc6c3..15e54192adff 100644\n--- a/src/android/camera_capabilities.cpp\n+++ b/src/android/camera_capabilities.cpp\n@@ -138,8 +138,9 @@ int CameraCapabilities::initialize(std::shared_ptr<libcamera::Camera> camera,\n \treturn initializeStaticMetadata();\n }\n \n-std::vector<Size> CameraCapabilities::getYUVResolutions(const PixelFormat &pixelFormat,\n-\t\t\t\t\t\t\tconst std::vector<Size> &resolutions)\n+std::vector<Size>\n+CameraCapabilities::initializeYUVResolutions(const PixelFormat &pixelFormat,\n+\t\t\t\t\t const std::vector<Size> &resolutions)\n {\n \tstd::vector<Size> supportedResolutions;\n \tstd::unique_ptr<CameraConfiguration> cameraConfig =\n@@ -164,7 +165,8 @@ std::vector<Size> CameraCapabilities::getYUVResolutions(const PixelFormat &pixel\n \treturn supportedResolutions;\n }\n \n-std::vector<Size> CameraCapabilities::getRawResolutions(const libcamera::PixelFormat &pixelFormat)\n+std::vector<Size>\n+CameraCapabilities::initializeRawResolutions(const libcamera::PixelFormat &pixelFormat)\n {\n \tstd::unique_ptr<CameraConfiguration> cameraConfig =\n \t\tcamera_->generateConfiguration({ StreamRole::Raw });\n@@ -323,10 +325,10 @@ int CameraCapabilities::initializeStreamConfigurations()\n \t\tstd::vector<Size> resolutions;\n \t\tconst PixelFormatInfo &info = PixelFormatInfo::info(mappedFormat);\n \t\tif (info.colourEncoding == PixelFormatInfo::ColourEncodingRAW)\n-\t\t\tresolutions = getRawResolutions(mappedFormat);\n+\t\t\tresolutions = initializeRawResolutions(mappedFormat);\n \t\telse\n-\t\t\tresolutions = getYUVResolutions(mappedFormat,\n-\t\t\t\t\t\t\tcameraResolutions);\n+\t\t\tresolutions = initializeYUVResolutions(mappedFormat,\n+\t\t\t\t\t\t\t cameraResolutions);\n \n \t\tfor (const Size &res : resolutions) {\n \t\t\tstreamConfigurations_.push_back({ res, androidFormat });\ndiff --git a/src/android/camera_capabilities.h b/src/android/camera_capabilities.h\nindex e72bf084cd65..e7aa46c0a689 100644\n--- a/src/android/camera_capabilities.h\n+++ b/src/android/camera_capabilities.h\n@@ -43,10 +43,10 @@ private:\n \t};\n \n \tstd::vector<libcamera::Size>\n-\tgetYUVResolutions(const libcamera::PixelFormat &pixelFormat,\n-\t\t\t const std::vector<libcamera::Size> &resolutions);\n+\tinitializeYUVResolutions(const libcamera::PixelFormat &pixelFormat,\n+\t\t\t\t const std::vector<libcamera::Size> &resolutions);\n \tstd::vector<libcamera::Size>\n-\tgetRawResolutions(const libcamera::PixelFormat &pixelFormat);\n+\tinitializeRawResolutions(const libcamera::PixelFormat &pixelFormat);\n \tint initializeStreamConfigurations();\n \n \tint initializeStaticMetadata();\n", "prefixes": [ "libcamera-devel", "v2", "2/3" ] }