Patch Detail
Show a patch.
GET /api/patches/13108/?format=api
{ "id": 13108, "url": "https://patchwork.libcamera.org/api/patches/13108/?format=api", "web_url": "https://patchwork.libcamera.org/patch/13108/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210723112233.1361319-3-umang.jain@ideasonboard.com>", "date": "2021-07-23T11:22:33", "name": "[libcamera-devel,2/2] media: imx258: Limit the max analogue gain to 480", "commit_ref": null, "pull_url": null, "state": "not-applicable", "archived": false, "hash": "cf19f055aff22f1ed23dbede2b75c5459b462ddc", "submitter": { "id": 86, "url": "https://patchwork.libcamera.org/api/people/86/?format=api", "name": "Umang Jain", "email": "umang.jain@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/13108/mbox/", "series": [ { "id": 2273, "url": "https://patchwork.libcamera.org/api/series/2273/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2273", "date": "2021-07-23T11:22:31", "name": "IMX258 driver fixes", "version": 1, "mbox": "https://patchwork.libcamera.org/series/2273/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/13108/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/13108/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DB3E9C322C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 23 Jul 2021 11:22:49 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 973F0687A4;\n\tFri, 23 Jul 2021 13:22:49 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7056968544\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 23 Jul 2021 13:22:48 +0200 (CEST)", "from perceval.ideasonboard.com (unknown [103.251.226.103])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 433C056B;\n\tFri, 23 Jul 2021 13:22:47 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"g4ioskTV\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1627039368;\n\tbh=CC5F2wiPZj5TjrGGlK+tG8+gcD3f2SeeVIW/I7P3EAs=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=g4ioskTVdaAACAtzmm2tIo74/tcSijJQrUgypfgEyr40hpCoOdTA3HrmIcyU0mQIp\n\tQLH6GMdFWXKBL08KV32A6hz7t7R3eZqNi6Wn+2OpuBVuTUSv/vYQSdKy6u0hy2ja5i\n\t+XvOHvg2kOvjKp3t0loGVE1+ttlk5x/Jk9rcBVZI=", "From": "Umang Jain <umang.jain@ideasonboard.com>", "To": "linux-media@vger.kernel.org", "Date": "Fri, 23 Jul 2021 16:52:33 +0530", "Message-Id": "<20210723112233.1361319-3-umang.jain@ideasonboard.com>", "X-Mailer": "git-send-email 2.31.1", "In-Reply-To": "<20210723112233.1361319-1-umang.jain@ideasonboard.com>", "References": "<20210723112233.1361319-1-umang.jain@ideasonboard.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 2/2] media: imx258: Limit the max analogue\n\tgain to 480", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Cc": "libcamera-devel@lists.libcamera.org", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The range for analog gain mentioned in the datasheet is [0, 480].\nThe real gain formula mentioned in the datasheet is:\n\n\tGain = 512 / (512 – X)\n\nHence, values larger than 511 clearly makes no sense. The gain\nregister field is also documented to be of 9-bits in the datasheet.\n\nCertainly, it is enough to infer that, the kernel driver currently\nadvertises an arbitrary analog gain max. Fix it by rectifying the\nvalue as per the data sheet i.e. 480.\n\nSigned-off-by: Umang Jain <umang.jain@ideasonboard.com>\n---\n drivers/media/i2c/imx258.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/drivers/media/i2c/imx258.c b/drivers/media/i2c/imx258.c\nindex 4e695096e5d0..81cdf37216ca 100644\n--- a/drivers/media/i2c/imx258.c\n+++ b/drivers/media/i2c/imx258.c\n@@ -47,7 +47,7 @@\n /* Analog gain control */\n #define IMX258_REG_ANALOG_GAIN\t\t0x0204\n #define IMX258_ANA_GAIN_MIN\t\t0\n-#define IMX258_ANA_GAIN_MAX\t\t0x1fff\n+#define IMX258_ANA_GAIN_MAX\t\t480\n #define IMX258_ANA_GAIN_STEP\t\t1\n #define IMX258_ANA_GAIN_DEFAULT\t\t0x0\n \n", "prefixes": [ "libcamera-devel", "2/2" ] }