Patch Detail
Show a patch.
GET /api/patches/131/?format=api
{ "id": 131, "url": "https://patchwork.libcamera.org/api/patches/131/?format=api", "web_url": "https://patchwork.libcamera.org/patch/131/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20190102110016.5489-2-jacopo@jmondi.org>", "date": "2019-01-02T11:00:16", "name": "[libcamera-devel,2/2] libcamera: media_device: Make getEntityByName() const", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "3bb4e71da80dcce5371ab46f831ddadaac61c529", "submitter": { "id": 3, "url": "https://patchwork.libcamera.org/api/people/3/?format=api", "name": "Jacopo Mondi", "email": "jacopo@jmondi.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/131/mbox/", "series": [ { "id": 48, "url": "https://patchwork.libcamera.org/api/series/48/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=48", "date": "2019-01-02T11:00:15", "name": "[libcamera-devel,1/2] libcamera: media_device: Tiny valid() documentation improvement", "version": 1, "mbox": "https://patchwork.libcamera.org/series/48/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/131/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/131/checks/", "tags": {}, "headers": { "Return-Path": "<jacopo@jmondi.org>", "Received": [ "from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net\n\t[217.70.183.195])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 804DF60B34\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 2 Jan 2019 12:00:20 +0100 (CET)", "from uno.lan (2-224-242-101.ip172.fastwebnet.it [2.224.242.101])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay3-d.mail.gandi.net (Postfix) with ESMTPSA id 22EBB6000C;\n\tWed, 2 Jan 2019 11:00:19 +0000 (UTC)" ], "X-Originating-IP": "2.224.242.101", "From": "Jacopo Mondi <jacopo@jmondi.org>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Wed, 2 Jan 2019 12:00:16 +0100", "Message-Id": "<20190102110016.5489-2-jacopo@jmondi.org>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20190102110016.5489-1-jacopo@jmondi.org>", "References": "<20190102110016.5489-1-jacopo@jmondi.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 2/2] libcamera: media_device: Make\n\tgetEntityByName() const", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.23", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Wed, 02 Jan 2019 11:00:20 -0000" }, "content": "The function does not modify the instance state. Mark it as const.\n\nSigned-off-by: Jacopo Mondi <jacopo@jmondi.org>\n---\n src/libcamera/include/media_device.h | 2 +-\n src/libcamera/media_device.cpp | 2 +-\n 2 files changed, 2 insertions(+), 2 deletions(-)\n\n--\n2.20.1", "diff": "diff --git a/src/libcamera/include/media_device.h b/src/libcamera/include/media_device.h\nindex d787be3..9db18bb 100644\n--- a/src/libcamera/include/media_device.h\n+++ b/src/libcamera/include/media_device.h\n@@ -34,7 +34,7 @@ public:\n \tconst std::string devnode() const { return devnode_; }\n\n \tconst std::vector<MediaEntity *> &entities() const { return entities_; }\n-\tMediaEntity *getEntityByName(const std::string &name);\n+\tMediaEntity *getEntityByName(const std::string &name) const;\n\n private:\n \tstd::string driver_;\ndiff --git a/src/libcamera/media_device.cpp b/src/libcamera/media_device.cpp\nindex 9fbc5a7..25d1825 100644\n--- a/src/libcamera/media_device.cpp\n+++ b/src/libcamera/media_device.cpp\n@@ -244,7 +244,7 @@ int MediaDevice::populate()\n * \\return The entity with \\a name\n * \\return nullptr if no entity with \\a name is found\n */\n-MediaEntity *MediaDevice::getEntityByName(const std::string &name)\n+MediaEntity *MediaDevice::getEntityByName(const std::string &name) const\n {\n \tfor (MediaEntity *e : entities_)\n \t\tif (e->name() == name)\n", "prefixes": [ "libcamera-devel", "2/2" ] }