Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 1309,
    "url": "https://patchwork.libcamera.org/api/patches/1309/?format=api",
    "web_url": "https://patchwork.libcamera.org/patch/1309/",
    "project": {
        "id": 1,
        "url": "https://patchwork.libcamera.org/api/projects/1/?format=api",
        "name": "libcamera",
        "link_name": "libcamera",
        "list_id": "libcamera_core",
        "list_email": "libcamera-devel@lists.libcamera.org",
        "web_url": "",
        "scm_url": "",
        "webscm_url": ""
    },
    "msgid": "<20190527001543.13593-16-niklas.soderlund@ragnatech.se>",
    "date": "2019-05-27T00:15:41",
    "name": "[libcamera-devel,15/17] cam: Validate camera configuration",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": false,
    "hash": "d5190905d435be97bf2bf0c452549990450ab693",
    "submitter": {
        "id": 5,
        "url": "https://patchwork.libcamera.org/api/people/5/?format=api",
        "name": "Niklas Söderlund",
        "email": "niklas.soderlund@ragnatech.se"
    },
    "delegate": null,
    "mbox": "https://patchwork.libcamera.org/patch/1309/mbox/",
    "series": [
        {
            "id": 328,
            "url": "https://patchwork.libcamera.org/api/series/328/?format=api",
            "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=328",
            "date": "2019-05-27T00:15:28",
            "name": "libcamera: Add support for format information and validation",
            "version": 1,
            "mbox": "https://patchwork.libcamera.org/series/328/mbox/"
        }
    ],
    "comments": "https://patchwork.libcamera.org/api/patches/1309/comments/",
    "check": "pending",
    "checks": "https://patchwork.libcamera.org/api/patches/1309/checks/",
    "tags": {},
    "headers": {
        "Return-Path": "<niklas.soderlund@ragnatech.se>",
        "Received": [
            "from vsp-unauthed02.binero.net (vsp-unauthed02.binero.net\n\t[195.74.38.227])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3518B60E47\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 27 May 2019 02:16:14 +0200 (CEST)",
            "from bismarck.berto.se (unknown [89.233.230.99])\n\tby bin-vsp-out-01.atm.binero.net (Halon) with ESMTPA\n\tid a1228b87-8014-11e9-8ab4-005056917a89;\n\tMon, 27 May 2019 02:16:10 +0200 (CEST)"
        ],
        "X-Halon-ID": "a1228b87-8014-11e9-8ab4-005056917a89",
        "Authorized-sender": "niklas@soderlund.pp.se",
        "From": "=?utf-8?q?Niklas_S=C3=B6derlund?= <niklas.soderlund@ragnatech.se>",
        "To": "libcamera-devel@lists.libcamera.org",
        "Date": "Mon, 27 May 2019 02:15:41 +0200",
        "Message-Id": "<20190527001543.13593-16-niklas.soderlund@ragnatech.se>",
        "X-Mailer": "git-send-email 2.21.0",
        "In-Reply-To": "<20190527001543.13593-1-niklas.soderlund@ragnatech.se>",
        "References": "<20190527001543.13593-1-niklas.soderlund@ragnatech.se>",
        "MIME-Version": "1.0",
        "Content-Type": "text/plain; charset=UTF-8",
        "Content-Transfer-Encoding": "8bit",
        "Subject": "[libcamera-devel] [PATCH 15/17] cam: Validate camera configuration",
        "X-BeenThere": "libcamera-devel@lists.libcamera.org",
        "X-Mailman-Version": "2.1.23",
        "Precedence": "list",
        "List-Id": "<libcamera-devel.lists.libcamera.org>",
        "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>",
        "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>",
        "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>",
        "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>",
        "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>",
        "X-List-Received-Date": "Mon, 27 May 2019 00:16:15 -0000"
    },
    "content": "Use CameraConfiguration::validate() to validate and possibly update the\ncamera configuration when its prepared.\n\nSigned-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\n---\n src/cam/main.cpp | 12 ++++++++++++\n 1 file changed, 12 insertions(+)",
    "diff": "diff --git a/src/cam/main.cpp b/src/cam/main.cpp\nindex 338740d1512c7189..25538f5ba95552d6 100644\n--- a/src/cam/main.cpp\n+++ b/src/cam/main.cpp\n@@ -236,6 +236,18 @@ int CamApp::prepareConfig()\n \t\t}\n \t}\n \n+\tswitch (config_->validate()) {\n+\tcase CameraConfiguration::Valid:\n+\t\tbreak;\n+\tcase CameraConfiguration::Adjusted:\n+\t\tstd::cout << \"Camera configuration adjusted\" << std::endl;\n+\t\tbreak;\n+\tcase CameraConfiguration::Invalid:\n+\t\tstd::cout << \"Camera configuration invalid\" << std::endl;\n+\t\tconfig_.reset();\n+\t\treturn -EINVAL;\n+\t}\n+\n \treturn 0;\n }\n \n",
    "prefixes": [
        "libcamera-devel",
        "15/17"
    ]
}