Patch Detail
Show a patch.
GET /api/patches/13068/?format=api
{ "id": 13068, "url": "https://patchwork.libcamera.org/api/patches/13068/?format=api", "web_url": "https://patchwork.libcamera.org/patch/13068/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210721115220.5090-3-david.plowman@raspberrypi.com>", "date": "2021-07-21T11:52:19", "name": "[libcamera-devel,2/3] utils: raspberrypi: ctt: Fix usage of findHomography function", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "9ca4bd225ff22de2730ac4d704547bc1b49cad11", "submitter": { "id": 42, "url": "https://patchwork.libcamera.org/api/people/42/?format=api", "name": "David Plowman", "email": "david.plowman@raspberrypi.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/13068/mbox/", "series": [ { "id": 2265, "url": "https://patchwork.libcamera.org/api/series/2265/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2265", "date": "2021-07-21T11:52:17", "name": "Raspberry Pi: support imx378 sensor", "version": 1, "mbox": "https://patchwork.libcamera.org/series/2265/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/13068/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/13068/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A6EBDC322C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 21 Jul 2021 11:52:35 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 072EA68547;\n\tWed, 21 Jul 2021 13:52:34 +0200 (CEST)", "from mail-wr1-x431.google.com (mail-wr1-x431.google.com\n\t[IPv6:2a00:1450:4864:20::431])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BA4AF60277\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 21 Jul 2021 13:52:31 +0200 (CEST)", "by mail-wr1-x431.google.com with SMTP id r11so1865622wro.9\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 21 Jul 2021 04:52:31 -0700 (PDT)", "from pi4-davidp.pitowers.org\n\t([2a00:1098:3142:14:1ce1:9965:4328:89c4])\n\tby smtp.gmail.com with ESMTPSA id\n\te11sm32876268wrt.0.2021.07.21.04.52.30\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 21 Jul 2021 04:52:30 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"lwAMZcZj\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=mGL+m6pijTfByh3n9dcoNug7oFdwkWv4O89mJve8Ghc=;\n\tb=lwAMZcZjSc/Yxd5THMzwK8ffX6oMTfuSzW/buH07wRr61v8o2J/yPESrM7/+AQ5irX\n\tV+7FgCXWbG6qFDG6CPi+AyFEYJnQTGWCalRrxY+MhHU9WqP2EuLuVDRZooEMhKHMde+k\n\tCfLv6aDFl/hC7b6xJvM1tuZC3TXk5Kpdr0p4fRYBQX6RbJSixgeqKfBJ6frY2Yz8MIcK\n\t19MZTPi1YMtNfrKp95gaRPd8kCY0ZeU7qJEVNj8JEPI6J4/S9OdTavseZxRhOyk+PULw\n\tbBrqle9BIse+hrDUR5oEZZopcmILJwq2/NkcFyilU3SEyZF360gpVIOhoYypwCnvb1Ub\n\tBpZQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=mGL+m6pijTfByh3n9dcoNug7oFdwkWv4O89mJve8Ghc=;\n\tb=ZmYg4qLWyXo864fuNO2bBumvqb7R55SqeRqeN8uA3YDI9tzCf3g6z9FMilpVOtsGcF\n\tJL8pRctAd1uBtN+VBe62bgteqKoyOlSjrGTAzFdAWy68QQRDFNCKbFXYPwzOhlqCUDEM\n\tLzbtuQDSpNT+L2qFwVFj23T0FFdQkBgE6KAuKXYmeqEXZBr2JQ/WRfFKBciUzz1P43tO\n\t6CMxuZoXz59QziqHM8YwDirADUPJwqG7OsCctmF203P3IJqi+09K7OvPPQoKYf65hatW\n\tqy2+aGVN6WiJoIsmtiB8hwCUg0WE+ZzSJJuGMr9wnqGjG3sNx+ecFH8sH+/vm4Ydq0+T\n\txLlA==", "X-Gm-Message-State": "AOAM531p+rJoby+YaT+jmlLHuDLIErMdFAv02WgbnktlGvq8UBv1qGtN\n\tx5WeLOTLarAVKeWiBdta7K3YK9Rz8jBOCA==", "X-Google-Smtp-Source": "ABdhPJwq0bYzcbg2/JQPSTf55V0/EwV0755PkR88He7NJFnV3VR5JrZrAWN8WvAxzclVdrgyhLzwhw==", "X-Received": "by 2002:a5d:46d1:: with SMTP id g17mr42879030wrs.2.1626868351371;\n\tWed, 21 Jul 2021 04:52:31 -0700 (PDT)", "From": "David Plowman <david.plowman@raspberrypi.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Wed, 21 Jul 2021 12:52:19 +0100", "Message-Id": "<20210721115220.5090-3-david.plowman@raspberrypi.com>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20210721115220.5090-1-david.plowman@raspberrypi.com>", "References": "<20210721115220.5090-1-david.plowman@raspberrypi.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 2/3] utils: raspberrypi: ctt: Fix usage of\n\tfindHomography function", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The OpenCV findHomography function now raises an unhandled error if it\nreceives fewer than 4 points whereas previously the limit was 3. This\nmakes no material difference to the behaviour of the tuning tool as it\nwill continue to search for the Macbeth chart at different scales.\n\nSigned-off-by: David Plowman <david.plowman@raspberrypi.com>\n---\n utils/raspberrypi/ctt/ctt_macbeth_locator.py | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/utils/raspberrypi/ctt/ctt_macbeth_locator.py b/utils/raspberrypi/ctt/ctt_macbeth_locator.py\nindex 35c84807..cae1d334 100644\n--- a/utils/raspberrypi/ctt/ctt_macbeth_locator.py\n+++ b/utils/raspberrypi/ctt/ctt_macbeth_locator.py\n@@ -597,10 +597,10 @@ def get_macbeth_chart(img, ref_data):\n ref_cents.append(ref_cent)\n \n \"\"\"\n- At least three squares need to have voted for a centre in\n+ At least four squares need to have voted for a centre in\n order for a transform to be found\n \"\"\"\n- if len(sq_cents) < 3:\n+ if len(sq_cents) < 4:\n raise MacbethError(\n '\\nWARNING: No macbeth chart found!'\n '\\nNot enough squares found'\n", "prefixes": [ "libcamera-devel", "2/3" ] }