Patch Detail
Show a patch.
GET /api/patches/13061/?format=api
{ "id": 13061, "url": "https://patchwork.libcamera.org/api/patches/13061/?format=api", "web_url": "https://patchwork.libcamera.org/patch/13061/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210720160034.233363-1-vedantparanjape160201@gmail.com>", "date": "2021-07-20T16:00:34", "name": "[libcamera-devel,v4] gstreamer: Store group_id in GstLibcameraSrcState", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "479d8dcb6e79415e7ee9b4463b7c01da23ba7987", "submitter": { "id": 85, "url": "https://patchwork.libcamera.org/api/people/85/?format=api", "name": "Vedant Paranjape", "email": "vedantparanjape160201@gmail.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/13061/mbox/", "series": [ { "id": 2261, "url": "https://patchwork.libcamera.org/api/series/2261/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2261", "date": "2021-07-20T16:00:34", "name": "[libcamera-devel,v4] gstreamer: Store group_id in GstLibcameraSrcState", "version": 4, "mbox": "https://patchwork.libcamera.org/series/2261/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/13061/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/13061/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B8F14C322B\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 20 Jul 2021 16:00:55 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DB5736852A;\n\tTue, 20 Jul 2021 18:00:54 +0200 (CEST)", "from mail-pf1-x42f.google.com (mail-pf1-x42f.google.com\n\t[IPv6:2607:f8b0:4864:20::42f])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5A64B68521\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 20 Jul 2021 18:00:53 +0200 (CEST)", "by mail-pf1-x42f.google.com with SMTP id d12so19966025pfj.2\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 20 Jul 2021 09:00:53 -0700 (PDT)", "from localhost.localdomain ([1.186.165.221])\n\tby smtp.googlemail.com with ESMTPSA id\n\tu16sm27018010pgh.53.2021.07.20.09.00.49\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 20 Jul 2021 09:00:50 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"UINU/V9P\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=uxLXfe0QPpmC7ilWCQ31eA3NGCZI5Yd/zRFYfCPaTyg=;\n\tb=UINU/V9P3jakR/s3v89sbqaPttApzS9536pdz2Bhow3iZpJemccC9sX4MJ+l3G5HCy\n\tjRV8UOkBVWwc4GZUpaFQ5tKmbPa5t6bIWZVwxBaiUSOpIaCx9LBCPQUYK9TZSo65TzL6\n\tGLMp1cMF37NkteCnHdz0fNkaL6ruihC3f1SwT2qs6jjAd/luV5pwSbnJaFjdD/7k9Tvc\n\tZI+kb+0vjyiBZjyquWnX0kkaNHyUEgpixeJYEwIdzRgZ02cHAIMGBgvLyLFhLxQY1OaX\n\t/VM56pOADD4DZtZ4V2ow0ZmjV4C5T0qCm5+ZLhC7TOGWekiwmoO58uCfms8XvTClA25K\n\thFhw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=uxLXfe0QPpmC7ilWCQ31eA3NGCZI5Yd/zRFYfCPaTyg=;\n\tb=ArtjwSvnPlzEy5eY5xVIGVcjdH1vYa0dvorHjbjGEF7hoN69nNSuRbEb5dxi91KuR0\n\tk3zr5YB2l/CLoU2A0lBD4fyx20ovzkuPqWKEZzM9+Mt0B2f09WRpxOkJORGGdRwHPNCd\n\tLWnVDS/fItOEfkqgUC/tUoIDGU9RjLP1Fe7kt0RoUYYqNiN0qmImhTlsLUCQJWIszQB8\n\t4TFHo4JVbNMvwlkldL4LKr0iMZnRgiTIaTszT2NDbS9YcF0V0WgImHvjHawL9uglXkp6\n\txWmc53FpWqx4NVdMPbxWZQX4SdrHcyKdD2sBDuF/pZbB8HoVZT0vBz2JqC7mOLe9TFtT\n\tcDSw==", "X-Gm-Message-State": "AOAM532BkYdZTu840wFEJNdDgTACIvMAKRnFOMGrbUv7YbP45Lvf9tmE\n\tcY2k22g2SaJ+/IhE2aenGHLHL/VwLIxf5g==", "X-Google-Smtp-Source": "ABdhPJwMN9aAoaekiSazAg1de0IVLsBuKVBtXOOvck2SOWdMwugfE/piFeAlez5v8EP3Q4eVRUaDyg==", "X-Received": "by 2002:a63:1d47:: with SMTP id d7mr19756391pgm.44.1626796851294;\n\tTue, 20 Jul 2021 09:00:51 -0700 (PDT)", "From": "Vedant Paranjape <vedantparanjape160201@gmail.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 20 Jul 2021 21:30:34 +0530", "Message-Id": "<20210720160034.233363-1-vedantparanjape160201@gmail.com>", "X-Mailer": "git-send-email 2.25.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v4] gstreamer: Store group_id in\n\tGstLibcameraSrcState", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Cc": "Vedant Paranjape <vedantparanjape160201@gmail.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "This patch adds group_id in GstLibcameraSrcState, since group_id is\nsomething which should be same for all the pads, it can be reused\nlater.\n\nSigned-off-by: Vedant Paranjape <vedantparanjape160201@gmail.com>\n---\n src/gstreamer/gstlibcamerasrc.cpp | 7 ++++---\n 1 file changed, 4 insertions(+), 3 deletions(-)", "diff": "diff --git a/src/gstreamer/gstlibcamerasrc.cpp b/src/gstreamer/gstlibcamerasrc.cpp\nindex ea53c2b5..b18f1efb 100644\n--- a/src/gstreamer/gstlibcamerasrc.cpp\n+++ b/src/gstreamer/gstlibcamerasrc.cpp\n@@ -113,6 +113,7 @@ struct GstLibcameraSrcState {\n \tstd::unique_ptr<CameraConfiguration> config_;\n \tstd::vector<GstPad *> srcpads_;\n \tstd::queue<std::unique_ptr<RequestWrap>> requests_;\n+\tguint group_id_;\n \n \tvoid requestCompleted(Request *request);\n };\n@@ -360,15 +361,14 @@ gst_libcamera_src_task_enter(GstTask *task, [[maybe_unused]] GThread *thread,\n \n \tGST_DEBUG_OBJECT(self, \"Streaming thread has started\");\n \n-\tguint group_id = gst_util_group_id_next();\n \tgint stream_id_num = 0;\n \tStreamRoles roles;\n \tfor (GstPad *srcpad : state->srcpads_) {\n \t\t/* Create stream-id and push stream-start. */\n-\t\tg_autofree gchar *stream_id_intermediate = g_strdup_printf(\"%i%i\", group_id, stream_id_num++);\n+\t\tg_autofree gchar *stream_id_intermediate = g_strdup_printf(\"%i%i\", state->group_id_, stream_id_num++);\n \t\tg_autofree gchar *stream_id = gst_pad_create_stream_id(srcpad, GST_ELEMENT(self), stream_id_intermediate);\n \t\tGstEvent *event = gst_event_new_stream_start(stream_id);\n-\t\tgst_event_set_group_id(event, group_id);\n+\t\tgst_event_set_group_id(event, state->group_id_);\n \t\tgst_pad_push_event(srcpad, event);\n \n \t\t/* Collect the streams roles for the next iteration. */\n@@ -578,6 +578,7 @@ gst_libcamera_src_change_state(GstElement *element, GstStateChange transition)\n \t\tbreak;\n \tcase GST_STATE_CHANGE_READY_TO_PAUSED:\n \t\t/* This needs to be called after pads activation.*/\n+\t\tself->state->group_id_ = gst_util_group_id_next();\n \t\tif (!gst_task_pause(self->task))\n \t\t\treturn GST_STATE_CHANGE_FAILURE;\n \t\tret = GST_STATE_CHANGE_NO_PREROLL;\n", "prefixes": [ "libcamera-devel", "v4" ] }