Patch Detail
Show a patch.
GET /api/patches/13034/?format=api
{ "id": 13034, "url": "https://patchwork.libcamera.org/api/patches/13034/?format=api", "web_url": "https://patchwork.libcamera.org/patch/13034/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210717190233.763047-1-vedantparanjape160201@gmail.com>", "date": "2021-07-17T19:02:33", "name": "[libcamera-devel,v2] gstreamer: Store group_id in GstLibcameraSrcState", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "af1fc715cf4b17ea37050637640a66cde50bfe9f", "submitter": { "id": 85, "url": "https://patchwork.libcamera.org/api/people/85/?format=api", "name": "Vedant Paranjape", "email": "vedantparanjape160201@gmail.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/13034/mbox/", "series": [ { "id": 2249, "url": "https://patchwork.libcamera.org/api/series/2249/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2249", "date": "2021-07-17T19:02:33", "name": "[libcamera-devel,v2] gstreamer: Store group_id in GstLibcameraSrcState", "version": 2, "mbox": "https://patchwork.libcamera.org/series/2249/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/13034/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/13034/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4A5FEC3228\n\tfor <parsemail@patchwork.libcamera.org>;\n\tSat, 17 Jul 2021 19:02:51 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B99A768516;\n\tSat, 17 Jul 2021 21:02:50 +0200 (CEST)", "from mail-pj1-x102d.google.com (mail-pj1-x102d.google.com\n\t[IPv6:2607:f8b0:4864:20::102d])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id EB9736027B\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat, 17 Jul 2021 21:02:49 +0200 (CEST)", "by mail-pj1-x102d.google.com with SMTP id my10so8593731pjb.1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat, 17 Jul 2021 12:02:49 -0700 (PDT)", "from localhost.localdomain ([1.186.166.91])\n\tby smtp.googlemail.com with ESMTPSA id\n\ti18sm13938760pgb.83.2021.07.17.12.02.45\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tSat, 17 Jul 2021 12:02:47 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"iRfWRDjz\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=nRScZUmwQF9yc1tIAAzNl3v2hRGKbIpJWJXorRXNlIE=;\n\tb=iRfWRDjzzEt+TXQqzrQiWilNQlpBn2LvZGlGHOm9wkrefwCsgsyjd1bwXBAlzc9mw6\n\tgUadyfrgmXxQlrJwuAZetx6vjsTaHJ+DVgUiu/8fCd4epBGtAEFX99mrbJYj3dcyJFED\n\tGZ18AgNLBbzrYMnwkkQoMesBJFEhR6vxbXsAdlw6qraiX5ePMNRC2adHd58QS5kdfhB7\n\tJvndVIdosUoF+3xXTnupgLmL7MrhMW6xd4PVpc6FECMhiVTKWBajvhO7ADG7K42Rsb7E\n\tU+NJ7KG86YhMpyJmI3c/YFA+po4bFRM36Z/wEb5kzaIdBqj5klN86Ox8T+gkHfzUyHeo\n\t36Ig==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=nRScZUmwQF9yc1tIAAzNl3v2hRGKbIpJWJXorRXNlIE=;\n\tb=FSTn7n9PD5uk6Zc3Sytg2yhpq3eUXdDgUJCa2yDSGo2s7aTjiHZWG77JWujez5Q84k\n\tqaJx7gAA7WWiXcJoYigaF5+UWbSRfw34EoZAkPSNO0+j8KDn0bba9CQy2FbQqkV6JLLW\n\thHRWtAmkfQHYSdZniqbOj5pqoD4w0QQQ6tl0Z5y04RjDFMTL/hcHP5aRYbqwpnunabw2\n\tAij39hfJdTPqeOcPg2z47aZxA32ARTRyXMzUUNbN2p2Mq5qNZwEwHPDJZX5icIc58o8W\n\tcYV/SwcXmHAue3h7wuQJ/vPPPNcJLVtyV9Ua543UwJt9RivMrInYppPJdqgOnPmdX/GD\n\tJSCw==", "X-Gm-Message-State": "AOAM530tvqXgyFZdLZsHcs+7MeGRCX1o4Uc9t/XjCVDczG/3ggdq8BEf\n\tjJL1DJfVzqyaz/F7z3iFBSmCU3WKxIJOYIiB", "X-Google-Smtp-Source": "ABdhPJzgM6si7eHsCB1ZA2vPZ6MALsomRFc4Qu1ApxA5bcfZNSa1uTijFP/wqta9KZipyHySy3dO1w==", "X-Received": "by 2002:a17:902:c402:b029:12b:229:f4a with SMTP id\n\tk2-20020a170902c402b029012b02290f4amr12834923plk.54.1626548567882; \n\tSat, 17 Jul 2021 12:02:47 -0700 (PDT)", "From": "Vedant Paranjape <vedantparanjape160201@gmail.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Sun, 18 Jul 2021 00:32:33 +0530", "Message-Id": "<20210717190233.763047-1-vedantparanjape160201@gmail.com>", "X-Mailer": "git-send-email 2.25.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v2] gstreamer: Store group_id in\n\tGstLibcameraSrcState", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Cc": "Vedant Paranjape <vedantparanjape160201@gmail.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "This patch adds group_id in GstLibcameraSrcState, since group_id is\nsomething which should be same for all the pads, it can be reused\nlater.\n\nSigned-off-by: Vedant Paranjape <vedantparanjape160201@gmail.com>\n---\n src/gstreamer/gstlibcamerasrc.cpp | 10 +++++++---\n 1 file changed, 7 insertions(+), 3 deletions(-)", "diff": "diff --git a/src/gstreamer/gstlibcamerasrc.cpp b/src/gstreamer/gstlibcamerasrc.cpp\nindex ea53c2b5..79b0d867 100644\n--- a/src/gstreamer/gstlibcamerasrc.cpp\n+++ b/src/gstreamer/gstlibcamerasrc.cpp\n@@ -113,6 +113,7 @@ struct GstLibcameraSrcState {\n \tstd::unique_ptr<CameraConfiguration> config_;\n \tstd::vector<GstPad *> srcpads_;\n \tstd::queue<std::unique_ptr<RequestWrap>> requests_;\n+\tguint group_id_;\n \n \tvoid requestCompleted(Request *request);\n };\n@@ -360,15 +361,17 @@ gst_libcamera_src_task_enter(GstTask *task, [[maybe_unused]] GThread *thread,\n \n \tGST_DEBUG_OBJECT(self, \"Streaming thread has started\");\n \n-\tguint group_id = gst_util_group_id_next();\n+\tif (state->group_id_ == 0) {\n+\t\tstate->group_id_ = gst_util_group_id_next();\n+\t}\n \tgint stream_id_num = 0;\n \tStreamRoles roles;\n \tfor (GstPad *srcpad : state->srcpads_) {\n \t\t/* Create stream-id and push stream-start. */\n-\t\tg_autofree gchar *stream_id_intermediate = g_strdup_printf(\"%i%i\", group_id, stream_id_num++);\n+\t\tg_autofree gchar *stream_id_intermediate = g_strdup_printf(\"%i%i\", state->group_id_, stream_id_num++);\n \t\tg_autofree gchar *stream_id = gst_pad_create_stream_id(srcpad, GST_ELEMENT(self), stream_id_intermediate);\n \t\tGstEvent *event = gst_event_new_stream_start(stream_id);\n-\t\tgst_event_set_group_id(event, group_id);\n+\t\tgst_event_set_group_id(event, state->group_id_);\n \t\tgst_pad_push_event(srcpad, event);\n \n \t\t/* Collect the streams roles for the next iteration. */\n@@ -636,6 +639,7 @@ gst_libcamera_src_init(GstLibcameraSrc *self)\n \n \tstate->srcpads_.push_back(gst_pad_new_from_template(templ, \"src\"));\n \tgst_element_add_pad(GST_ELEMENT(self), state->srcpads_[0]);\n+\tstate->group_id_ = 0;\n \n \t/* C-style friend. */\n \tstate->src_ = self;\n", "prefixes": [ "libcamera-devel", "v2" ] }