Patch Detail
Show a patch.
GET /api/patches/13020/?format=api
{ "id": 13020, "url": "https://patchwork.libcamera.org/api/patches/13020/?format=api", "web_url": "https://patchwork.libcamera.org/patch/13020/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210716105631.158153-15-paul.elder@ideasonboard.com>", "date": "2021-07-16T10:56:24", "name": "[libcamera-devel,RFC,v4,14/21] android: Plumb AeLock control", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "907dc2e0fd690bda3423c5477db6385246d84bfa", "submitter": { "id": 17, "url": "https://patchwork.libcamera.org/api/people/17/?format=api", "name": "Paul Elder", "email": "paul.elder@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/13020/mbox/", "series": [ { "id": 2244, "url": "https://patchwork.libcamera.org/api/series/2244/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2244", "date": "2021-07-16T10:56:10", "name": "Preliminary FULL plumbing", "version": 4, "mbox": "https://patchwork.libcamera.org/series/2244/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/13020/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/13020/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7C1E6C3228\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 16 Jul 2021 10:57:20 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 35D8668542;\n\tFri, 16 Jul 2021 12:57:20 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id F1BD968545\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 16 Jul 2021 12:57:17 +0200 (CEST)", "from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 78D023F0;\n\tFri, 16 Jul 2021 12:57:16 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"tK1MHHH0\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1626433037;\n\tbh=kQNOmt7D2sHNsqsTtwPW/dV4KEhFjMPAOUTCQBJ0j0g=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=tK1MHHH0RsPw8d/4K1cONjOae5nxIbvnkm37HMB6pt2k0147noxSGrbsYky07TmWD\n\tUEi1dFXypzn6HoBbu3WVpzhEmgx0O0RHEw7owu9SGCZuUCO8XERf1YwdUB5jF8xTAk\n\tny/kc5hEsa9nr/IfCyeaL1XSqbY4lQNXR2TIKBy4=", "From": "Paul Elder <paul.elder@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 16 Jul 2021 19:56:24 +0900", "Message-Id": "<20210716105631.158153-15-paul.elder@ideasonboard.com>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20210716105631.158153-1-paul.elder@ideasonboard.com>", "References": "<20210716105631.158153-1-paul.elder@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [RFC PATCH v4 14/21] android: Plumb AeLock control", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Plumb the AeLock control into the HAL for\nCONTROL_AE_LOCK_AVAILABLE_MODES for static metadata.\n\nBug: https://bugs.libcamera.org/show_bug.cgi?id=43\nSigned-off-by: Paul Elder <paul.elder@ideasonboard.com>\n\nTODO: check templates\n\n---\nChanges in v4:\n- remove capability check\n- plumb into processControls\n\nChanges in v3:\n- use new setMetadata\n- rebase on camera capabilities refactor\n---\n src/android/camera_capabilities.cpp | 9 ++++++---\n src/android/camera_device.cpp | 11 ++++++++---\n 2 files changed, 14 insertions(+), 6 deletions(-)", "diff": "diff --git a/src/android/camera_capabilities.cpp b/src/android/camera_capabilities.cpp\nindex fe81c665..ac3d88b5 100644\n--- a/src/android/camera_capabilities.cpp\n+++ b/src/android/camera_capabilities.cpp\n@@ -934,9 +934,12 @@ int CameraCapabilities::initializeStaticMetadata()\n \tstaticMetadata_->addEntry(ANDROID_CONTROL_SCENE_MODE_OVERRIDES,\n \t\t\t\t sceneModesOverride);\n \n-\tuint8_t aeLockAvailable = ANDROID_CONTROL_AE_LOCK_AVAILABLE_FALSE;\n-\tstaticMetadata_->addEntry(ANDROID_CONTROL_AE_LOCK_AVAILABLE,\n-\t\t\t\t aeLockAvailable);\n+\tsetMetadata<uint8_t, bool>(\n+\t\tstaticMetadata_.get(),\n+\t\tANDROID_CONTROL_AE_LOCK_AVAILABLE,\n+\t\tcontrolsInfo, &controls::AeLock,\n+\t\tControlRange::Max,\n+\t\tANDROID_CONTROL_AE_LOCK_AVAILABLE_FALSE);\n \n \tuint8_t awbLockAvailable = ANDROID_CONTROL_AWB_LOCK_AVAILABLE_FALSE;\n \tstaticMetadata_->addEntry(ANDROID_CONTROL_AWB_LOCK_AVAILABLE,\ndiff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\nindex 98a73b37..1721e0e8 100644\n--- a/src/android/camera_device.cpp\n+++ b/src/android/camera_device.cpp\n@@ -784,6 +784,9 @@ int CameraDevice::processControls(Camera3RequestDescriptor *descriptor)\n \tif (settings.getEntry(ANDROID_CONTROL_AE_MODE, &entry))\n \t\tcontrols.set(controls::AeEnable, *entry.data.u8);\n \n+\tif (settings.getEntry(ANDROID_CONTROL_AE_LOCK, &entry))\n+\t\tcontrols.set(controls::AeLock, *entry.data.u8);\n+\n \treturn 0;\n }\n \n@@ -1205,14 +1208,16 @@ CameraDevice::getResultMetadata(const Camera3RequestDescriptor &descriptor) cons\n \tresultMetadata->addEntry(ANDROID_CONTROL_AE_EXPOSURE_COMPENSATION,\n \t\t\t\t value32);\n \n-\tvalue = ANDROID_CONTROL_AE_LOCK_OFF;\n-\tresultMetadata->addEntry(ANDROID_CONTROL_AE_LOCK, value);\n-\n \tif (metadata.contains(controls::AeEnable)) {\n \t\tuint8_t aeMode = metadata.get<bool>(controls::AeEnable);\n \t\tresultMetadata->addEntry(ANDROID_CONTROL_AE_MODE, aeMode);\n \t}\n \n+\tif (metadata.contains(controls::AeLock)) {\n+\t\tuint8_t aeLock = metadata.get<bool>(controls::AeLock);\n+\t\tresultMetadata->addEntry(ANDROID_CONTROL_AE_LOCK, aeLock);\n+\t}\n+\n \tif (settings.getEntry(ANDROID_CONTROL_AE_TARGET_FPS_RANGE, &entry))\n \t\t/*\n \t\t * \\todo Retrieve the AE FPS range from the libcamera metadata.\n", "prefixes": [ "libcamera-devel", "RFC", "v4", "14/21" ] }