Patch Detail
Show a patch.
GET /api/patches/13019/?format=api
{ "id": 13019, "url": "https://patchwork.libcamera.org/api/patches/13019/?format=api", "web_url": "https://patchwork.libcamera.org/patch/13019/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210716105631.158153-14-paul.elder@ideasonboard.com>", "date": "2021-07-16T10:56:23", "name": "[libcamera-devel,RFC,v4,13/21] android: Plumb AeEnable control", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "4a4a1b59f4564a3800f6e3797a7eb575bf5906ac", "submitter": { "id": 17, "url": "https://patchwork.libcamera.org/api/people/17/?format=api", "name": "Paul Elder", "email": "paul.elder@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/13019/mbox/", "series": [ { "id": 2244, "url": "https://patchwork.libcamera.org/api/series/2244/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2244", "date": "2021-07-16T10:56:10", "name": "Preliminary FULL plumbing", "version": 4, "mbox": "https://patchwork.libcamera.org/series/2244/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/13019/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/13019/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 014B4C3228\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 16 Jul 2021 10:57:18 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id ACC706853D;\n\tFri, 16 Jul 2021 12:57:17 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1E4A468521\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 16 Jul 2021 12:57:16 +0200 (CEST)", "from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9F36156B;\n\tFri, 16 Jul 2021 12:57:14 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"j9RGkvMK\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1626433035;\n\tbh=hVBLf9PxXZp7r73j9Bc4DcNsQ6C91IrmgB6P3Nlg+RQ=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=j9RGkvMKVSmU++dPpa9Js23XiwGJzcAqTWRbazOHHW7Cootke8nlLkb8QeO0h8fBs\n\tcMIG1cxDMQ7DKzCT8e6cO3idSGxEIQOCoN2f2KwkDSWF+b3Pob1/LeILWB45qBQUr+\n\tncRiJcSRKZzte1Kh1r+gcIsly/ndr9ydjSguHAEM=", "From": "Paul Elder <paul.elder@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 16 Jul 2021 19:56:23 +0900", "Message-Id": "<20210716105631.158153-14-paul.elder@ideasonboard.com>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20210716105631.158153-1-paul.elder@ideasonboard.com>", "References": "<20210716105631.158153-1-paul.elder@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [RFC PATCH v4 13/21] android: Plumb AeEnable\n\tcontrol", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Plumb the AeEnable control into the HAL for CONTROL_AE_AVAILABLE_MODES\nfor static metadata, and CONTROL_AE_MODE for result metadata.\n\nBug: https://bugs.libcamera.org/show_bug.cgi?id=42\nSigned-off-by: Paul Elder <paul.elder@ideasonboard.com>\n\nTODO: check templates\n\n---\nChanges in v4:\n- remove capability check\n- plumb into processControls\n\nChanges in v3\n- use new setMetadata\n- rebase on camera capabilities refactor\n---\n src/android/camera_capabilities.cpp | 10 +++++-----\n src/android/camera_device.cpp | 9 +++++++--\n 2 files changed, 12 insertions(+), 7 deletions(-)", "diff": "diff --git a/src/android/camera_capabilities.cpp b/src/android/camera_capabilities.cpp\nindex c333b329..fe81c665 100644\n--- a/src/android/camera_capabilities.cpp\n+++ b/src/android/camera_capabilities.cpp\n@@ -818,11 +818,11 @@ int CameraCapabilities::initializeStaticMetadata()\n \tstaticMetadata_->addEntry(ANDROID_CONTROL_AE_AVAILABLE_ANTIBANDING_MODES,\n \t\t\t\t aeAvailableAntiBandingModes);\n \n-\tstd::vector<uint8_t> aeAvailableModes = {\n-\t\tANDROID_CONTROL_AE_MODE_ON,\n-\t};\n-\tstaticMetadata_->addEntry(ANDROID_CONTROL_AE_AVAILABLE_MODES,\n-\t\t\t\t aeAvailableModes);\n+\tsetMetadata<uint8_t, bool>(\n+\t\tstaticMetadata_.get(),\n+\t\tANDROID_CONTROL_AE_AVAILABLE_MODES,\n+\t\tcontrolsInfo, &controls::AeEnable,\n+\t\t{ ANDROID_CONTROL_AE_MODE_ON });\n \n \tint64_t minFrameDurationNsec = -1;\n \tint64_t maxFrameDurationNsec = -1;\ndiff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\nindex 692d0a5b..98a73b37 100644\n--- a/src/android/camera_device.cpp\n+++ b/src/android/camera_device.cpp\n@@ -781,6 +781,9 @@ int CameraDevice::processControls(Camera3RequestDescriptor *descriptor)\n \t\tcontrols.set(controls::ScalerCrop, cropRegion);\n \t}\n \n+\tif (settings.getEntry(ANDROID_CONTROL_AE_MODE, &entry))\n+\t\tcontrols.set(controls::AeEnable, *entry.data.u8);\n+\n \treturn 0;\n }\n \n@@ -1205,8 +1208,10 @@ CameraDevice::getResultMetadata(const Camera3RequestDescriptor &descriptor) cons\n \tvalue = ANDROID_CONTROL_AE_LOCK_OFF;\n \tresultMetadata->addEntry(ANDROID_CONTROL_AE_LOCK, value);\n \n-\tvalue = ANDROID_CONTROL_AE_MODE_ON;\n-\tresultMetadata->addEntry(ANDROID_CONTROL_AE_MODE, value);\n+\tif (metadata.contains(controls::AeEnable)) {\n+\t\tuint8_t aeMode = metadata.get<bool>(controls::AeEnable);\n+\t\tresultMetadata->addEntry(ANDROID_CONTROL_AE_MODE, aeMode);\n+\t}\n \n \tif (settings.getEntry(ANDROID_CONTROL_AE_TARGET_FPS_RANGE, &entry))\n \t\t/*\n", "prefixes": [ "libcamera-devel", "RFC", "v4", "13/21" ] }