Patch Detail
Show a patch.
GET /api/patches/13015/?format=api
{ "id": 13015, "url": "https://patchwork.libcamera.org/api/patches/13015/?format=api", "web_url": "https://patchwork.libcamera.org/patch/13015/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210716105631.158153-10-paul.elder@ideasonboard.com>", "date": "2021-07-16T10:56:19", "name": "[libcamera-devel,RFC,v4,09/21] android, controls: Add and plumb MaxLatency control", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "ccdcb6582b009b103c0d4b4c8abd0c1775682419", "submitter": { "id": 17, "url": "https://patchwork.libcamera.org/api/people/17/?format=api", "name": "Paul Elder", "email": "paul.elder@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/13015/mbox/", "series": [ { "id": 2244, "url": "https://patchwork.libcamera.org/api/series/2244/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2244", "date": "2021-07-16T10:56:10", "name": "Preliminary FULL plumbing", "version": 4, "mbox": "https://patchwork.libcamera.org/series/2244/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/13015/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/13015/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BFB4EC3228\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 16 Jul 2021 10:57:11 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7F8386853B;\n\tFri, 16 Jul 2021 12:57:11 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A5ED36853A\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 16 Jul 2021 12:57:08 +0200 (CEST)", "from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id EEC8C3F0;\n\tFri, 16 Jul 2021 12:57:06 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"YVizAH5E\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1626433028;\n\tbh=JPhi8gsc1O9KCipSCk62rBUxQmfuxvdWJzFupeKUhTA=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=YVizAH5EYzRahkCy1DnXTcc7jv+E4t9ifvB8X/NJyaROcXJBiSx0CW8oDaDFxNtj8\n\t2fceC38vVkp09gRdrK3BDyunLG3/YBVElTZzag40l3IE64k5wOfEx6AajL0KwZ6QJ4\n\tIrvRtfKcMpH0w3JdsUaMX8NXXNBTIlihs0Gc8c8E=", "From": "Paul Elder <paul.elder@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 16 Jul 2021 19:56:19 +0900", "Message-Id": "<20210716105631.158153-10-paul.elder@ideasonboard.com>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20210716105631.158153-1-paul.elder@ideasonboard.com>", "References": "<20210716105631.158153-1-paul.elder@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [RFC PATCH v4 09/21] android,\n\tcontrols: Add and plumb MaxLatency control", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Add a MaxLatency control, and plumb it into the HAL accordingly.\n\nBug: https://bugs.libcamera.org/show_bug.cgi?id=50\nSigned-off-by: Paul Elder <paul.elder@ideasonboard.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\n---\nChanges in v3:\n- use v3 setMetadata\n- add comment to explain 4\n- remove todo\n\nChanges in v2:\n- use new setMetadata\n- rebase on camera capabilities refactor\n---\n src/android/camera_capabilities.cpp | 7 +++++--\n src/libcamera/control_ids.yaml | 10 ++++++++++\n 2 files changed, 15 insertions(+), 2 deletions(-)", "diff": "diff --git a/src/android/camera_capabilities.cpp b/src/android/camera_capabilities.cpp\nindex 21e31cf2..c333b329 100644\n--- a/src/android/camera_capabilities.cpp\n+++ b/src/android/camera_capabilities.cpp\n@@ -1127,8 +1127,11 @@ int CameraCapabilities::initializeStaticMetadata()\n \t}\n \n \t/* Sync static metadata. */\n-\tint32_t maxLatency = ANDROID_SYNC_MAX_LATENCY_UNKNOWN;\n-\tstaticMetadata_->addEntry(ANDROID_SYNC_MAX_LATENCY, maxLatency);\n+\tsetMetadata<int32_t, int32_t>(\n+\t\tstaticMetadata_.get(), ANDROID_SYNC_MAX_LATENCY,\n+\t\tcontrolsInfo, &controls::draft::MaxLatency,\n+\t\tControlRange::Def,\n+\t\tANDROID_SYNC_MAX_LATENCY_UNKNOWN);\n \n \t/* Flash static metadata. */\n \tchar flashAvailable = ANDROID_FLASH_INFO_AVAILABLE_FALSE;\ndiff --git a/src/libcamera/control_ids.yaml b/src/libcamera/control_ids.yaml\nindex d92f29f5..9d4638ae 100644\n--- a/src/libcamera/control_ids.yaml\n+++ b/src/libcamera/control_ids.yaml\n@@ -622,6 +622,16 @@ controls:\n detection, additional format conversions etc) count as an additional\n pipeline stage.\n \n+ - MaxLatency:\n+ type: int32_t\n+ draft: true\n+ description: |\n+ The maximum number of frames that can occur after a request (different\n+ than the previous) has been submitted, and before the result's state\n+ becomes synchronized. A value of -1 indicates unknown latency, and 0\n+ indicates per-frame control. Currently identical to\n+ ANDROID_SYNC_MAX_LATENCY.\n+\n - TestPatternMode:\n type: int32_t\n draft: true\n", "prefixes": [ "libcamera-devel", "RFC", "v4", "09/21" ] }