Patch Detail
Show a patch.
GET /api/patches/13010/?format=api
{ "id": 13010, "url": "https://patchwork.libcamera.org/api/patches/13010/?format=api", "web_url": "https://patchwork.libcamera.org/patch/13010/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210716105631.158153-5-paul.elder@ideasonboard.com>", "date": "2021-07-16T10:56:14", "name": "[libcamera-devel,RFC,v4,04/21] android: jpeg: get ISO from SENSOR_SENSITIVITY", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "2eddbcb00e08cb25a8a368e1721ee1c4297b33d1", "submitter": { "id": 17, "url": "https://patchwork.libcamera.org/api/people/17/?format=api", "name": "Paul Elder", "email": "paul.elder@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/13010/mbox/", "series": [ { "id": 2244, "url": "https://patchwork.libcamera.org/api/series/2244/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2244", "date": "2021-07-16T10:56:10", "name": "Preliminary FULL plumbing", "version": 4, "mbox": "https://patchwork.libcamera.org/series/2244/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/13010/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/13010/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7F412C3228\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 16 Jul 2021 10:57:00 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 33E4F68541;\n\tFri, 16 Jul 2021 12:57:00 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id ABC046853B\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 16 Jul 2021 12:56:58 +0200 (CEST)", "from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E5E2956B;\n\tFri, 16 Jul 2021 12:56:56 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"nCAzRkYr\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1626433018;\n\tbh=QhiD3FqC4kEpBOrnGngCJ3hXNccsIuDbK3ovrgFN/To=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=nCAzRkYr+y5fTjAvSdtwmjMlhO8Z6YKlMJoKh+NA7KMXItXM5poDrN1DBGKIiOZs6\n\tYsokFLT5bPJFFkLY22jC6bJkOmt4Ml07CWNSmOCQ/hn6AoJVgrFtT3xUWZ2lx5oPKv\n\ti4fgTc7JZyRU8/KZhZr7dmEUlPwnrcZ9pfTTpQO0=", "From": "Paul Elder <paul.elder@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 16 Jul 2021 19:56:14 +0900", "Message-Id": "<20210716105631.158153-5-paul.elder@ideasonboard.com>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20210716105631.158153-1-paul.elder@ideasonboard.com>", "References": "<20210716105631.158153-1-paul.elder@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [RFC PATCH v4 04/21] android: jpeg: get ISO from\n\tSENSOR_SENSITIVITY", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The data for the exif ISO tag needs to come from SENSOR_SENSITIVITY. Set\nit.\n\nSigned-off-by: Paul Elder <paul.elder@ideasonboard.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\n---\nThis on its own doesn't fix any CTS tests, but it prevents a test\nfailure later on when we add the proper static metadata for the FULL\nhardware level.\n---\n src/android/jpeg/post_processor_jpeg.cpp | 5 ++++-\n 1 file changed, 4 insertions(+), 1 deletion(-)", "diff": "diff --git a/src/android/jpeg/post_processor_jpeg.cpp b/src/android/jpeg/post_processor_jpeg.cpp\nindex 0e93f365..3160a784 100644\n--- a/src/android/jpeg/post_processor_jpeg.cpp\n+++ b/src/android/jpeg/post_processor_jpeg.cpp\n@@ -119,7 +119,10 @@ int PostProcessorJpeg::process(const FrameBuffer &source,\n \tret = requestMetadata.getEntry(ANDROID_LENS_APERTURE, &entry);\n \tif (ret)\n \t\texif.setAperture(*entry.data.f);\n-\texif.setISO(100);\n+\n+\tret = resultMetadata->getEntry(ANDROID_SENSOR_SENSITIVITY, &entry);\n+\texif.setISO(ret ? *entry.data.i32 : 100);\n+\n \texif.setFlash(Exif::Flash::FlashNotPresent);\n \texif.setWhiteBalance(Exif::WhiteBalance::Auto);\n \n", "prefixes": [ "libcamera-devel", "RFC", "v4", "04/21" ] }