Patch Detail
Show a patch.
GET /api/patches/13009/?format=api
{ "id": 13009, "url": "https://patchwork.libcamera.org/api/patches/13009/?format=api", "web_url": "https://patchwork.libcamera.org/patch/13009/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210716105631.158153-4-paul.elder@ideasonboard.com>", "date": "2021-07-16T10:56:13", "name": "[libcamera-devel,RFC,v4,03/21] android: metadata: Fix addEntry template type", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "bec8b54c3c8395217e7c85489efccea0831e047d", "submitter": { "id": 17, "url": "https://patchwork.libcamera.org/api/people/17/?format=api", "name": "Paul Elder", "email": "paul.elder@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/13009/mbox/", "series": [ { "id": 2244, "url": "https://patchwork.libcamera.org/api/series/2244/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2244", "date": "2021-07-16T10:56:10", "name": "Preliminary FULL plumbing", "version": 4, "mbox": "https://patchwork.libcamera.org/series/2244/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/13009/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/13009/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 042E1C3228\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 16 Jul 2021 10:56:58 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B113268536;\n\tFri, 16 Jul 2021 12:56:57 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 763F66853C\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 16 Jul 2021 12:56:56 +0200 (CEST)", "from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id EC1823F0;\n\tFri, 16 Jul 2021 12:56:54 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"tM2BrXek\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1626433016;\n\tbh=O53ICVJfXcqoRU0MXQ6spCMHh3xxHMWwYTqpQcKJo4Q=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=tM2BrXekOXhYpa3lk5pnTjlLyUjQreX8e8gvp2mh1Zc42pXLZJcbIUszMv/AO89k5\n\tajROFqUheIhnionuMVIGFE1vaNb1shPQhueGDzPEUGF4X+T8XVlzzY0m37ncCJS6uU\n\tHvsxmWUpMZbnizS+ovytccQtAWSbbpWOdSGtQ8zo=", "From": "Paul Elder <paul.elder@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 16 Jul 2021 19:56:13 +0900", "Message-Id": "<20210716105631.158153-4-paul.elder@ideasonboard.com>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20210716105631.158153-1-paul.elder@ideasonboard.com>", "References": "<20210716105631.158153-1-paul.elder@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [RFC PATCH v4 03/21] android: metadata: Fix\n\taddEntry template type", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Since we set entries with android tags directly, which are enums and not\narithmetic types, the addEntry template fails to match. Fix this by also\nallowing enum values in addEntry.\n\nSigned-off-by: Paul Elder <paul.elder@ideasonboard.com>\n\n---\nNew in v4\n---\n src/android/camera_metadata.h | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)", "diff": "diff --git a/src/android/camera_metadata.h b/src/android/camera_metadata.h\nindex 03b3e701..60be416c 100644\n--- a/src/android/camera_metadata.h\n+++ b/src/android/camera_metadata.h\n@@ -34,7 +34,8 @@ public:\n \tbool hasEntry(uint32_t tag) const;\n \n \ttemplate<typename T,\n-\t\t std::enable_if_t<std::is_arithmetic_v<T>> * = nullptr>\n+\t\t std::enable_if_t<std::is_arithmetic_v<T> ||\n+\t\t\t\t std::is_enum_v<T>> * = nullptr>\n \tbool addEntry(uint32_t tag, const T &data)\n \t{\n \t\treturn addEntry(tag, &data, 1, sizeof(T));\n", "prefixes": [ "libcamera-devel", "RFC", "v4", "03/21" ] }