Patch Detail
Show a patch.
GET /api/patches/12977/?format=api
{ "id": 12977, "url": "https://patchwork.libcamera.org/api/patches/12977/?format=api", "web_url": "https://patchwork.libcamera.org/patch/12977/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210715211459.19373-7-laurent.pinchart@ideasonboard.com>", "date": "2021-07-15T21:14:32", "name": "[libcamera-devel,v3,06/33] cam: options: Slit OptionsParser::usage() in two functions", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "c9c707c528450645dcaa5b2f1fc544d72e2a06a9", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/12977/mbox/", "series": [ { "id": 2242, "url": "https://patchwork.libcamera.org/api/series/2242/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2242", "date": "2021-07-15T21:14:26", "name": "Multi-camera support in the cam application", "version": 3, "mbox": "https://patchwork.libcamera.org/series/2242/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/12977/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/12977/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BA742C3226\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 15 Jul 2021 21:15:17 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 141266853F;\n\tThu, 15 Jul 2021 23:15:13 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 87A2868543\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 15 Jul 2021 23:15:06 +0200 (CEST)", "from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 21D2E340\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 15 Jul 2021 23:15:06 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"WY4LpPg+\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1626383706;\n\tbh=B9fjfrSkPUoFdIP3KHkYWUVgzaDolzIhMIlVMa91eRI=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=WY4LpPg+E0/TiqlSsW9U/w2oz21oH6H0WUj4BBh4OAhtzadqRd5DlNdE7W3VuOUCm\n\t6A9yUOSAn0omSZ9PrHihAlzmESX/2C15zYJSbk2/LG9ZYSqOt8ZMWL/rswsv69avAf\n\t8Eyt9BgUScvBuCHYaBW5hBdC78PBmZt4GnH7yCHA=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 16 Jul 2021 00:14:32 +0300", "Message-Id": "<20210715211459.19373-7-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.31.1", "In-Reply-To": "<20210715211459.19373-1-laurent.pinchart@ideasonboard.com>", "References": "<20210715211459.19373-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v3 06/33] cam: options: Slit\n\tOptionsParser::usage() in two functions", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "To prepare for code reuse, split the printing of options out of\nOptionsParser::usage() to a separate function.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n src/cam/options.cpp | 12 +++++++++---\n src/cam/options.h | 2 ++\n 2 files changed, 11 insertions(+), 3 deletions(-)", "diff": "diff --git a/src/cam/options.cpp b/src/cam/options.cpp\nindex 721a808ac859..350c8084f75f 100644\n--- a/src/cam/options.cpp\n+++ b/src/cam/options.cpp\n@@ -902,8 +902,6 @@ OptionsParser::Options OptionsParser::parse(int argc, char **argv)\n */\n void OptionsParser::usage()\n {\n-\tstd::cerr << \"Options:\" << std::endl;\n-\n \tunsigned int indent = 0;\n \n \tfor (const Option &option : options_) {\n@@ -923,7 +921,15 @@ void OptionsParser::usage()\n \n \tindent = (indent + 7) / 8 * 8;\n \n-\tfor (const Option &option : options_) {\n+\tstd::cerr << \"Options:\" << std::endl;\n+\n+\tusageOptions(options_, indent);\n+}\n+\n+void OptionsParser::usageOptions(const std::list<Option> &options,\n+\t\t\t\t unsigned int indent)\n+{\n+\tfor (const Option &option : options) {\n \t\tstd::string argument;\n \t\tif (option.hasShortOption())\n \t\t\targument = std::string(\" -\")\ndiff --git a/src/cam/options.h b/src/cam/options.h\nindex 0b8bb172d184..01a5d36a63fb 100644\n--- a/src/cam/options.h\n+++ b/src/cam/options.h\n@@ -95,6 +95,8 @@ public:\n \tvoid usage();\n \n private:\n+\tvoid usageOptions(const std::list<Option> &options, unsigned int indent);\n+\n \tstd::list<Option> options_;\n \tstd::map<unsigned int, Option *> optionsMap_;\n };\n", "prefixes": [ "libcamera-devel", "v3", "06/33" ] }