Patch Detail
Show a patch.
GET /api/patches/12970/?format=api
{ "id": 12970, "url": "https://patchwork.libcamera.org/api/patches/12970/?format=api", "web_url": "https://patchwork.libcamera.org/patch/12970/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210715204617.20140-2-vedantparanjape160201@gmail.com>", "date": "2021-07-15T20:46:17", "name": "[libcamera-devel,v3,2/2] libcamera: Add pixel format BGRX8888", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "fa58de41c3737bf6639fb6fb3ff460e1d725fb06", "submitter": { "id": 85, "url": "https://patchwork.libcamera.org/api/people/85/?format=api", "name": "Vedant Paranjape", "email": "vedantparanjape160201@gmail.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/12970/mbox/", "series": [ { "id": 2241, "url": "https://patchwork.libcamera.org/api/series/2241/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2241", "date": "2021-07-15T20:46:16", "name": "[libcamera-devel,v3,1/2] libcamera: Fix the V4L2 pixel format for formats::XBGR8888", "version": 3, "mbox": "https://patchwork.libcamera.org/series/2241/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/12970/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/12970/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B5F99C3225\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 15 Jul 2021 20:46:47 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 710DD6852A;\n\tThu, 15 Jul 2021 22:46:47 +0200 (CEST)", "from mail-pj1-x1036.google.com (mail-pj1-x1036.google.com\n\t[IPv6:2607:f8b0:4864:20::1036])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7366B6059F\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 15 Jul 2021 22:46:46 +0200 (CEST)", "by mail-pj1-x1036.google.com with SMTP id bt15so4962409pjb.2\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 15 Jul 2021 13:46:46 -0700 (PDT)", "from localhost.localdomain ([1.186.167.37])\n\tby smtp.googlemail.com with ESMTPSA id\n\tc12sm7545796pfl.27.2021.07.15.13.46.42\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 15 Jul 2021 13:46:44 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"ucSHL4ke\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=79q8nTRra8BB2hCmCIawmyGF4lHQ73LVIqBfkVcd7fE=;\n\tb=ucSHL4keJqBIOrzZ12iE8QC/fm7bvSA9BUEunRsmEF3+pvoHc8oKPqOjUxdsoH2s94\n\t2W+ZPcaKXh1WYpBe70p7NiT6TyRlSPpGYcEtc+x/cBkWsB7vt2h6crtx6uYIBm0lhlxJ\n\tuyY+ID1iLU99q4+Q5hkf/LwjSZb2eppFjX67LcFBrJ3JacH/blk/wkpKjdNAft39Tcbt\n\tPqJNPVjyuDCiiQn7silpNhJNuekqMilPmhyIy+M6bw0iDCcYzEwxaGlkXko0pXWMPRTS\n\t4RQ4Q5oR+Tu3IVhLqlVWbruaS3bNcIKaPG9BDWEdXzI2+BtSbcq91K4Sv4pr2YVVQsGt\n\t5N+g==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=79q8nTRra8BB2hCmCIawmyGF4lHQ73LVIqBfkVcd7fE=;\n\tb=jY0SSET8IXA/FK/kEDs3WCAg0NeCrcTGPn/xs517A474VI0PkepbKEX5xVqy3lHraA\n\tUQeFBT8bCUtLHMz/6M0zIUUUOvuIuxIvaYc1iugR5Yhpt/O5oytkDGQGcqTMdOo9mrXs\n\tpxlgBjglxl2x1OtN2huLLiehba8pfMgR7sRSXEtMyj4vclq/5jly+4mtiKwInazbWxh+\n\td9Ip0YyHS+pUKN7321Yd+5HSV/CIlpSfqI4Kz/AsHl5SLFRAn5Udrru46m1PorkwsWyp\n\t175seOGrpI4aWb3ATIW8LdHfuGqbJ1Lria6dZZYI0BgYR6I49oTeQBJTBli3TEQz1z0i\n\tq55A==", "X-Gm-Message-State": "AOAM533HvTYjvnPehvVCyAozcUL0izEZyyGS7c/DAFK7+bIcE4VBUkgV\n\tB0cy561ttOcAbi5E2D64bsRlIoqWNuk587biN7Y=", "X-Google-Smtp-Source": "ABdhPJzCwCb0sE6Hu5Seryy4mxVmLs0Df21ozmMf+1iW7ypfnhfsekl082OKbla+PfLMrTXMb4oAmw==", "X-Received": "by 2002:a17:90a:8e82:: with SMTP id\n\tf2mr12153559pjo.177.1626382004846; \n\tThu, 15 Jul 2021 13:46:44 -0700 (PDT)", "From": "Vedant Paranjape <vedantparanjape160201@gmail.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 16 Jul 2021 02:16:17 +0530", "Message-Id": "<20210715204617.20140-2-vedantparanjape160201@gmail.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20210715204617.20140-1-vedantparanjape160201@gmail.com>", "References": "<20210715204617.20140-1-vedantparanjape160201@gmail.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v3 2/2] libcamera: Add pixel format\n\tBGRX8888", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Cc": "Vedant Paranjape <vedantparanjape160201@gmail.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "This patch adds pixel format BGRX8888 to libcamera. Additionally adds\nmapping of V4L2 pixel format (V4L2_PIX_FMT_XRGB32) to BGRX8888.\n\nSigned-off-by: Vedant Paranjape <vedantparanjape160201@gmail.com>\nReviewed-by: Paul Elder <paul.elder@ideasonboard.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/libcamera/formats.cpp | 10 ++++++++++\n src/libcamera/v4l2_pixelformat.cpp | 1 +\n 2 files changed, 11 insertions(+)", "diff": "diff --git a/src/libcamera/formats.cpp b/src/libcamera/formats.cpp\nindex 578ac4af..8f1197de 100644\n--- a/src/libcamera/formats.cpp\n+++ b/src/libcamera/formats.cpp\n@@ -205,6 +205,16 @@ const std::map<PixelFormat, PixelFormatInfo> pixelFormatInfo{\n \t\t.pixelsPerGroup = 1,\n \t\t.planes = {{ { 4, 1 }, { 0, 0 }, { 0, 0 } }},\n \t} },\n+\t{ formats::BGRX8888, {\n+\t\t.name = \"BGRX8888\",\n+\t\t.format = formats::BGRX8888,\n+\t\t.v4l2Format = V4L2PixelFormat(V4L2_PIX_FMT_XRGB32),\n+\t\t.bitsPerPixel = 32,\n+\t\t.colourEncoding = PixelFormatInfo::ColourEncodingRGB,\n+\t\t.packed = false,\n+\t\t.pixelsPerGroup = 1,\n+\t\t.planes = {{ { 4, 1 }, { 0, 0 }, { 0, 0 } }},\n+\t} },\n \t{ formats::ABGR8888, {\n \t\t.name = \"ABGR8888\",\n \t\t.format = formats::ABGR8888,\ndiff --git a/src/libcamera/v4l2_pixelformat.cpp b/src/libcamera/v4l2_pixelformat.cpp\nindex 59a01e02..93fc4446 100644\n--- a/src/libcamera/v4l2_pixelformat.cpp\n+++ b/src/libcamera/v4l2_pixelformat.cpp\n@@ -52,6 +52,7 @@ const std::map<V4L2PixelFormat, PixelFormat> vpf2pf{\n \t{ V4L2PixelFormat(V4L2_PIX_FMT_RGB24), formats::BGR888 },\n \t{ V4L2PixelFormat(V4L2_PIX_FMT_BGR24), formats::RGB888 },\n \t{ V4L2PixelFormat(V4L2_PIX_FMT_XBGR32), formats::XRGB8888 },\n+\t{ V4L2PixelFormat(V4L2_PIX_FMT_XRGB32), formats::BGRX8888 },\n \t{ V4L2PixelFormat(V4L2_PIX_FMT_RGBX32), formats::XBGR8888 },\n \t{ V4L2PixelFormat(V4L2_PIX_FMT_RGBA32), formats::ABGR8888 },\n \t{ V4L2PixelFormat(V4L2_PIX_FMT_ABGR32), formats::ARGB8888 },\n", "prefixes": [ "libcamera-devel", "v3", "2/2" ] }