Patch Detail
Show a patch.
GET /api/patches/12960/?format=api
{ "id": 12960, "url": "https://patchwork.libcamera.org/api/patches/12960/?format=api", "web_url": "https://patchwork.libcamera.org/patch/12960/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210715140011.122598-1-kieran.bingham@ideasonboard.com>", "date": "2021-07-15T14:00:11", "name": "[libcamera-devel] android: camera_capabilities: Ensure PixelArrayActiveAreas exists before accessing", "commit_ref": null, "pull_url": null, "state": "rejected", "archived": false, "hash": "d6196c7aba69a47561d617df0218d9d6ad2607ae", "submitter": { "id": 4, "url": "https://patchwork.libcamera.org/api/people/4/?format=api", "name": "Kieran Bingham", "email": "kieran.bingham@ideasonboard.com" }, "delegate": { "id": 11, "url": "https://patchwork.libcamera.org/api/users/11/?format=api", "username": "kbingham", "first_name": "Kieran", "last_name": "Bingham", "email": "kieran.bingham@ideasonboard.com" }, "mbox": "https://patchwork.libcamera.org/patch/12960/mbox/", "series": [ { "id": 2236, "url": "https://patchwork.libcamera.org/api/series/2236/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2236", "date": "2021-07-15T14:00:11", "name": "[libcamera-devel] android: camera_capabilities: Ensure PixelArrayActiveAreas exists before accessing", "version": 1, "mbox": "https://patchwork.libcamera.org/series/2236/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/12960/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/12960/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 48AE2C3226\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 15 Jul 2021 14:00:17 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 546A76852A;\n\tThu, 15 Jul 2021 16:00:16 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1277B60282\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 15 Jul 2021 16:00:15 +0200 (CEST)", "from Monstersaurus.local\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7F9D2340;\n\tThu, 15 Jul 2021 16:00:14 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"MNn5THJN\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1626357614;\n\tbh=LtUJchNdY8krzZaX2SV2x/rp+zOSEvyWrIG2jsvInjY=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=MNn5THJNN0gJhftZTnBWN4h8rai2LZBlefKKCjB5iDhiamx1eCnf58U4IXZUWp3ud\n\tV6YorLf6Pmv5SLm8h5019hqb6rCPML+5iuci+3bJrcYNro6Jv2Oh0n1ZTndveTH2QF\n\tSIUzZnzof2lhS004STObTTWpEqrL7QkJGZt2YqAU=", "From": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "To": "libcamera devel <libcamera-devel@lists.libcamera.org>", "Date": "Thu, 15 Jul 2021 15:00:11 +0100", "Message-Id": "<20210715140011.122598-1-kieran.bingham@ideasonboard.com>", "X-Mailer": "git-send-email 2.30.2", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH] android: camera_capabilities: Ensure\n\tPixelArrayActiveAreas exists before accessing", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The VIVID pipline handler does not set this. It's likely that the\nUVC pipeline will not either.\n\nIf not present, we must not access it.\n\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n src/android/camera_capabilities.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/src/android/camera_capabilities.cpp b/src/android/camera_capabilities.cpp\nindex 6b5edb66fad2..dfc961affe46 100644\n--- a/src/android/camera_capabilities.cpp\n+++ b/src/android/camera_capabilities.cpp\n@@ -589,7 +589,7 @@ int CameraCapabilities::initializeStaticMetadata()\n \t\t\t\t\t physicalSize);\n \t}\n \n-\t{\n+\tif (properties.contains(properties::PixelArrayActiveAreas)) {\n \t\tconst Span<const Rectangle> &rects =\n \t\t\tproperties.get(properties::PixelArrayActiveAreas);\n \t\tstd::vector<int32_t> data{\n", "prefixes": [ "libcamera-devel" ] }