Patch Detail
Show a patch.
GET /api/patches/12891/?format=api
{ "id": 12891, "url": "https://patchwork.libcamera.org/api/patches/12891/?format=api", "web_url": "https://patchwork.libcamera.org/patch/12891/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210709145825.2943443-9-naush@raspberrypi.com>", "date": "2021-07-09T14:58:25", "name": "[libcamera-devel,v6,8/8] ipa: raspberrypi: Make variable names consistent", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "f31a50c0338dff5ce2c47fc852d5e1f000206f7f", "submitter": { "id": 34, "url": "https://patchwork.libcamera.org/api/people/34/?format=api", "name": "Naushir Patuck", "email": "naush@raspberrypi.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/12891/mbox/", "series": [ { "id": 2223, "url": "https://patchwork.libcamera.org/api/series/2223/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2223", "date": "2021-07-09T14:58:17", "name": "ipa: raspberrypi: Allow long exposure modes for imx477.", "version": 6, "mbox": "https://patchwork.libcamera.org/series/2223/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/12891/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/12891/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1E07CC3226\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 9 Jul 2021 14:58:39 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C5DFC68528;\n\tFri, 9 Jul 2021 16:58:38 +0200 (CEST)", "from mail-wr1-x436.google.com (mail-wr1-x436.google.com\n\t[IPv6:2a00:1450:4864:20::436])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4C2B768528\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 9 Jul 2021 16:58:36 +0200 (CEST)", "by mail-wr1-x436.google.com with SMTP id g16so2638698wrw.5\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 09 Jul 2021 07:58:36 -0700 (PDT)", "from naush-laptop.pitowers.org\n\t([2a00:1098:3142:14:35c2:26d3:e217:4410])\n\tby smtp.gmail.com with ESMTPSA id\n\tc2sm1480995wrn.28.2021.07.09.07.58.35\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 09 Jul 2021 07:58:35 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"VVEq0Kl0\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=+/4A6ABHPnLQLSLzSzJ8J1XyM12VeDFiiq0NwDb/Dis=;\n\tb=VVEq0Kl035cb/PKDl95rMiTcUW5hOukS7fXRNzN2kyY8If6rkWT0WABNw10nIysNSl\n\tqvokmwzEpKumo2TfzzsAjV5ulo7fLcCipRnzhftOpUgdU1O+xugUqTVD67GQ3SL4vqqT\n\t35iOI1+1+zbqrPNP5EKSHAd3fyqgvjQvLLR/axkR64/2aZCxC3W/VkOpuQduu9U5zo9T\n\tXnYdJk6mpcg8plIB7mLqZRioo8kz+qQ3ZtxITBxO9mU9bca7Gek0MFnoxssik4zofByB\n\tRm600ZORmdIw7J72cXI5vsJIr41og6C6nA3RQ+eOrKLOjuAezp/GW8e9kM69fkWfiHTN\n\tHcjA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=+/4A6ABHPnLQLSLzSzJ8J1XyM12VeDFiiq0NwDb/Dis=;\n\tb=NiGh16yXrKwAXlKF9r4xXQI41qL5/t1SQHKTtFQYgTCiSVPDj8xt4uX2GGBa8zRKVb\n\tYkIScXREL8creW+kWK1Di1fdUE33lQmGJnRZzO2tkeai7e5pOgNimDduCN8PmTxYuYhk\n\t5sBge2g7YDpBSDCD1Vr4pp6yfPGRXqT04+tRElyO42oUgv1Uuo06SuFp3I9+D+WwIbBA\n\tUFE33iXccfGrUIVNyzweVULgM/ZOSdLl6vyD8FH+dQ1/UvrVB3g8oi0LNUyboZh9e94f\n\ttz0CAgdLssjMdJiheuwKB+BPm607wE8Z58d2JoRn90/Od+X5s5OQIDi/urSE8hMQWqnd\n\tS8tA==", "X-Gm-Message-State": "AOAM532M2ev3CDZC5s/OtPjHa74bpa4i5vePPRLvoovWbMWKK9jC6v3F\n\t9xXWhmjnpUuQB1rsyOcLPvkLI7+lQFgVtQ==", "X-Google-Smtp-Source": "ABdhPJzblk4kkFk0g2Ovg2fiFCSm37oEyMuyM9TS0Mds++Hke4n+ua5I+o9WNreH8KAKOiV5yqV9ng==", "X-Received": "by 2002:a5d:56d0:: with SMTP id\n\tm16mr42688149wrw.26.1625842715818; \n\tFri, 09 Jul 2021 07:58:35 -0700 (PDT)", "From": "Naushir Patuck <naush@raspberrypi.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 9 Jul 2021 15:58:25 +0100", "Message-Id": "<20210709145825.2943443-9-naush@raspberrypi.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20210709145825.2943443-1-naush@raspberrypi.com>", "References": "<20210709145825.2943443-1-naush@raspberrypi.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v6 8/8] ipa: raspberrypi: Make variable\n\tnames consistent", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "s/DefaultAnalogueGain/defaultAnalogueGain/\ns/DefaultExposureTime/defaultExposureTime/\n\nChange these for consistency with the other static const variables.\n\nSigned-off-by: Naushir Patuck <naush@raspberrypi.com>\nReviewed-by: David Plowman <david.plowman@raspberrypi.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n src/ipa/raspberrypi/raspberrypi.cpp | 8 ++++----\n 1 file changed, 4 insertions(+), 4 deletions(-)", "diff": "diff --git a/src/ipa/raspberrypi/raspberrypi.cpp b/src/ipa/raspberrypi/raspberrypi.cpp\nindex 8fb98a49da63..1dd7fd68c3e9 100644\n--- a/src/ipa/raspberrypi/raspberrypi.cpp\n+++ b/src/ipa/raspberrypi/raspberrypi.cpp\n@@ -59,8 +59,8 @@ using namespace std::literals::chrono_literals;\n using utils::Duration;\n \n /* Configure the sensor with these values initially. */\n-constexpr double DefaultAnalogueGain = 1.0;\n-constexpr Duration DefaultExposureTime = 20.0ms;\n+constexpr double defaultAnalogueGain = 1.0;\n+constexpr Duration defaultExposureTime = 20.0ms;\n constexpr Duration defaultMinFrameDuration = 1.0s / 30.0;\n constexpr Duration defaultMaxFrameDuration = 250.0s;\n \n@@ -390,8 +390,8 @@ int IPARPi::configure(const IPACameraSensorInfo &sensorInfo,\n \t\t/* Supply initial values for gain and exposure. */\n \t\tControlList ctrls(sensorCtrls_);\n \t\tAgcStatus agcStatus;\n-\t\tagcStatus.shutter_time = DefaultExposureTime;\n-\t\tagcStatus.analogue_gain = DefaultAnalogueGain;\n+\t\tagcStatus.shutter_time = defaultExposureTime;\n+\t\tagcStatus.analogue_gain = defaultAnalogueGain;\n \t\tapplyAGC(&agcStatus, ctrls);\n \n \t\tASSERT(controls);\n", "prefixes": [ "libcamera-devel", "v6", "8/8" ] }