Patch Detail
Show a patch.
GET /api/patches/12869/?format=api
{ "id": 12869, "url": "https://patchwork.libcamera.org/api/patches/12869/?format=api", "web_url": "https://patchwork.libcamera.org/patch/12869/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210708105405.147172-2-umang.jain@ideasonboard.com>", "date": "2021-07-08T10:54:04", "name": "[libcamera-devel,v2,1/2] DNI: Enforce IPA isolation and set log file path", "commit_ref": null, "pull_url": null, "state": "not-applicable", "archived": false, "hash": "ae3dad1303ba99b77fccddc67d794d3b20ae132e", "submitter": { "id": 86, "url": "https://patchwork.libcamera.org/api/people/86/?format=api", "name": "Umang Jain", "email": "umang.jain@ideasonboard.com" }, "delegate": { "id": 12, "url": "https://patchwork.libcamera.org/api/users/12/?format=api", "username": "uajain", "first_name": "Umang", "last_name": "Jain", "email": "umang.jain@ideasonboard.com" }, "mbox": "https://patchwork.libcamera.org/patch/12869/mbox/", "series": [ { "id": 2218, "url": "https://patchwork.libcamera.org/api/series/2218/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2218", "date": "2021-07-08T10:54:03", "name": "utils: ipc: proxy: Always reset ControlSerializer during IPA configure", "version": 2, "mbox": "https://patchwork.libcamera.org/series/2218/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/12869/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/12869/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C7504C3225\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 8 Jul 2021 10:54:19 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8FD2468524;\n\tThu, 8 Jul 2021 12:54:19 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6DAA968506\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 8 Jul 2021 12:54:18 +0200 (CEST)", "from perceval.ideasonboard.com (unknown [103.251.226.59])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 66C3DE7;\n\tThu, 8 Jul 2021 12:54:17 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ONQ96Pmf\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1625741658;\n\tbh=oEjSie/682r4kN2gVxepKJuJcyDTRryTkzZovvVAbEY=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=ONQ96PmfM2yaw3kejPrPP/RYzPpx3WfPRRS+ei3SEk+Ty0IX7iYJuD2m/OR3QRxSW\n\t4la6T+mur/lOCI2B2yh2AfmUCOhrbvpe2iTbRhJoZzT7NI5jmhdYQmllmmh++XMZhn\n\tyj/m2ykqq3KXAX5B/6RHkmPlM936wPAhJvJvN6ZE=", "From": "Umang Jain <umang.jain@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 8 Jul 2021 16:24:04 +0530", "Message-Id": "<20210708105405.147172-2-umang.jain@ideasonboard.com>", "X-Mailer": "git-send-email 2.31.1", "In-Reply-To": "<20210708105405.147172-1-umang.jain@ideasonboard.com>", "References": "<20210708105405.147172-1-umang.jain@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v2 1/2] DNI: Enforce IPA isolation and set\n\tlog file path", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "---\n src/ipa/ipu3/ipu3.cpp | 2 ++\n src/libcamera/ipa_manager.cpp | 1 +\n 2 files changed, 3 insertions(+)", "diff": "diff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp\nindex 31a3c006..623c27b7 100644\n--- a/src/ipa/ipu3/ipu3.cpp\n+++ b/src/ipa/ipu3/ipu3.cpp\n@@ -12,6 +12,7 @@\n #include <linux/v4l2-controls.h>\n \n #include <libcamera/base/log.h>\n+#include <libcamera/logging.h>\n \n #include <libcamera/buffer.h>\n #include <libcamera/control_ids.h>\n@@ -39,6 +40,7 @@ class IPAIPU3 : public IPAIPU3Interface\n public:\n \tint init([[maybe_unused]] const IPASettings &settings) override\n \t{\n+\t\tlogSetFile(\"/tmp/isolated.log\");\n \t\treturn 0;\n \t}\n \tint start() override;\ndiff --git a/src/libcamera/ipa_manager.cpp b/src/libcamera/ipa_manager.cpp\nindex b4606c61..5d8ddae1 100644\n--- a/src/libcamera/ipa_manager.cpp\n+++ b/src/libcamera/ipa_manager.cpp\n@@ -258,6 +258,7 @@ unsigned int IPAManager::addDir(const char *libDir, unsigned int maxDepth)\n \n bool IPAManager::isSignatureValid([[maybe_unused]] IPAModule *ipa) const\n {\n+\treturn false;\n #if HAVE_IPA_PUBKEY\n \tFile file{ ipa->path() };\n \tif (!file.open(File::ReadOnly))\n", "prefixes": [ "libcamera-devel", "v2", "1/2" ] }