Patch Detail
Show a patch.
GET /api/patches/12790/?format=api
{ "id": 12790, "url": "https://patchwork.libcamera.org/api/patches/12790/?format=api", "web_url": "https://patchwork.libcamera.org/patch/12790/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210702130707.25345-1-laurent.pinchart@ideasonboard.com>", "date": "2021-07-02T13:07:07", "name": "[libcamera-devel] ipa: raspberrypi: Drop unneeded [[maybe_unused]]", "commit_ref": "d7415bc4e46fe8aa25a495c79516d9882a35a5aa", "pull_url": null, "state": "accepted", "archived": false, "hash": "401202f0c6e74b24854180b16398124aa9ff3195", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/12790/mbox/", "series": [ { "id": 2202, "url": "https://patchwork.libcamera.org/api/series/2202/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2202", "date": "2021-07-02T13:07:07", "name": "[libcamera-devel] ipa: raspberrypi: Drop unneeded [[maybe_unused]]", "version": 1, "mbox": "https://patchwork.libcamera.org/series/2202/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/12790/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/12790/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E1CBAC3220\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 2 Jul 2021 13:07:52 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6DC41684F2;\n\tFri, 2 Jul 2021 15:07:52 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B9597684E7\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 2 Jul 2021 15:07:50 +0200 (CEST)", "from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 43D754AB;\n\tFri, 2 Jul 2021 15:07:50 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"QFGkprY3\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1625231270;\n\tbh=Jzoljca9UgO+sUvh7INiwUZsUQFgZu3EmVNDA7nh7/A=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=QFGkprY3r/YYdm+pBJ8t7vGqIQCFzykVGnjvqYc5mFGaAgTGYqE9Kwl+DQKZ56KI2\n\tw2usHHFV0UwQNV3WeNuDLoJQyYPYfu9oic2cN4JjibYgE6qGOAtxR8SSOPzZ+amkd2\n\tnmX5VCJUKTzT0k+FZA2cONc0l8V3t5LyGbjnX3rs=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 2 Jul 2021 16:07:07 +0300", "Message-Id": "<20210702130707.25345-1-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.31.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH] ipa: raspberrypi: Drop unneeded\n\t[[maybe_unused]]", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The [[maybe_unused]] in the IMX477 camera helper isn't needed. This had\nbeen pointed out by Naush during review, but I failed to update the code\nbefore pushing.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/ipa/raspberrypi/cam_helper_imx477.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/src/ipa/raspberrypi/cam_helper_imx477.cpp b/src/ipa/raspberrypi/cam_helper_imx477.cpp\nindex 4098fde6f322..efd1a5893db8 100644\n--- a/src/ipa/raspberrypi/cam_helper_imx477.cpp\n+++ b/src/ipa/raspberrypi/cam_helper_imx477.cpp\n@@ -23,7 +23,7 @@ constexpr uint32_t expHiReg = 0x0202;\n constexpr uint32_t expLoReg = 0x0203;\n constexpr uint32_t gainHiReg = 0x0204;\n constexpr uint32_t gainLoReg = 0x0205;\n-constexpr std::initializer_list<uint32_t> registerList [[maybe_unused]] = { expHiReg, expLoReg, gainHiReg, gainLoReg };\n+constexpr std::initializer_list<uint32_t> registerList = { expHiReg, expLoReg, gainHiReg, gainLoReg };\n \n class CamHelperImx477 : public CamHelper\n {\n", "prefixes": [ "libcamera-devel" ] }