Patch Detail
Show a patch.
GET /api/patches/12782/?format=api
{ "id": 12782, "url": "https://patchwork.libcamera.org/api/patches/12782/?format=api", "web_url": "https://patchwork.libcamera.org/patch/12782/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210702120850.457492-1-vedantparanjape160201@gmail.com>", "date": "2021-07-02T12:08:49", "name": "[libcamera-devel,v1,1/2] Fixes: libcamera: Fix the V4L2 pixel format for formats::XBGR8888", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "c716ad04f873997b57a2fef177f3f4c678e78b98", "submitter": { "id": 85, "url": "https://patchwork.libcamera.org/api/people/85/?format=api", "name": "Vedant Paranjape", "email": "vedantparanjape160201@gmail.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/12782/mbox/", "series": [ { "id": 2200, "url": "https://patchwork.libcamera.org/api/series/2200/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2200", "date": "2021-07-02T12:08:49", "name": "[libcamera-devel,v1,1/2] Fixes: libcamera: Fix the V4L2 pixel format for formats::XBGR8888", "version": 1, "mbox": "https://patchwork.libcamera.org/series/2200/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/12782/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/12782/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 12E60C3220\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 2 Jul 2021 12:09:16 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6C0D2684EA;\n\tFri, 2 Jul 2021 14:09:15 +0200 (CEST)", "from mail-pf1-x434.google.com (mail-pf1-x434.google.com\n\t[IPv6:2607:f8b0:4864:20::434])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A798C684E8\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 2 Jul 2021 14:09:13 +0200 (CEST)", "by mail-pf1-x434.google.com with SMTP id w22so5115992pff.5\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 02 Jul 2021 05:09:13 -0700 (PDT)", "from localhost.localdomain ([1.186.167.49])\n\tby smtp.googlemail.com with ESMTPSA id\n\ti6sm3835325pgg.50.2021.07.02.05.09.09\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 02 Jul 2021 05:09:11 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"C0UNaPoU\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=Q9EJv1TGP6ihJsLdY5YIEIgvSp71TmmAnpcjmy1rKow=;\n\tb=C0UNaPoUHJ6IfI8L4AoeKy3+m1+DGnMqUK6t4yM+9gnjqxu0mzGr/XdYIShfLGpZJR\n\t4CMmGzgJew9VhKK0pSK6+U9KxOVU5PrtuKPArFpSbW0Q/rv73V+giHlGwIiAo6nHM4JK\n\tjk/4kwL04AEo4W9VRGUTFmRBYMWdtB3qaaCMlUCR4TJwJFXBLc2qBfEojYdEnYbIKn4k\n\tEMXlUhV5UMy5MzHjg4s+EvsE8Rp5XCu3JEqPzkyrISPWNIED11/y94id1jbQ9ksIZC4l\n\tqfcDznj7UjbTwQPMgTmFb7JJLDQAVLT8ve7eG+otN3dFyEEaPNu7vXg5Y3yr9hqeTOTB\n\tUzqQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=Q9EJv1TGP6ihJsLdY5YIEIgvSp71TmmAnpcjmy1rKow=;\n\tb=Y8P/HzHtJP/t6eVc26sAe8OnrCbysjF6MiN7eUROmgOVtGjvWl3jQw6RhIZGXYx/jJ\n\tDjrcICoHpfBbbox/DUknNADwaSdfCro7HgNLuUd4+e9/1Ez219ATtAPks/bxapV1bgS4\n\tD4xz/2md4jOeS/PZZmcy0xMSaUd1oUN4LsBT2z0cO5+L0QsHYud0AR9q4+75bRaEF7rS\n\tXNTnwyCgNt6s4oA0+G8lju9uHQHao+ZuXn8qPz420n2PQHDeLhiR1beMtnlU/OvsMuCA\n\tQhyQc18IVaSb8s7GGSHR22aqeI+TExMDkEDV9/ndYjMdNCCIlNR06oplQkgXaCeWHiLT\n\t6ywQ==", "X-Gm-Message-State": "AOAM532KtEaTcGnTTQpgEYFmc3du6Yhe9svt5SMD+ytgHhWIaIW2WeEA\n\tX5DDFMjkMIv1lkqEj1+mJpdq1sL4wf+WpRKFEHs=", "X-Google-Smtp-Source": "ABdhPJw4JWB1BLlMmB50PcYDIWxT/RzTUugLw6gk2J+X8gxxMHoUBEybfOJAUXMkKdmt1SyOhi7TCA==", "X-Received": "by 2002:a63:4e4d:: with SMTP id o13mr364708pgl.361.1625227751742;\n\tFri, 02 Jul 2021 05:09:11 -0700 (PDT)", "From": "Vedant Paranjape <vedantparanjape160201@gmail.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 2 Jul 2021 17:38:49 +0530", "Message-Id": "<20210702120850.457492-1-vedantparanjape160201@gmail.com>", "X-Mailer": "git-send-email 2.25.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v1 1/2] Fixes: libcamera: Fix the V4L2\n\tpixel format for formats::XBGR8888", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Cc": "Vedant Paranjape <vedantparanjape160201@gmail.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "This patch fixes V4L2 pixel format for formats::XBGR8888 by updating\nthe existing matching to V4L2_PIX_FMT_RGBX32\n\nSigned-off-by: Vedant Paranjape <vedantparanjape160201@gmail.com>\n---\n src/libcamera/formats.cpp | 2 +-\n src/libcamera/v4l2_pixelformat.cpp | 2 +-\n 2 files changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/src/libcamera/formats.cpp b/src/libcamera/formats.cpp\nindex 59a34853..578ac4af 100644\n--- a/src/libcamera/formats.cpp\n+++ b/src/libcamera/formats.cpp\n@@ -198,7 +198,7 @@ const std::map<PixelFormat, PixelFormatInfo> pixelFormatInfo{\n \t{ formats::XBGR8888, {\n \t\t.name = \"XBGR8888\",\n \t\t.format = formats::XBGR8888,\n-\t\t.v4l2Format = V4L2PixelFormat(V4L2_PIX_FMT_XRGB32),\n+\t\t.v4l2Format = V4L2PixelFormat(V4L2_PIX_FMT_RGBX32),\n \t\t.bitsPerPixel = 32,\n \t\t.colourEncoding = PixelFormatInfo::ColourEncodingRGB,\n \t\t.packed = false,\ndiff --git a/src/libcamera/v4l2_pixelformat.cpp b/src/libcamera/v4l2_pixelformat.cpp\nindex 87d728fe..59a01e02 100644\n--- a/src/libcamera/v4l2_pixelformat.cpp\n+++ b/src/libcamera/v4l2_pixelformat.cpp\n@@ -52,7 +52,7 @@ const std::map<V4L2PixelFormat, PixelFormat> vpf2pf{\n \t{ V4L2PixelFormat(V4L2_PIX_FMT_RGB24), formats::BGR888 },\n \t{ V4L2PixelFormat(V4L2_PIX_FMT_BGR24), formats::RGB888 },\n \t{ V4L2PixelFormat(V4L2_PIX_FMT_XBGR32), formats::XRGB8888 },\n-\t{ V4L2PixelFormat(V4L2_PIX_FMT_XRGB32), formats::XBGR8888 },\n+\t{ V4L2PixelFormat(V4L2_PIX_FMT_RGBX32), formats::XBGR8888 },\n \t{ V4L2PixelFormat(V4L2_PIX_FMT_RGBA32), formats::ABGR8888 },\n \t{ V4L2PixelFormat(V4L2_PIX_FMT_ABGR32), formats::ARGB8888 },\n \t{ V4L2PixelFormat(V4L2_PIX_FMT_ARGB32), formats::BGRA8888 },\n", "prefixes": [ "libcamera-devel", "v1", "1/2" ] }