Patch Detail
Show a patch.
GET /api/patches/12778/?format=api
{ "id": 12778, "url": "https://patchwork.libcamera.org/api/patches/12778/?format=api", "web_url": "https://patchwork.libcamera.org/patch/12778/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210702103800.41291-14-paul.elder@ideasonboard.com>", "date": "2021-07-02T10:37:57", "name": "[libcamera-devel,RFC,v3,13/16] FULL: pipeline: ipu3: Set AeEnable ControlInfo", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "ed4dabcb65d3d09db7a587f2ee3117fe5bdc9657", "submitter": { "id": 17, "url": "https://patchwork.libcamera.org/api/people/17/?format=api", "name": "Paul Elder", "email": "paul.elder@ideasonboard.com" }, "delegate": { "id": 17, "url": "https://patchwork.libcamera.org/api/users/17/?format=api", "username": "epaul", "first_name": "Paul", "last_name": "Elder", "email": "paul.elder@ideasonboard.com" }, "mbox": "https://patchwork.libcamera.org/patch/12778/mbox/", "series": [ { "id": 2199, "url": "https://patchwork.libcamera.org/api/series/2199/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2199", "date": "2021-07-02T10:37:44", "name": "Preliminary FULL plumbing", "version": 3, "mbox": "https://patchwork.libcamera.org/series/2199/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/12778/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/12778/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 95207C3222\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 2 Jul 2021 10:38:39 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 50135684FD;\n\tFri, 2 Jul 2021 12:38:39 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3DF65684FD\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 2 Jul 2021 12:38:38 +0200 (CEST)", "from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B05AC4AB;\n\tFri, 2 Jul 2021 12:38:36 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"I7w8AsJe\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1625222318;\n\tbh=QBdRZ6yRKb34w4pSKot0TfhTvRGHHBZ2vG4Fso9Ztrc=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=I7w8AsJeLcjLe8q+AOZrlhg/yV2Rz7Ri5BA8f1icU2P0d0N0JvaUUxz85Z3FofhRz\n\tAz2D9EjaoZxQYz3Y7vA3ALaTQQZR3JKfhENWkA6HPHfHE5Nn4fb9q7Gs9ZGgjbVxkY\n\tsc0BLYyABe3UhHm+gqFZnLSk7UMiagW6YfYd1uwA=", "From": "Paul Elder <paul.elder@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 2 Jul 2021 19:37:57 +0900", "Message-Id": "<20210702103800.41291-14-paul.elder@ideasonboard.com>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20210702103800.41291-1-paul.elder@ideasonboard.com>", "References": "<20210702103800.41291-1-paul.elder@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [RFC PATCH v3 13/16] FULL: pipeline: ipu3: Set\n\tAeEnable ControlInfo", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "We want the IPU3 IPA to support enabling and disabling AE, so initialize\nthe AeEnable ControlInfo in the IPU3 pipeline handler.\n\nBug: https://bugs.libcamera.org/show_bug.cgi?id=42\nSigned-off-by: Paul Elder <paul.elder@ideasonboard.com>\n\n---\nChanges in v3:\n- use boolean ControlInfo constructor\n---\n src/libcamera/pipeline/ipu3/ipu3.cpp | 2 ++\n 1 file changed, 2 insertions(+)", "diff": "diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\nindex d3dafd98..a755493c 100644\n--- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n+++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n@@ -12,6 +12,7 @@\n #include <vector>\n \n #include <libcamera/base/log.h>\n+#include <libcamera/base/span.h>\n #include <libcamera/base/utils.h>\n \n #include <libcamera/camera.h>\n@@ -49,6 +50,7 @@ static constexpr unsigned int IMGU_OUTPUT_HEIGHT_MARGIN = 32;\n static constexpr Size IPU3ViewfinderSize(1280, 720);\n \n static const ControlInfoMap::Map IPU3Controls = {\n+\t{ &controls::AeEnable, ControlInfo(Span<const bool>({ false, true }), true) },\n \t{ &controls::draft::MaxLatency, ControlInfo(0, 0, 0) },\n \t{ &controls::draft::PipelineDepth, ControlInfo(2, 3) },\n };\n", "prefixes": [ "libcamera-devel", "RFC", "v3", "13/16" ] }