Patch Detail
Show a patch.
GET /api/patches/12772/?format=api
{ "id": 12772, "url": "https://patchwork.libcamera.org/api/patches/12772/?format=api", "web_url": "https://patchwork.libcamera.org/patch/12772/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210702103800.41291-8-paul.elder@ideasonboard.com>", "date": "2021-07-02T10:37:51", "name": "[libcamera-devel,RFC,v3,07/16] controls: Replace AwbLocked with AwbState, and add AwbLock", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "9344916ae09db823f3949f898c72f982ab107869", "submitter": { "id": 17, "url": "https://patchwork.libcamera.org/api/people/17/?format=api", "name": "Paul Elder", "email": "paul.elder@ideasonboard.com" }, "delegate": { "id": 17, "url": "https://patchwork.libcamera.org/api/users/17/?format=api", "username": "epaul", "first_name": "Paul", "last_name": "Elder", "email": "paul.elder@ideasonboard.com" }, "mbox": "https://patchwork.libcamera.org/patch/12772/mbox/", "series": [ { "id": 2199, "url": "https://patchwork.libcamera.org/api/series/2199/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2199", "date": "2021-07-02T10:37:44", "name": "Preliminary FULL plumbing", "version": 3, "mbox": "https://patchwork.libcamera.org/series/2199/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/12772/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/12772/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5CF55C3222\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 2 Jul 2021 10:38:29 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1DBF8684F3;\n\tFri, 2 Jul 2021 12:38:29 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 82C5C684FC\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 2 Jul 2021 12:38:26 +0200 (CEST)", "from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 24053891;\n\tFri, 2 Jul 2021 12:38:24 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"JUV94TEN\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1625222306;\n\tbh=IrsC/FeWyfcL0Sh+EI8m4+rQeJYAHb7u7XqagunHW5k=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=JUV94TENVIKbSsgXxqHeQ2q3RGcnhpmB2vuO3Pw+ZTH9H+N4nWg1ve1BD8Y7/c7Ex\n\tFdj2pmCOLEqw9d/exc2Z4yRROrw3hx+Aq/yYLqQx7ZLzgqBfJBX3gMRdYITFoqjBBi\n\tBje43DGQy5DPT7Ro8iN62yLgE/jII/t4Zx+nUOUE=", "From": "Paul Elder <paul.elder@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 2 Jul 2021 19:37:51 +0900", "Message-Id": "<20210702103800.41291-8-paul.elder@ideasonboard.com>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20210702103800.41291-1-paul.elder@ideasonboard.com>", "References": "<20210702103800.41291-1-paul.elder@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [RFC PATCH v3 07/16] controls: Replace AwbLocked\n\twith AwbState, and add AwbLock", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "AwbLocked alone isn't sufficient for reporting the AWB state, so replace\nit with AwbState. Add an AwbLock control for instructing the camera to\nlock the AWB values.\n\nSigned-off-by: Paul Elder <paul.elder@ideasonboard.com>\n\n---\nNo change in v3\n---\n src/libcamera/control_ids.yaml | 82 ++++++++++++++++++++--------------\n 1 file changed, 49 insertions(+), 33 deletions(-)", "diff": "diff --git a/src/libcamera/control_ids.yaml b/src/libcamera/control_ids.yaml\nindex 2e62f61b..3a4f07cf 100644\n--- a/src/libcamera/control_ids.yaml\n+++ b/src/libcamera/control_ids.yaml\n@@ -161,6 +161,55 @@ controls:\n value: 3\n description: Custom exposure mode.\n \n+ - AwbLock:\n+ type: bool\n+ description: |\n+ Control to lock the AWB values.\n+ When set to true, the AWB algorithm is locked to its latest parameters,\n+ and will not change exposure settings until set to false.\n+ \\sa AwbState\n+\n+ - AwbState:\n+ type: int32_t\n+ description: |\n+ Control to report the current AWB algorithm state. Switching between or\n+ enabling AWB modes (AwbMode) always resets the AwbState to\n+ AwbStateInactive. The camera device can do several state transitions\n+ between two results, if it is allowed by the state transition table.\n+ For example, AwbStateInactive may never actually be seen in a result.\n+\n+ The state in the result is the state for this image (in sync with this\n+ image). If AWB state becomes AwbStateConverged, then the image data\n+ associated with the result should be good to use.\n+\n+ The state transitions mentioned below assume that AwbMode is auto.\n+\n+ \\sa AwbLock\n+ enum:\n+ - name: AwbStateInactive\n+ value: 0\n+ description: |\n+ The AWB algorithm is inactive.\n+ If the camera initiates an AWB scan, the state shall go to Searching.\n+ If AwbLock is on, the state shall go to Locked.\n+ - name: AwbStateSearching\n+ value: 1\n+ description: |\n+ The AWB algorithm has not converged yet.\n+ If the camera finishes an AWB scan, the state shall go to Converged.\n+ If AwbLock is on, the state shall go to Locked.\n+ - name: AwbStateConverged\n+ value: 2\n+ description: |\n+ The AWB algorithm has converged.\n+ If the camera initiates an AWB scan, the state shall go to Searching.\n+ If AwbLock is on, the state shall go to Locked.\n+ - name: AwbStateLocked\n+ value: 3\n+ description: |\n+ The AWB algorithm is locked.\n+ If AwbLock is off, the state shall go to Searching.\n+\n - ExposureValue:\n type: float\n description: |\n@@ -272,17 +321,6 @@ controls:\n value: 10\n description: Custom AWB mode.\n \n- - AwbLocked:\n- type: bool\n- description: |\n- Report the lock status of a running AWB algorithm.\n-\n- If the AWB algorithm is locked the value shall be set to true, if it's\n- converging it shall be set to false. If the AWB algorithm is not\n- running the control shall not be present in the metadata control list.\n-\n- \\sa AwbEnable\n-\n - ColourGains:\n type: float\n description: |\n@@ -572,28 +610,6 @@ controls:\n description: |\n AF has completed a passive scan without finding focus.\n \n- - AwbState:\n- type: int32_t\n- draft: true\n- description: |\n- Control to report the current AWB algorithm state. Currently identical\n- to ANDROID_CONTROL_AWB_STATE.\n-\n- Current state of the AWB algorithm.\n- enum:\n- - name: AwbStateInactive\n- value: 0\n- description: The AWB algorithm is inactive.\n- - name: AwbStateSearching\n- value: 1\n- description: The AWB algorithm has not converged yet.\n- - name: AwbConverged\n- value: 2\n- description: The AWB algorithm has converged.\n- - name: AwbLocked\n- value: 3\n- description: The AWB algorithm is locked.\n-\n - SensorRollingShutterSkew:\n type: int64_t\n draft: true\n", "prefixes": [ "libcamera-devel", "RFC", "v3", "07/16" ] }