Patch Detail
Show a patch.
GET /api/patches/12759/?format=api
{ "id": 12759, "url": "https://patchwork.libcamera.org/api/patches/12759/?format=api", "web_url": "https://patchwork.libcamera.org/patch/12759/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210701113442.111718-5-naush@raspberrypi.com>", "date": "2021-07-01T11:34:42", "name": "[libcamera-devel,v2,4/4] ipa: raspberrypi: Make variable names consistent", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "f31a50c0338dff5ce2c47fc852d5e1f000206f7f", "submitter": { "id": 34, "url": "https://patchwork.libcamera.org/api/people/34/?format=api", "name": "Naushir Patuck", "email": "naush@raspberrypi.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/12759/mbox/", "series": [ { "id": 2196, "url": "https://patchwork.libcamera.org/api/series/2196/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2196", "date": "2021-07-01T11:34:38", "name": "Raspberry Pi: Enable imx477 long exposure modes", "version": 2, "mbox": "https://patchwork.libcamera.org/series/2196/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/12759/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/12759/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0E695C3220\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 1 Jul 2021 11:34:53 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9B820684EA;\n\tThu, 1 Jul 2021 13:34:52 +0200 (CEST)", "from mail-wm1-x335.google.com (mail-wm1-x335.google.com\n\t[IPv6:2a00:1450:4864:20::335])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 09C33684EA\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 1 Jul 2021 13:34:50 +0200 (CEST)", "by mail-wm1-x335.google.com with SMTP id\n\tu5-20020a7bc0450000b02901480e40338bso4834249wmc.1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 01 Jul 2021 04:34:50 -0700 (PDT)", "from naush-laptop.patuck.local ([88.97.76.4])\n\tby smtp.gmail.com with ESMTPSA id\n\tf6sm8076495wrs.13.2021.07.01.04.34.48\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 01 Jul 2021 04:34:49 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"g7C1M0yc\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=WkzBNnGjJ5EyXZGtKLLqJZkUqXd6Ab1czyjc/QkrYI0=;\n\tb=g7C1M0yc8Tus3qBFcLXCDcdHYo00sABrsSoSv+bcIF8I5YvreaOILn7zJNWYEjI0QW\n\txliNPT0l9cWkRW/C/cpzKTov2W+3nuoriiZcCmtVjr52QTqaL/drqUPt9tmeCbSEQl+6\n\tSOLvPcRyMp0Pprc2mYV4ueKkwPRlHd3sd/JCJIn4KsclRmjW7x5zou2TSAW8WD5w9YaR\n\tAUZVslkS6WIyfnJut7MweXTbDlNmW2ZrCIUW3L2ArqWgfLg/TxhRZi9xpBALM7QomjZG\n\tUtbjCxS3b6zUudv6wNmio0aEou3Ew1zmWa5ZBcIxUADMozei5M4mn5R6zheey8HW3akq\n\tChZg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=WkzBNnGjJ5EyXZGtKLLqJZkUqXd6Ab1czyjc/QkrYI0=;\n\tb=VtZLwF0vs74MZZ/qPmMCkzacFwCTENPvNups6hII1zq6zMMscUnsIifeuikQrLaWr7\n\tuW0bj3rDd4uBWXeK+Gx6t/Glxe6Vg9LRc+ftPTWTIGJZcdWJHdk2l7QtqZIPLekVQk+j\n\taErjKRfLoZOcqtkzK2efrNitMxNV7VY5AB8YSnek8OXWXp3T4gSy2v9EuUphIHTHxml0\n\tvLkhwgdIsE8Vs9lNwzoMjd9xcNJX2wjLHuU/yWGyqIsreavzFMS/jjQZVCJ+z8kBS6aG\n\tBrY6BGSLEIVaap8hO9uAiedcyTU83oJ0LACueHFQyyCQe+nM9m+8YhrRF1I39+dAnrDc\n\tREbA==", "X-Gm-Message-State": "AOAM531ZR8AdfKk/uleaguaBc3XK2Agqzm+/+UZtDsUlpcP1R20jnThO\n\tsHjghMZ2Tvw7dxnuCTwJG864KP/bt5shpg==", "X-Google-Smtp-Source": "ABdhPJyigk+yzgwWSpALqmnKV9r5tU8sMofUSytMHO82l+ighUPmcHol66gp83W4rfCS4EGOeDrd6g==", "X-Received": "by 2002:a1c:771a:: with SMTP id\n\tt26mr10361322wmi.36.1625139289565; \n\tThu, 01 Jul 2021 04:34:49 -0700 (PDT)", "From": "Naushir Patuck <naush@raspberrypi.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 1 Jul 2021 12:34:42 +0100", "Message-Id": "<20210701113442.111718-5-naush@raspberrypi.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20210701113442.111718-1-naush@raspberrypi.com>", "References": "<20210701113442.111718-1-naush@raspberrypi.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v2 4/4] ipa: raspberrypi: Make variable\n\tnames consistent", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "s/DefaultAnalogueGain/defaultAnalogueGain/\ns/DefaultExposureTime/defaultExposureTime/\n\nChange these for consistency with the other static const variables.\n\nSigned-off-by: Naushir Patuck <naush@raspberrypi.com>\nReviewed-by: David Plowman <david.plowman@raspberrypi.com>\n---\n src/ipa/raspberrypi/raspberrypi.cpp | 8 ++++----\n 1 file changed, 4 insertions(+), 4 deletions(-)", "diff": "diff --git a/src/ipa/raspberrypi/raspberrypi.cpp b/src/ipa/raspberrypi/raspberrypi.cpp\nindex dd20c854c788..e9bd724f5eac 100644\n--- a/src/ipa/raspberrypi/raspberrypi.cpp\n+++ b/src/ipa/raspberrypi/raspberrypi.cpp\n@@ -59,8 +59,8 @@ using namespace std::literals::chrono_literals;\n using utils::Duration;\n \n /* Configure the sensor with these values initially. */\n-constexpr double DefaultAnalogueGain = 1.0;\n-constexpr Duration DefaultExposureTime = 20.0ms;\n+constexpr double defaultAnalogueGain = 1.0;\n+constexpr Duration defaultExposureTime = 20.0ms;\n constexpr Duration defaultMinFrameDuration = 1.0s / 30.0;\n constexpr Duration defaultMaxFrameDuration = 250.0s;\n \n@@ -390,8 +390,8 @@ int IPARPi::configure(const IPACameraSensorInfo &sensorInfo,\n \t\t/* Supply initial values for gain and exposure. */\n \t\tControlList ctrls(sensorCtrls_);\n \t\tAgcStatus agcStatus;\n-\t\tagcStatus.shutter_time = DefaultExposureTime;\n-\t\tagcStatus.analogue_gain = DefaultAnalogueGain;\n+\t\tagcStatus.shutter_time = defaultExposureTime;\n+\t\tagcStatus.analogue_gain = defaultAnalogueGain;\n \t\tapplyAGC(&agcStatus, ctrls);\n \n \t\tASSERT(controls);\n", "prefixes": [ "libcamera-devel", "v2", "4/4" ] }