Patch Detail
Show a patch.
GET /api/patches/12664/?format=api
{ "id": 12664, "url": "https://patchwork.libcamera.org/api/patches/12664/?format=api", "web_url": "https://patchwork.libcamera.org/patch/12664/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210621114738.52267-3-jeanmichel.hautbois@ideasonboard.com>", "date": "2021-06-21T11:47:38", "name": "[libcamera-devel,v5,2/2] ipa: ipu3: Initialize CameraSensorHelper at IPU3 init stage", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "3b479b25fd817218c4a5d7faef730706fa89b1d5", "submitter": { "id": 75, "url": "https://patchwork.libcamera.org/api/people/75/?format=api", "name": "Jean-Michel Hautbois", "email": "jeanmichel.hautbois@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/12664/mbox/", "series": [ { "id": 2157, "url": "https://patchwork.libcamera.org/api/series/2157/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2157", "date": "2021-06-21T11:47:36", "name": "libipa: Add support for a new sensor helper", "version": 5, "mbox": "https://patchwork.libcamera.org/series/2157/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/12664/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/12664/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1FAB6BE58C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 21 Jun 2021 11:47:46 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D3EB268932;\n\tMon, 21 Jun 2021 13:47:45 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E9FCD60296\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 21 Jun 2021 13:47:41 +0200 (CEST)", "from tatooine.ideasonboard.com (unknown\n\t[IPv6:2a01:e0a:169:7140:ed63:4e89:23b5:8ca8])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 72519AD6;\n\tMon, 21 Jun 2021 13:47:41 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"g9dPZz0+\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1624276061;\n\tbh=iNTjU70LUdktzKsnTBqclkb+5ERmHY/9RPmLjGpRcjU=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=g9dPZz0+rwm1zWIidRHjocH1jwZ2qEyj48gDKh6vUx7UiKDjLrljmkoM52mP6duea\n\tSXl7e2p/ziVLub+IJgHiM2uvu8lrh300wkh/Doi5vC/lNP0IwrBlnstZADm8bUZvl3\n\tsRx5GXMrJ+Xi85fdwlgFn2lugGcW0ctIMJsLP4PI=", "From": "Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Mon, 21 Jun 2021 13:47:38 +0200", "Message-Id": "<20210621114738.52267-3-jeanmichel.hautbois@ideasonboard.com>", "X-Mailer": "git-send-email 2.30.2", "In-Reply-To": "<20210621114738.52267-1-jeanmichel.hautbois@ideasonboard.com>", "References": "<20210621114738.52267-1-jeanmichel.hautbois@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v5 2/2] ipa: ipu3: Initialize\n\tCameraSensorHelper at IPU3 init stage", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "In order for the CameraSensorHelper to be instantiated, we need to find\nits factory using the camera sensor model name stored in\nIPASettings::sensorModel. As we don't need to do it at each configure\ncall (the sensor is not changing in-between), implement the init call in\nIPAIPU3 to do that.\n\nSigned-off-by: Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>\nReviewed-by: Umang Jain <umang.jain@ideasonboard.com>\nReviewed-by: Jacopo Mondi <jacopo@jmondi.org>\n---\n src/ipa/ipu3/ipu3.cpp | 18 ++++++++++++++----\n 1 file changed, 14 insertions(+), 4 deletions(-)", "diff": "diff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp\nindex 8b4c7351..e68e9bb3 100644\n--- a/src/ipa/ipu3/ipu3.cpp\n+++ b/src/ipa/ipu3/ipu3.cpp\n@@ -23,6 +23,7 @@\n \n #include \"ipu3_agc.h\"\n #include \"ipu3_awb.h\"\n+#include \"libipa/camera_sensor_helper.h\"\n \n static constexpr uint32_t kMaxCellWidthPerSet = 160;\n static constexpr uint32_t kMaxCellHeightPerSet = 56;\n@@ -36,10 +37,7 @@ namespace ipa::ipu3 {\n class IPAIPU3 : public IPAIPU3Interface\n {\n public:\n-\tint init([[maybe_unused]] const IPASettings &settings) override\n-\t{\n-\t\treturn 0;\n-\t}\n+\tint init(const IPASettings &settings) override;\n \tint start() override;\n \tvoid stop() override {}\n \n@@ -78,6 +76,8 @@ private:\n \tstd::unique_ptr<IPU3Awb> awbAlgo_;\n \t/* Interface to the AEC/AGC algorithm */\n \tstd::unique_ptr<IPU3Agc> agcAlgo_;\n+\t/* Interface to the Camera Helper */\n+\tstd::unique_ptr<CameraSensorHelper> camHelper_;\n \n \t/* Local parameter storage */\n \tstruct ipu3_uapi_params params_;\n@@ -85,6 +85,16 @@ private:\n \tstruct ipu3_uapi_grid_config bdsGrid_;\n };\n \n+int IPAIPU3::init(const IPASettings &settings)\n+{\n+\tcamHelper_ = CameraSensorHelperFactory::create(settings.sensorModel);\n+\tif (camHelper_ == nullptr) {\n+\t\tLOG(IPAIPU3, Error) << \"Failed to create camera sensor helper for \" << settings.sensorModel;\n+\t\treturn -1;\n+\t}\n+\treturn 0;\n+}\n+\n int IPAIPU3::start()\n {\n \tsetControls(0);\n", "prefixes": [ "libcamera-devel", "v5", "2/2" ] }