Patch Detail
Show a patch.
GET /api/patches/12652/?format=api
{ "id": 12652, "url": "https://patchwork.libcamera.org/api/patches/12652/?format=api", "web_url": "https://patchwork.libcamera.org/patch/12652/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210618183218.449146-1-vedantparanjape160201@gmail.com>", "date": "2021-06-18T18:32:18", "name": "[libcamera-devel,v6] gstreamer: Added virtual functions needed to support request pads", "commit_ref": "53a0d80af0f9983d6bc0d54b0e85403a08721488", "pull_url": null, "state": "accepted", "archived": false, "hash": "b8077dd77cf808af2482f427527f5af70406d8dc", "submitter": { "id": 85, "url": "https://patchwork.libcamera.org/api/people/85/?format=api", "name": "Vedant Paranjape", "email": "vedantparanjape160201@gmail.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/12652/mbox/", "series": [ { "id": 2153, "url": "https://patchwork.libcamera.org/api/series/2153/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2153", "date": "2021-06-18T18:32:18", "name": "[libcamera-devel,v6] gstreamer: Added virtual functions needed to support request pads", "version": 6, "mbox": "https://patchwork.libcamera.org/series/2153/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/12652/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/12652/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 44E5EBD78E\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 18 Jun 2021 18:33:41 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id AF61460298;\n\tFri, 18 Jun 2021 20:33:40 +0200 (CEST)", "from mail-pf1-x432.google.com (mail-pf1-x432.google.com\n\t[IPv6:2607:f8b0:4864:20::432])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2F6A460298\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 18 Jun 2021 20:33:39 +0200 (CEST)", "by mail-pf1-x432.google.com with SMTP id u18so2948235pfk.11\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 18 Jun 2021 11:33:39 -0700 (PDT)", "from localhost.localdomain ([1.186.76.76])\n\tby smtp.googlemail.com with ESMTPSA id\n\tx20sm8557835pfh.112.2021.06.18.11.33.09\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 18 Jun 2021 11:33:36 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"hDyZDHD6\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=3xjAz4DnDkQQMb1D9Gn5VxprtdKfZZMeuFqkSHtIKF0=;\n\tb=hDyZDHD6HPUwjDl6hu4FinP6VqPvpFCtgImqTEc9pgD2v68Zqp63oNmBrXUJ1IcR2L\n\t91K1hIuK60B963JTKLGb1BgXBE4Uqb09LvrLQ7mDc8i1mu1wj2vt6m3VdVxdvulubKay\n\tMRByactl+/yLm+pjMc7z4lLxYWHe53lQDw6oRXWLvSuuv4QqKNyJM22pkc0go0G9K1ca\n\tx376YEe3/TcSt/UNf/NAkrsZTp32Zmp0xsKQ8ks62D5amXN4GhhRkTGqxT7K8ni099V+\n\tOXS9Zh7fKbR4MzGuv/P3T/863rdEYkUEln3H/bca9O6El+G+dOkxEHzb6D6sPEnEcHXp\n\thGkQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=3xjAz4DnDkQQMb1D9Gn5VxprtdKfZZMeuFqkSHtIKF0=;\n\tb=V86cd1h9FDQlJJ8kEwjCBV06s87afmS+671yBCMtb3ihWRIzNqw5+cL6peTEmjDFJv\n\tE91JTUp1H87xabUdor+QUiRwIYwP4h1WBqTiZgyyFag4SfFSxCNt8gPk9c++ODqT3aAO\n\tHzYwbW64hUsY68vVd/pujWngQ78+mSXVMpghfRXwlyaYnXDPDja57YSDTIokoDjp7xwE\n\tOAKZsl3l42tAz9Xa0PzxjpozUzyOKjVamM0FuH/bcBz+ehgRERvDneTXXp87X3JISo1n\n\tYLPcn4K8qTdDbH85yUsD42GT5oE32mEFmWCzIoxsIFdvIAi/TB/JOajqEuCEIeO+y7S9\n\t/c9g==", "X-Gm-Message-State": "AOAM531fZtR/We+WLdvZYZMFgUyFJ+ujgh3eukALcIh+fCUwI+MBwsiP\n\t2Qbw4WkA15LX2yOS+bWBawBMFeUvBdR71w==", "X-Google-Smtp-Source": "ABdhPJz0UD0rioaVtlE4UW97rWB9ujoDfg7+eJWwmUqZ8pAr1Kb2oEaDNHtjYIiup4pbnEqeZGydbQ==", "X-Received": "by 2002:aa7:838b:0:b029:2ea:3332:dd8a with SMTP id\n\tu11-20020aa7838b0000b02902ea3332dd8amr6582216pfm.74.1624041217315; \n\tFri, 18 Jun 2021 11:33:37 -0700 (PDT)", "From": "Vedant Paranjape <vedantparanjape160201@gmail.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Sat, 19 Jun 2021 00:02:18 +0530", "Message-Id": "<20210618183218.449146-1-vedantparanjape160201@gmail.com>", "X-Mailer": "git-send-email 2.25.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v6] gstreamer: Added virtual functions\n\tneeded to support request pads", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Cc": "Vedant Paranjape <vedantparanjape160201@gmail.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "This patch adds support for using request pads in libcamerasrc Gst\nElement. It allows a user to request multiple streams if the platform\nsupports multistream output using libcamera.\n\nThis was tested on Raspberry Pi 4B+ with a camera connected to CSI port.\nIt can be tested by running the following command\n\ngst-launch-1.0 libcamerasrc camera-name=\"<camera-name-here>\" name=src src.src ! queue ! videoconvert ! autovideosink src.src_0 ! queue ! videoconvert ! autovideosink\n\nSigned-off-by: Vedant Paranjape <vedantparanjape160201@gmail.com>\n---\n src/gstreamer/gstlibcamerasrc.cpp | 53 ++++++++++++++++++++++++++++++-\n 1 file changed, 52 insertions(+), 1 deletion(-)", "diff": "diff --git a/src/gstreamer/gstlibcamerasrc.cpp b/src/gstreamer/gstlibcamerasrc.cpp\nindex ccc61590..ea53c2b5 100644\n--- a/src/gstreamer/gstlibcamerasrc.cpp\n+++ b/src/gstreamer/gstlibcamerasrc.cpp\n@@ -361,10 +361,12 @@ gst_libcamera_src_task_enter(GstTask *task, [[maybe_unused]] GThread *thread,\n \tGST_DEBUG_OBJECT(self, \"Streaming thread has started\");\n \n \tguint group_id = gst_util_group_id_next();\n+\tgint stream_id_num = 0;\n \tStreamRoles roles;\n \tfor (GstPad *srcpad : state->srcpads_) {\n \t\t/* Create stream-id and push stream-start. */\n-\t\tg_autofree gchar *stream_id = gst_pad_create_stream_id(srcpad, GST_ELEMENT(self), nullptr);\n+\t\tg_autofree gchar *stream_id_intermediate = g_strdup_printf(\"%i%i\", group_id, stream_id_num++);\n+\t\tg_autofree gchar *stream_id = gst_pad_create_stream_id(srcpad, GST_ELEMENT(self), stream_id_intermediate);\n \t\tGstEvent *event = gst_event_new_stream_start(stream_id);\n \t\tgst_event_set_group_id(event, group_id);\n \t\tgst_pad_push_event(srcpad, event);\n@@ -640,6 +642,53 @@ gst_libcamera_src_init(GstLibcameraSrc *self)\n \tself->state = state;\n }\n \n+static GstPad *\n+gst_libcamera_src_request_new_pad(GstElement *element, GstPadTemplate *templ,\n+\t\t\t\t const gchar *name, [[maybe_unused]] const GstCaps *caps)\n+{\n+\tGstLibcameraSrc *self = GST_LIBCAMERA_SRC(element);\n+\tg_autoptr(GstPad) pad = NULL;\n+\n+\tGST_DEBUG_OBJECT(self, \"new request pad created\");\n+\n+\tpad = gst_pad_new_from_template(templ, name);\n+\tg_object_ref_sink(pad);\n+\n+\tif (gst_element_add_pad(element, pad)) {\n+\t\tGLibLocker lock(GST_OBJECT(self));\n+\t\tself->state->srcpads_.push_back(reinterpret_cast<GstPad *>(g_object_ref(pad)));\n+\t} else {\n+\t\tGST_ELEMENT_ERROR(element, STREAM, FAILED,\n+\t\t\t\t (\"Internal data stream error.\"),\n+\t\t\t\t (\"Could not add pad to element\"));\n+\t\treturn NULL;\n+\t}\n+\n+\treturn reinterpret_cast<GstPad *>(g_steal_pointer(&pad));\n+}\n+\n+static void\n+gst_libcamera_src_release_pad(GstElement *element, GstPad *pad)\n+{\n+\tGstLibcameraSrc *self = GST_LIBCAMERA_SRC(element);\n+\n+\tGST_DEBUG_OBJECT(self, \"Pad %\" GST_PTR_FORMAT \" being released\", pad);\n+\n+\t{\n+\t\tGLibLocker lock(GST_OBJECT(self));\n+\t\tstd::vector<GstPad *> &pads = self->state->srcpads_;\n+\t\tauto begin_iterator = pads.begin();\n+\t\tauto end_iterator = pads.end();\n+\t\tauto pad_iterator = std::find(begin_iterator, end_iterator, pad);\n+\n+\t\tif (pad_iterator != end_iterator) {\n+\t\t\tg_object_unref(*pad_iterator);\n+\t\t\tpads.erase(pad_iterator);\n+\t\t}\n+\t}\n+\tgst_element_remove_pad(element, pad);\n+}\n+\n static void\n gst_libcamera_src_class_init(GstLibcameraSrcClass *klass)\n {\n@@ -650,6 +699,8 @@ gst_libcamera_src_class_init(GstLibcameraSrcClass *klass)\n \tobject_class->get_property = gst_libcamera_src_get_property;\n \tobject_class->finalize = gst_libcamera_src_finalize;\n \n+\telement_class->request_new_pad = gst_libcamera_src_request_new_pad;\n+\telement_class->release_pad = gst_libcamera_src_release_pad;\n \telement_class->change_state = gst_libcamera_src_change_state;\n \n \tgst_element_class_set_metadata(element_class,\n", "prefixes": [ "libcamera-devel", "v6" ] }