Patch Detail
Show a patch.
GET /api/patches/12641/?format=api
{ "id": 12641, "url": "https://patchwork.libcamera.org/api/patches/12641/?format=api", "web_url": "https://patchwork.libcamera.org/patch/12641/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210618103351.1642060-9-paul.elder@ideasonboard.com>", "date": "2021-06-18T10:33:45", "name": "[libcamera-devel,RFC,08/14] android: Plumb AwbMode control", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "391fdf53c63672994251b05332357982cceed2aa", "submitter": { "id": 17, "url": "https://patchwork.libcamera.org/api/people/17/?format=api", "name": "Paul Elder", "email": "paul.elder@ideasonboard.com" }, "delegate": { "id": 17, "url": "https://patchwork.libcamera.org/api/users/17/?format=api", "username": "epaul", "first_name": "Paul", "last_name": "Elder", "email": "paul.elder@ideasonboard.com" }, "mbox": "https://patchwork.libcamera.org/patch/12641/mbox/", "series": [ { "id": 2151, "url": "https://patchwork.libcamera.org/api/series/2151/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2151", "date": "2021-06-18T10:33:37", "name": "Preliminary FULL plumbing", "version": 1, "mbox": "https://patchwork.libcamera.org/series/2151/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/12641/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/12641/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id AB4CDBD78E\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 18 Jun 2021 10:34:17 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 60DCF6050D;\n\tFri, 18 Jun 2021 12:34:17 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9A80768942\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 18 Jun 2021 12:34:15 +0200 (CEST)", "from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 300AC3E5;\n\tFri, 18 Jun 2021 12:34:13 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"j3z/HEky\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1624012455;\n\tbh=EW0UAEsn953yfsNjHn/JEiHyaxTzFEndifV4wA/fhxA=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=j3z/HEkyF369rLHwhQPod9Qa8euyhvIhEHWQyXVA662JqnF67tx+RucGwqWRTnW00\n\tzuunFic1BhwxsywtITwb8zK2seYk9uWEv7nU5ck5OypCATPB2Qo2wRjGAndJeGPBIb\n\tn+vAFkn54DW7eHE4m/tysD0NYprYTeR/oD3QVix8=", "From": "Paul Elder <paul.elder@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 18 Jun 2021 19:33:45 +0900", "Message-Id": "<20210618103351.1642060-9-paul.elder@ideasonboard.com>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20210618103351.1642060-1-paul.elder@ideasonboard.com>", "References": "<20210618103351.1642060-1-paul.elder@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [RFC PATCH 08/14] android: Plumb AwbMode control", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Plumb the AwbMode control into the HAL for\nCONTROL_AWB_AVAILABLE_MODES for static metadata.\n\nBug: https://bugs.libcamera.org/show_bug.cgi?id=44\nSigned-off-by: Paul Elder <paul.elder@ideasonboard.com>\n\n---\nTODO: plumb result metadata\n---\n src/android/camera_device.cpp | 26 ++++++++++++++++++--------\n 1 file changed, 18 insertions(+), 8 deletions(-)", "diff": "diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\nindex 3add5bc6..a8b6fa38 100644\n--- a/src/android/camera_device.cpp\n+++ b/src/android/camera_device.cpp\n@@ -985,15 +985,25 @@ const camera_metadata_t *CameraDevice::getStaticMetadata()\n \tstaticMetadata_->addEntry(ANDROID_CONTROL_AVAILABLE_VIDEO_STABILIZATION_MODES,\n \t\t\t\t availableStabilizationModes);\n \n-\t/*\n-\t * \\todo Inspect the Camera capabilities to report the available\n-\t * AWB modes. Default to AUTO as CTS tests require it.\n-\t */\n-\tstd::vector<uint8_t> availableAwbModes = {\n-\t\tANDROID_CONTROL_AWB_MODE_AUTO,\n-\t};\n+\tstd::vector<uint8_t> awbAvailableModes;\n+\tawbAvailableModes.reserve(2);\n+\tconst auto &awbModesInfo = controlsInfo.find(&controls::AwbMode);\n+\tif (awbModesInfo != controlsInfo.end()) {\n+\t\tfor (const auto &value : awbModesInfo->second.values())\n+\t\t\tawbAvailableModes.push_back(value.get<int32_t>());\n+\t} else {\n+\t\tawbAvailableModes.push_back(ANDROID_CONTROL_AWB_MODE_AUTO);\n+\t}\n+\n+\tif (std::find(awbAvailableModes.begin(),\n+\t\t awbAvailableModes.end(),\n+\t\t ANDROID_CONTROL_AWB_MODE_OFF) == awbAvailableModes.end()) {\n+\t\tfullSupport = false;\n+\t\t/* \\todo Double check if this is the correct capability */\n+\t\tcapabilities[ANDROID_REQUEST_AVAILABLE_CAPABILITIES_MANUAL_POST_PROCESSING] = false;\n+\t}\n \tstaticMetadata_->addEntry(ANDROID_CONTROL_AWB_AVAILABLE_MODES,\n-\t\t\t\t availableAwbModes);\n+\t\t\t\t awbAvailableModes);\n \n \tstd::vector<int32_t> availableMaxRegions = {\n \t\t0, 0, 0,\n", "prefixes": [ "libcamera-devel", "RFC", "08/14" ] }