Patch Detail
Show a patch.
GET /api/patches/12639/?format=api
{ "id": 12639, "url": "https://patchwork.libcamera.org/api/patches/12639/?format=api", "web_url": "https://patchwork.libcamera.org/patch/12639/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210618103351.1642060-7-paul.elder@ideasonboard.com>", "date": "2021-06-18T10:33:43", "name": "[libcamera-devel,RFC,06/14] android: Plumb AeEnable control", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "52b60e50300e50e4dd2f1a2bc4cc7b0f146120a3", "submitter": { "id": 17, "url": "https://patchwork.libcamera.org/api/people/17/?format=api", "name": "Paul Elder", "email": "paul.elder@ideasonboard.com" }, "delegate": { "id": 17, "url": "https://patchwork.libcamera.org/api/users/17/?format=api", "username": "epaul", "first_name": "Paul", "last_name": "Elder", "email": "paul.elder@ideasonboard.com" }, "mbox": "https://patchwork.libcamera.org/patch/12639/mbox/", "series": [ { "id": 2151, "url": "https://patchwork.libcamera.org/api/series/2151/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2151", "date": "2021-06-18T10:33:37", "name": "Preliminary FULL plumbing", "version": 1, "mbox": "https://patchwork.libcamera.org/series/2151/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/12639/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/12639/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E4CD7C3219\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 18 Jun 2021 10:34:12 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A9D9D68943;\n\tFri, 18 Jun 2021 12:34:12 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E701D60298\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 18 Jun 2021 12:34:11 +0200 (CEST)", "from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7C0FF3E5;\n\tFri, 18 Jun 2021 12:34:10 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"FlwYk9+V\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1624012451;\n\tbh=Co965+o+kEO4rsN9l1QBlKtc1l/sUICPybNaaYUwMTg=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=FlwYk9+Va1vcLfIXsGJDEyCuW+dfDiwnhuW7pIF24YCfQVr8IsYhuuGchp2Ear3cY\n\tb1fswtRncNb2yC0XzuvTCWCh/R1uLBzomV/Rx8/opJsqYsfaG0pkY5TAL2tumJpSQs\n\twJjA6S3xv1O/5wqErqaFg/HDtC0mzaBkLCFjkHoo=", "From": "Paul Elder <paul.elder@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 18 Jun 2021 19:33:43 +0900", "Message-Id": "<20210618103351.1642060-7-paul.elder@ideasonboard.com>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20210618103351.1642060-1-paul.elder@ideasonboard.com>", "References": "<20210618103351.1642060-1-paul.elder@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [RFC PATCH 06/14] android: Plumb AeEnable control", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Plumb the AeEnable control into the HAL for CONTROL_AE_AVAILABLE_MODES\nfor static metadata, and CONTROL_AE_MODE for result metadata.\n\nBug: https://bugs.libcamera.org/show_bug.cgi?id=42\nSigned-off-by: Paul Elder <paul.elder@ideasonboard.com>\n---\n src/android/camera_device.cpp | 28 +++++++++++++++++++++++-----\n 1 file changed, 23 insertions(+), 5 deletions(-)", "diff": "diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\nindex 86f47e00..3446cdb6 100644\n--- a/src/android/camera_device.cpp\n+++ b/src/android/camera_device.cpp\n@@ -10,6 +10,7 @@\n #include \"camera_ops.h\"\n #include \"post_processor.h\"\n \n+#include <algorithm>\n #include <array>\n #include <cmath>\n #include <fstream>\n@@ -877,9 +878,24 @@ const camera_metadata_t *CameraDevice::getStaticMetadata()\n \tstaticMetadata_->addEntry(ANDROID_CONTROL_AE_AVAILABLE_ANTIBANDING_MODES,\n \t\t\t\t aeAvailableAntiBandingModes);\n \n-\tstd::vector<uint8_t> aeAvailableModes = {\n-\t\tANDROID_CONTROL_AE_MODE_ON,\n-\t};\n+\tstd::vector<uint8_t> aeAvailableModes;\n+\taeAvailableModes.reserve(2);\n+\tconst auto &aeModesInfo = controlsInfo.find(&controls::AeEnable);\n+\tif (aeModesInfo != controlsInfo.end()) {\n+\t\taeAvailableModes.push_back(aeModesInfo->second.min().get<bool>());\n+\t\tif (aeModesInfo->second.min() != aeModesInfo->second.max())\n+\t\t\taeAvailableModes.push_back(aeModesInfo->second.max().get<bool>());\n+\t} else {\n+\t\taeAvailableModes.push_back(ANDROID_CONTROL_AE_MODE_ON);\n+\t}\n+\n+\tif (std::find(aeAvailableModes.begin(),\n+\t\t aeAvailableModes.end(),\n+\t\t ANDROID_CONTROL_AE_MODE_OFF) == aeAvailableModes.end()) {\n+\t\tfullSupport = false;\n+\t\t/* \\todo Double check if this is the correct capability */\n+\t\tcapabilities[ANDROID_REQUEST_AVAILABLE_CAPABILITIES_MANUAL_SENSOR] = false;\n+\t}\n \tstaticMetadata_->addEntry(ANDROID_CONTROL_AE_AVAILABLE_MODES,\n \t\t\t\t aeAvailableModes);\n \n@@ -2333,8 +2349,10 @@ CameraDevice::getResultMetadata(const Camera3RequestDescriptor &descriptor) cons\n \tvalue = ANDROID_CONTROL_AE_LOCK_OFF;\n \tresultMetadata->addEntry(ANDROID_CONTROL_AE_LOCK, value);\n \n-\tvalue = ANDROID_CONTROL_AE_MODE_ON;\n-\tresultMetadata->addEntry(ANDROID_CONTROL_AE_MODE, value);\n+\tif (metadata.contains(controls::AeEnable)) {\n+\t\tuint8_t aeMode = metadata.get<bool>(controls::AeEnable);\n+\t\tresultMetadata->addEntry(ANDROID_CONTROL_AE_MODE, aeMode);\n+\t}\n \n \tif (settings.getEntry(ANDROID_CONTROL_AE_TARGET_FPS_RANGE, &entry))\n \t\t/*\n", "prefixes": [ "libcamera-devel", "RFC", "06/14" ] }