Patch Detail
Show a patch.
GET /api/patches/12615/?format=api
{ "id": 12615, "url": "https://patchwork.libcamera.org/api/patches/12615/?format=api", "web_url": "https://patchwork.libcamera.org/patch/12615/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210616132535.453411-6-nfraprado@collabora.com>", "date": "2021-06-16T13:25:35", "name": "[libcamera-devel,v8,5/5] lc-compliance: Add list and filter parameters", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "6afd17aa2ddfc56a9d872815535ef9677f26c7b8", "submitter": { "id": 84, "url": "https://patchwork.libcamera.org/api/people/84/?format=api", "name": "Nícolas F. R. A. Prado", "email": "nfraprado@collabora.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/12615/mbox/", "series": [ { "id": 2141, "url": "https://patchwork.libcamera.org/api/series/2141/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2141", "date": "2021-06-16T13:25:30", "name": "lc-compliance: Refactor using Googletest", "version": 8, "mbox": "https://patchwork.libcamera.org/series/2141/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/12615/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/12615/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id AB41FBD78E\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 16 Jun 2021 13:26:59 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 779A46892F;\n\tWed, 16 Jun 2021 15:26:59 +0200 (CEST)", "from bhuna.collabora.co.uk (bhuna.collabora.co.uk [46.235.227.227])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id F07CB6029A\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 16 Jun 2021 15:26:57 +0200 (CEST)", "from localhost.localdomain (unknown\n\t[IPv6:2804:14c:1a9:2434:2243:2b27:a2be:44ab])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128\n\tbits))\n\t(No client certificate requested) (Authenticated sender: nfraprado)\n\tby bhuna.collabora.co.uk (Postfix) with ESMTPSA id 1F0831F43720;\n\tWed, 16 Jun 2021 14:26:54 +0100 (BST)" ], "From": "=?utf-8?b?TsOtY29sYXMgRi4gUi4gQS4gUHJhZG8=?= <nfraprado@collabora.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Wed, 16 Jun 2021 10:25:35 -0300", "Message-Id": "<20210616132535.453411-6-nfraprado@collabora.com>", "X-Mailer": "git-send-email 2.32.0", "In-Reply-To": "<20210616132535.453411-1-nfraprado@collabora.com>", "References": "<20210616132535.453411-1-nfraprado@collabora.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v8 5/5] lc-compliance: Add list and filter\n\tparameters", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Cc": "kernel@collabora.com, =?utf-8?q?Andr=C3=A9_Almeida?=\n\t<andrealmeid@collabora.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Add a --list parameter that lists all current tests (by mapping to\ngoogletest's --gtest_list_tests).\n\nAdd a --filter 'filterString' parameter that filters the tests to run\n(by mapping to googletest's --gtest_filter).\n\nSigned-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>\nReviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\n---\nChanges in v8:\n- Thanks to Kieran:\n - Switched from malloc/free to new/delete in gtest parameter allocation\n\nChanges in v7:\n- Thanks to Niklas:\n - Removed intermediary filter string variable in Harness::initGtestParameters()\n\nChanges in v6:\n- Thanks to Niklas:\n - Changed buildGtestParameters() into initGtestParameters() and removed the\n need for Harness::gtestArgc_ and Harness::gtestArgv_\n\nChanges in v5:\n- Thanks to Niklas:\n - Moved buildGtestParameters() inside run()\n\nNo changes in v4\n\n src/lc-compliance/main.cpp | 68 +++++++++++++++++++++++++++++++++++---\n 1 file changed, 64 insertions(+), 4 deletions(-)", "diff": "diff --git a/src/lc-compliance/main.cpp b/src/lc-compliance/main.cpp\nindex 8c18845141de..bf9920008827 100644\n--- a/src/lc-compliance/main.cpp\n+++ b/src/lc-compliance/main.cpp\n@@ -20,6 +20,8 @@ using namespace libcamera;\n \n enum {\n \tOptCamera = 'c',\n+\tOptList = 'l',\n+\tOptFilter = 'f',\n \tOptHelp = 'h',\n };\n \n@@ -45,13 +47,17 @@ public:\n \t~Harness();\n \n \tint init();\n-\tint run(int argc, char **argv);\n+\tint run(char *arg0);\n \n private:\n+\tint initGtestParameters(char *arg0);\n \tvoid listCameras();\n \n \tOptionsParser::Options options_;\n \tstd::unique_ptr<CameraManager> cm_;\n+\n+\tconst std::map<std::string, std::string> gtestFlag_ = { { \"list\", \"--gtest_list_tests\" },\n+\t\t\t\t\t\t\t\t{ \"filter\", \"--gtest_filter\" } };\n };\n \n Harness::Harness(const OptionsParser::Options &options)\n@@ -76,6 +82,12 @@ int Harness::init()\n \t\treturn ret;\n \t}\n \n+\t/*\n+\t * No need to initialize the camera if we'll just list tests\n+\t */\n+\tif (options_.isSet(OptList))\n+\t\treturn 0;\n+\n \tif (!options_.isSet(OptCamera)) {\n \t\tstd::cout << \"No camera specified, available cameras:\" << std::endl;\n \t\tlistCameras();\n@@ -97,9 +109,11 @@ int Harness::init()\n \treturn 0;\n }\n \n-int Harness::run(int argc, char **argv)\n+int Harness::run(char *arg0)\n {\n-\t::testing::InitGoogleTest(&argc, argv);\n+\tint ret = initGtestParameters(arg0);\n+\tif (ret)\n+\t\treturn ret;\n \n \ttesting::UnitTest::GetInstance()->listeners().Append(new ThrowListener);\n \n@@ -112,12 +126,58 @@ void Harness::listCameras()\n \t\tstd::cout << \"- \" << cam.get()->id() << std::endl;\n }\n \n+int Harness::initGtestParameters(char *arg0)\n+{\n+\tint argc = 0;\n+\t/*\n+\t * +2 to have space for both the 0th argument that is needed but not\n+\t * used and the null at the end.\n+\t */\n+\tchar **argv = new char *[(gtestFlag_.size() + 2)];\n+\tstd::string filterParam;\n+\n+\tif (!argv)\n+\t\treturn -ENOMEM;\n+\n+\targv[argc] = arg0;\n+\targc++;\n+\n+\tif (options_.isSet(OptList)) {\n+\t\targv[argc] = const_cast<char *>(gtestFlag_.at(\"list\").c_str());\n+\t\targc++;\n+\t}\n+\n+\tif (options_.isSet(OptFilter)) {\n+\t\t/*\n+\t\t * The filter flag needs to be passed as a single parameter, in\n+\t\t * the format --gtest_filter=filterStr\n+\t\t */\n+\t\tfilterParam = gtestFlag_.at(\"filter\") + \"=\" +\n+\t\t\t static_cast<const std::string &>(options_[OptFilter]);\n+\n+\t\targv[argc] = const_cast<char *>(filterParam.c_str());\n+\t\targc++;\n+\t}\n+\n+\targv[argc] = 0;\n+\n+\t::testing::InitGoogleTest(&argc, argv);\n+\n+\tdelete argv;\n+\n+\treturn 0;\n+}\n+\n static int parseOptions(int argc, char **argv, OptionsParser::Options *options)\n {\n \tOptionsParser parser;\n \tparser.addOption(OptCamera, OptionString,\n \t\t\t \"Specify which camera to operate on, by id\", \"camera\",\n \t\t\t ArgumentRequired, \"camera\");\n+\tparser.addOption(OptList, OptionNone, \"List all tests and exit\", \"list\");\n+\tparser.addOption(OptFilter, OptionString,\n+\t\t\t \"Specify which tests to run\", \"filter\",\n+\t\t\t ArgumentRequired, \"filter\");\n \tparser.addOption(OptHelp, OptionNone, \"Display this help message\",\n \t\t\t \"help\");\n \n@@ -147,5 +207,5 @@ int main(int argc, char **argv)\n \tif (ret)\n \t\treturn ret;\n \n-\treturn harness.run(argc, argv);\n+\treturn harness.run(argv[0]);\n }\n", "prefixes": [ "libcamera-devel", "v8", "5/5" ] }