Patch Detail
Show a patch.
GET /api/patches/12609/?format=api
{ "id": 12609, "url": "https://patchwork.libcamera.org/api/patches/12609/?format=api", "web_url": "https://patchwork.libcamera.org/patch/12609/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210616095617.3593384-1-kieran.bingham@ideasonboard.com>", "date": "2021-06-16T09:56:17", "name": "[libcamera-devel] libcamera: pipeline: ipu3: Report error when failing to configure", "commit_ref": "3c9c2870e226950bd2a4ed98488aae0be6fea3b6", "pull_url": null, "state": "accepted", "archived": false, "hash": "c534565049b8379624d834fc05931d84be7c2afd", "submitter": { "id": 4, "url": "https://patchwork.libcamera.org/api/people/4/?format=api", "name": "Kieran Bingham", "email": "kieran.bingham@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/12609/mbox/", "series": [ { "id": 2140, "url": "https://patchwork.libcamera.org/api/series/2140/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2140", "date": "2021-06-16T09:56:17", "name": "[libcamera-devel] libcamera: pipeline: ipu3: Report error when failing to configure", "version": 1, "mbox": "https://patchwork.libcamera.org/series/2140/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/12609/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/12609/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 322EEC3218\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 16 Jun 2021 09:56:24 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E9C0068946;\n\tWed, 16 Jun 2021 11:56:23 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 09A356050C\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 16 Jun 2021 11:56:22 +0200 (CEST)", "from Monstersaurus.local\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9831BF88;\n\tWed, 16 Jun 2021 11:56:21 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"baYNzfKY\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1623837381;\n\tbh=AMb05Bxuigwcq1hbgEAaTqZPIAxZ8VI2ukgFNTBA5V4=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=baYNzfKYv8eCdHM4+1TEZhqb/4dveERme8VLkv+JtYh0diyIjuLApdEFfOjRrkHmb\n\tv9OFendBYFyrVRvkIybiTuCu/98XI/owyABOMTPyj7vTSH1bm7v8ydJNd2KDGfvIdV\n\tyk+dQleFUL07hvc16KbitSarfs9eXzxU5NTEKFTo=", "From": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "To": "libcamera devel <libcamera-devel@lists.libcamera.org>", "Date": "Wed, 16 Jun 2021 10:56:17 +0100", "Message-Id": "<20210616095617.3593384-1-kieran.bingham@ideasonboard.com>", "X-Mailer": "git-send-email 2.30.2", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH] libcamera: pipeline: ipu3: Report error\n\twhen failing to configure", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "If the IPA fails to configure, this can now be caught by the pipeline handler\nbut the cause may not be clear.\n\nIf the IPA is isolated, then reports from that IPA will not be visible\nin the libcamera logs directly.\n\nPrint the return error value to help identify any issue that has arisen.\n\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n src/libcamera/pipeline/ipu3/ipu3.cpp | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)", "diff": "diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\nindex 35f1e977ab19..113e70a5e692 100644\n--- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n+++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n@@ -644,7 +644,8 @@ int PipelineHandlerIPU3::configure(Camera *camera, CameraConfiguration *c)\n \n \tret = data->ipa_->configure(configInfo);\n \tif (ret) {\n-\t\tLOG(IPU3, Error) << \"Failed to configure IPA\";\n+\t\tLOG(IPU3, Error) << \"Failed to configure IPA: \"\n+\t\t\t\t << strerror(-ret);\n \t\treturn ret;\n \t}\n \n", "prefixes": [ "libcamera-devel" ] }