Patch Detail
Show a patch.
GET /api/patches/12607/?format=api
{ "id": 12607, "url": "https://patchwork.libcamera.org/api/patches/12607/?format=api", "web_url": "https://patchwork.libcamera.org/patch/12607/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210616085923.2888083-1-hiroh@chromium.org>", "date": "2021-06-16T08:59:23", "name": "[libcamera-devel] android: mm: cros_camera_buffer: Fix wrong indexing in plane()", "commit_ref": "e4e3af642e03b57123c472ce743fdf8eb08e016a", "pull_url": null, "state": "accepted", "archived": false, "hash": "79bc64572eb0a694b0c41f6401ae612e7abb3de6", "submitter": { "id": 63, "url": "https://patchwork.libcamera.org/api/people/63/?format=api", "name": "Hirokazu Honda", "email": "hiroh@chromium.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/12607/mbox/", "series": [ { "id": 2138, "url": "https://patchwork.libcamera.org/api/series/2138/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2138", "date": "2021-06-16T08:59:23", "name": "[libcamera-devel] android: mm: cros_camera_buffer: Fix wrong indexing in plane()", "version": 1, "mbox": "https://patchwork.libcamera.org/series/2138/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/12607/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/12607/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E9527BD78E\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 16 Jun 2021 08:59:32 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 38CC368943;\n\tWed, 16 Jun 2021 10:59:32 +0200 (CEST)", "from mail-pj1-x1031.google.com (mail-pj1-x1031.google.com\n\t[IPv6:2607:f8b0:4864:20::1031])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 77E5A6892E\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 16 Jun 2021 10:59:30 +0200 (CEST)", "by mail-pj1-x1031.google.com with SMTP id g24so1315152pji.4\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 16 Jun 2021 01:59:30 -0700 (PDT)", "from hiroh2.tok.corp.google.com\n\t([2401:fa00:8f:203:9a9a:c503:6402:b9b1])\n\tby smtp.gmail.com with ESMTPSA id\n\t76sm1500186pfy.82.2021.06.16.01.59.27\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 16 Jun 2021 01:59:28 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"ZAFM9vvB\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; h=from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=qRXDNQnCHnORHrJufRa3CDb5zGF1h6KYEFlPwWqG8tg=;\n\tb=ZAFM9vvBVC4/IzH4ffLzNi1gHrU188KORY2Z7i/QALHekorlhTzHs8u193p53P8oL6\n\toXQ1pTLjk4iOFF8i0r+rrM5FqpmmkeJtob4dqHE9KhFvAKNwxpvdIR98cfsjtuE5suvy\n\tnzqxZ2aO45PlzLJxey1jFJpKuu8ESm+xWSkCM=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=qRXDNQnCHnORHrJufRa3CDb5zGF1h6KYEFlPwWqG8tg=;\n\tb=Jc/k98QJPtxH+SK2vUAxlexNBkfHAP/DR/VuKBk5SU3gcRtXuPtWhoYBhGvyixVugR\n\taG66Nahf7B1KPhYem+VtH+S1IWhi1xyeCZtGftrMZBVwqK/oeEbmusSoI9U8K0pvs+P3\n\tOiCl/fP7cAYxhVSYammGtVvOcl4QJ7X43UQUiE2hnXmiqQ7jEDiqHvynq30GtfhGwDbY\n\t2rDzVB0SbgFw7WyZQjOqVGytObs7cj4kMO+RZBMUjDTfcgYodO5eZjaoOyVE9XfMSfmJ\n\tya7naWUPcDC6mlDcR+BjhDxJPIJZ6NNIVC4BTIRJt8tr1z7AU+ZIc5egbR7GykWKcdiS\n\tzP9A==", "X-Gm-Message-State": "AOAM530Va3MDGQzUfrsT71bTJhDfGC0h1nqILFYYwj0b2BXm7kswgUHC\n\too2pcY5PrBMdS0FsS9LcKeYz5f/Sv9P3rw==", "X-Google-Smtp-Source": "ABdhPJxlTSKCJvOZZU6iC0ATkObj66r9YqGitnvQu39OTWq0N72V5lZQu7XSDNostsnbwz4rdISUCg==", "X-Received": "by 2002:a17:90a:9411:: with SMTP id\n\tr17mr3908801pjo.49.1623833968553; \n\tWed, 16 Jun 2021 01:59:28 -0700 (PDT)", "From": "Hirokazu Honda <hiroh@chromium.org>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Wed, 16 Jun 2021 17:59:23 +0900", "Message-Id": "<20210616085923.2888083-1-hiroh@chromium.org>", "X-Mailer": "git-send-email 2.32.0.272.g935e593368-goog", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH] android: mm: cros_camera_buffer: Fix\n\twrong indexing in plane()", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "CameraBuffer::plane() should be accessed in zero based index.\nFix the wrong indexing in CameraBuffer::plane() in\ncros_camera_buffer.cpp.\n\nSigned-off-by: Hirokazu Honda <hiroh@chromium.org>\n---\n src/android/mm/cros_camera_buffer.cpp | 6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)", "diff": "diff --git a/src/android/mm/cros_camera_buffer.cpp b/src/android/mm/cros_camera_buffer.cpp\nindex 59e26d1b..c4157606 100644\n--- a/src/android/mm/cros_camera_buffer.cpp\n+++ b/src/android/mm/cros_camera_buffer.cpp\n@@ -113,13 +113,13 @@ Span<uint8_t> CameraBuffer::Private::plane(unsigned int plane)\n \t\tbreak;\n \tdefault:\n \t\tswitch (plane) {\n-\t\tcase 1:\n+\t\tcase 0:\n \t\t\taddr = mem.ycbcr.y;\n \t\t\tbreak;\n-\t\tcase 2:\n+\t\tcase 1:\n \t\t\taddr = mem.ycbcr.cb;\n \t\t\tbreak;\n-\t\tcase 3:\n+\t\tcase 2:\n \t\t\taddr = mem.ycbcr.cr;\n \t\t\tbreak;\n \t\t}\n", "prefixes": [ "libcamera-devel" ] }