Patch Detail
Show a patch.
GET /api/patches/126/?format=api
{ "id": 126, "url": "https://patchwork.libcamera.org/api/patches/126/?format=api", "web_url": "https://patchwork.libcamera.org/patch/126/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20190101212947.28098-6-kieran.bingham@ideasonboard.com>", "date": "2019-01-01T21:29:47", "name": "[libcamera-devel,5/5] libcamera: Remove libcamera class", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "738a9ef53af2c3ea38b6880f1d103f44631639ea", "submitter": { "id": 4, "url": "https://patchwork.libcamera.org/api/people/4/?format=api", "name": "Kieran Bingham", "email": "kieran.bingham@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/126/mbox/", "series": [ { "id": 46, "url": "https://patchwork.libcamera.org/api/series/46/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=46", "date": "2019-01-01T21:29:42", "name": "test: Unit Test Improvements", "version": 1, "mbox": "https://patchwork.libcamera.org/series/46/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/126/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/126/checks/", "tags": {}, "headers": { "Return-Path": "<kieran.bingham@ideasonboard.com>", "Received": [ "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 71BB660B34\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 1 Jan 2019 22:29:53 +0100 (CET)", "from localhost.localdomain\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E40381173;\n\tTue, 1 Jan 2019 22:29:52 +0100 (CET)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1546378193;\n\tbh=y62Z5v0Dk62YxWcK+69sDcAC7FqfBI4qukPhaSgI2gU=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=Ilsi/O9qwK8exehC7lOlkv03OBFNpvp8mLyOm9qGYcoh2zLe16I1h19XYqwvt94bT\n\t4oyYQVIo4+Ri3By+Ks1MND3R3nOi8EzOEKbPSGz+AWl/uORM+udXgF+aMxakKMPtgZ\n\tFCwjJqCRogePO2U7m25FhPJyyMAmQ6QJ410wyF5Q=", "From": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "To": "LibCamera Devel <libcamera-devel@lists.libcamera.org>", "Date": "Tue, 1 Jan 2019 21:29:47 +0000", "Message-Id": "<20190101212947.28098-6-kieran.bingham@ideasonboard.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20190101212947.28098-1-kieran.bingham@ideasonboard.com>", "References": "<20190101212947.28098-1-kieran.bingham@ideasonboard.com>", "Subject": "[libcamera-devel] [PATCH 5/5] libcamera: Remove libcamera class", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.23", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Tue, 01 Jan 2019 21:29:54 -0000" }, "content": "From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\nThe class was just a placeholder, now that we have other objects\ndefined, remove it along with the associated test.\n\nThe libcamera/libcamera.h header is kept as a shortcut to include the\nwhole libcamera public API.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n[Kieran: Rebase to master]\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n include/libcamera/libcamera.h | 10 ----------\n src/libcamera/main.cpp | 19 -------------------\n src/libcamera/meson.build | 1 -\n test/init.cpp | 16 ----------------\n test/meson.build | 1 -\n 5 files changed, 47 deletions(-)\n delete mode 100644 src/libcamera/main.cpp\n delete mode 100644 test/init.cpp", "diff": "diff --git a/include/libcamera/libcamera.h b/include/libcamera/libcamera.h\nindex 32fb1ff741a7..f9556a8bce62 100644\n--- a/include/libcamera/libcamera.h\n+++ b/include/libcamera/libcamera.h\n@@ -10,14 +10,4 @@\n #include <libcamera/camera.h>\n #include <libcamera/camera_manager.h>\n \n-namespace libcamera {\n-\n-class libcamera\n-{\n-public:\n-\tvoid init_lib(void);\n-};\n-\n-};\n-\n #endif /* __LIBCAMERA_LIBCAMERA_H__ */\ndiff --git a/src/libcamera/main.cpp b/src/libcamera/main.cpp\ndeleted file mode 100644\nindex 7ed37dfcfd5b..000000000000\n--- a/src/libcamera/main.cpp\n+++ /dev/null\n@@ -1,19 +0,0 @@\n-/* SPDX-License-Identifier: LGPL-2.1-or-later */\n-/*\n- * Copyright (C) 2018, Google Inc.\n- *\n- * main.cpp - libcamera main class\n- */\n-\n-#include <libcamera/libcamera.h>\n-\n-#include \"log.h\"\n-\n-namespace libcamera {\n-\n-void libcamera::init_lib(void)\n-{\n-\tLOG(Info) << \"Lib Camera Init\";\n-}\n-\n-};\ndiff --git a/src/libcamera/meson.build b/src/libcamera/meson.build\nindex 2ff5bb5e7515..78562299fc42 100644\n--- a/src/libcamera/meson.build\n+++ b/src/libcamera/meson.build\n@@ -3,7 +3,6 @@ libcamera_sources = files([\n 'camera_manager.cpp',\n 'device_enumerator.cpp',\n 'log.cpp',\n- 'main.cpp',\n 'media_device.cpp',\n 'media_object.cpp',\n 'pipeline_handler.cpp',\ndiff --git a/test/init.cpp b/test/init.cpp\ndeleted file mode 100644\nindex 4ade4e7690fc..000000000000\n--- a/test/init.cpp\n+++ /dev/null\n@@ -1,16 +0,0 @@\n-/* SPDX-License-Identifier: GPL-2.0-or-later */\n-/*\n- * Copyright (C) 2018, Google Inc.\n- *\n- * init.cpp - libcamera initialization test\n- */\n-\n-#include <libcamera/libcamera.h>\n-\n-int main(void)\n-{\n-\tlibcamera::libcamera l = libcamera::libcamera();\n-\tl.init_lib();\n-\n-\treturn 0;\n-}\ndiff --git a/test/meson.build b/test/meson.build\nindex 9270a55e052a..184a7eeb5e27 100644\n--- a/test/meson.build\n+++ b/test/meson.build\n@@ -3,7 +3,6 @@ subdir('libtest')\n subdir('media_device')\n \n public_tests = [\n- ['test_init', 'init.cpp'],\n ['list', 'list.cpp'],\n ]\n \n", "prefixes": [ "libcamera-devel", "5/5" ] }