Patch Detail
Show a patch.
GET /api/patches/12598/?format=api
{ "id": 12598, "url": "https://patchwork.libcamera.org/api/patches/12598/?format=api", "web_url": "https://patchwork.libcamera.org/patch/12598/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210615105139.16171-3-david.plowman@raspberrypi.com>", "date": "2021-06-15T10:51:38", "name": "[libcamera-devel,2/3] libcamera: ipa: raspberrypi: Demote warnings about lack of AWB results", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "5344ad06dfd5709e3193fa70d0b0904c87f238fe", "submitter": { "id": 42, "url": "https://patchwork.libcamera.org/api/people/42/?format=api", "name": "David Plowman", "email": "david.plowman@raspberrypi.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/12598/mbox/", "series": [ { "id": 2135, "url": "https://patchwork.libcamera.org/api/series/2135/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2135", "date": "2021-06-15T10:51:36", "name": "Support monochrome raw sensors", "version": 1, "mbox": "https://patchwork.libcamera.org/series/2135/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/12598/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/12598/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CFDD0BD78E\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 15 Jun 2021 10:51:47 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 915DD68948;\n\tTue, 15 Jun 2021 12:51:47 +0200 (CEST)", "from mail-wm1-x335.google.com (mail-wm1-x335.google.com\n\t[IPv6:2a00:1450:4864:20::335])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CDEFF68949\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 15 Jun 2021 12:51:43 +0200 (CEST)", "by mail-wm1-x335.google.com with SMTP id\n\th11-20020a05600c350bb02901b59c28e8b4so1456370wmq.1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 15 Jun 2021 03:51:43 -0700 (PDT)", "from pi4-davidp.pitowers.org\n\t([2a00:1098:3142:14:1ce1:9965:4328:89c4])\n\tby smtp.gmail.com with ESMTPSA id\n\tu15sm1796300wmq.48.2021.06.15.03.51.42\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 15 Jun 2021 03:51:42 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"jSG9JzmL\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=QVArBmBrjrypsLGJa1m5fvTRw+qpuCABtPTcmqBl12A=;\n\tb=jSG9JzmL7FH1Ntj7dKStsCVZYENy1MFtP3z1IqyYGNFYNJPhdRAwBAO2V6kJqvd4Mb\n\tmJAUPJ75mpuXT78PGfs6U9HYx+WFg5Rbob6EXmDULigaUwJPCu6LbIZCMgA6hLmL6oAA\n\tm2/dEuiLuaO1vrjIThbINBrnfb1UR3e5pDYM/95+j1KIztbzh1NuDnD6wCGLZi4CRY6l\n\tfCAZMjhRukR5E72ROTCPzoSfF5/lpsROlVEbSO3cVbGe4toK3NneM7yHbzyQrrEfaXjG\n\t3hvWHcUFTIH52sq8QHtA3hI4je8IgEkQPy+3vHHbT6e7IN9doFqniGwLluSJlq4yIZKu\n\t4BIA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=QVArBmBrjrypsLGJa1m5fvTRw+qpuCABtPTcmqBl12A=;\n\tb=mGyhr2i0mab9DiGz40b/906OhZKUiUF7/8GXwcSL4IY29JfNd9OJr5l2dJraq2EWNF\n\tRsfNQLKN7iGH3+TL6UkZDjS2b/L8alWCDoc7ZfGw/nyHCT6tCMhf1nvAdORYN8QDqcCl\n\tTbgtWt+8B887/iuBTHrnfq7iWd4Aio0Wp1ohXzJ3zOhrTyZdkhb1LmCIHSDsYPm74PTA\n\tiaTZPKRopFqTbxgZ0veC54rC/im0ouDJp3IuOPZXTtuqKs1uSw9hRetaY4nTi5WNZryV\n\tVApQMAbJ8eNoeOQDqw5vxv9hXgjf0g5RfhYwPPEnrVOZ/POhnjiN0ScD01oFZ+85DWMT\n\t5img==", "X-Gm-Message-State": "AOAM530nQWVrJVpdAH6P0b2KpDtcsKcrwZ8dgD405tfTB55NBOAB/w4d\n\t4GHWICWZ66kN6JPLG+SoC5O75APN0paD8eua", "X-Google-Smtp-Source": "ABdhPJyvwVCV5Sbtgc8uc0CKRofwOsC6O2KnQQ2jMwVcp/bUxmso9B1VZ0sdZUN873twgpjF9tLxpA==", "X-Received": "by 2002:a05:600c:4f47:: with SMTP id\n\tm7mr4300541wmq.8.1623754303415; \n\tTue, 15 Jun 2021 03:51:43 -0700 (PDT)", "From": "David Plowman <david.plowman@raspberrypi.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 15 Jun 2021 11:51:38 +0100", "Message-Id": "<20210615105139.16171-3-david.plowman@raspberrypi.com>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20210615105139.16171-1-david.plowman@raspberrypi.com>", "References": "<20210615105139.16171-1-david.plowman@raspberrypi.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 2/3] libcamera: ipa: raspberrypi: Demote\n\twarnings about lack of AWB results", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Warnings about the lack of AWB status results are demoted to being\njust \"Debug\". With monochrome sensors becoming more common this would\notherwise overwhelm the console output, and in practice nothing is\nreally lost as it is normally very evident if AWB is failing to run.\n\nSigned-off-by: David Plowman <david.plowman@raspberrypi.com>\n---\n src/ipa/raspberrypi/controller/rpi/agc.cpp | 2 +-\n src/ipa/raspberrypi/controller/rpi/alsc.cpp | 2 +-\n 2 files changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/src/ipa/raspberrypi/controller/rpi/agc.cpp b/src/ipa/raspberrypi/controller/rpi/agc.cpp\nindex 55e80ac7..2c95f287 100644\n--- a/src/ipa/raspberrypi/controller/rpi/agc.cpp\n+++ b/src/ipa/raspberrypi/controller/rpi/agc.cpp\n@@ -481,7 +481,7 @@ void Agc::fetchAwbStatus(Metadata *image_metadata)\n \tawb_.gain_g = 1.0;\n \tawb_.gain_b = 1.0;\n \tif (image_metadata->Get(\"awb.status\", awb_) != 0)\n-\t\tLOG(RPiAgc, Warning) << \"Agc: no AWB status found\";\n+\t\tLOG(RPiAgc, Debug) << \"Agc: no AWB status found\";\n }\n \n static double compute_initial_Y(bcm2835_isp_stats *stats, AwbStatus const &awb,\ndiff --git a/src/ipa/raspberrypi/controller/rpi/alsc.cpp b/src/ipa/raspberrypi/controller/rpi/alsc.cpp\nindex b0d24aa2..c58ef7d0 100644\n--- a/src/ipa/raspberrypi/controller/rpi/alsc.cpp\n+++ b/src/ipa/raspberrypi/controller/rpi/alsc.cpp\n@@ -267,7 +267,7 @@ double get_ct(Metadata *metadata, double default_ct)\n \tAwbStatus awb_status;\n \tawb_status.temperature_K = default_ct; // in case nothing found\n \tif (metadata->Get(\"awb.status\", awb_status) != 0)\n-\t\tLOG(RPiAlsc, Warning) << \"no AWB results found, using \"\n+\t\tLOG(RPiAlsc, Debug) << \"no AWB results found, using \"\n \t\t\t\t << awb_status.temperature_K;\n \telse\n \t\tLOG(RPiAlsc, Debug) << \"AWB results found, using \"\n", "prefixes": [ "libcamera-devel", "2/3" ] }